FillArrays v1 (#128)

* FillArrays v1

* zero out matrix if dimensions mismatch in l/rmul!

Author: dlfivefifty

Project.toml

@@ -1,15 +1,15 @@
 name = "ArrayLayouts"
 uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
 authors = ["Sheehan Olver <solver@mac.com>"]
-version = "0.8.18"
+version = "0.8.19"
 
 [deps]
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 
 [compat]
-FillArrays = "0.13.2"
+FillArrays = "0.13.2, 1"
 julia = "1.6"
 
 [extras]

src/lmul.jl

@@ -49,8 +49,18 @@ rmul!(A, B; kwds...) = materialize!(Rmul(A, B); kwds...)
 
 materialize(L::Lmul) = copy(instantiate(L))
 
-copy(M::Lmul) = lmul!(M.A, copyto!(similar(M), M.B))
-copy(M::Rmul) = rmul!(copyto!(similar(M), M.A), M.B)
+# needed since in orthogonal case dimensions might mismatch and
+# so need to make sure extra entries are zero
+function _zero_copyto!(dest, A)
+    if axes(dest) == axes(A)
+        copyto!(dest, A)
+    else
+        copyto!(zero!(dest), A)
+    end
+end
+
+copy(M::Lmul) = lmul!(M.A, _zero_copyto!(similar(M), M.B))
+copy(M::Rmul) = rmul!(_zero_copyto!(similar(M), M.A), M.B)
 
 @inline function _lmul_copyto!(dest, M)
     M.B ≡ dest || copyto!(dest, M.B)