Skip to content

Commit cb98bed

Browse files
committed
Fix strides for all codeunits
1 parent 5b06af8 commit cb98bed

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

base/strings/basic.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,7 +802,7 @@ elsize(s::Type{<:CodeUnits{T}}) where {T} = sizeof(T)
802802
@propagate_inbounds getindex(s::CodeUnits, i::Int) = codeunit(s.s, i)
803803
IndexStyle(::Type{<:CodeUnits}) = IndexLinear()
804804
@inline iterate(s::CodeUnits, i=1) = (i % UInt) - 1 < length(s) ? (@inbounds s[i], i + 1) : nothing
805-
805+
strides(::CodeUnits) = (1,)
806806

807807
write(io::IO, s::CodeUnits) = write(io, s.s)
808808

base/strings/substring.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ convert(::Type{Union{String, SubString{String}}}, s::AbstractString) = convert(S
7777
function _memory_offset(x::CodeUnits{<:Any, <:Union{String, SubString{String}}}, I::Vararg{Any,N}) where {N}
7878
(_to_linear_index(x, I...) - first(LinearIndices(x)))*elsize(x)
7979
end
80-
strides(x::CodeUnits{<:Any, <:Union{String, SubString{String}}}) = (1,)
8180

8281
function String(s::SubString{String})
8382
parent = s.string

0 commit comments

Comments
 (0)