fix: check for NULL before iterating

manticore-projects · manticore-projects · commit beb68d55239d · 2023-08-23T11:36:13.000+07:00
Signed-off-by: Andreas Reichel &lt;andreas@manticore-projects.com&gt;
diff --git a/src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java b/src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java
@@ -358,8 +358,10 @@ public void visit(AnalyticExpression expr) {
         if (expr.getKeep() != null) {
             expr.getKeep().accept(this);
         }
-        for (OrderByElement element : expr.getOrderByElements()) {
-            element.getExpression().accept(this);
+        if (expr.getFuncOrderBy() != null) {
+            for (OrderByElement element : expr.getOrderByElements()) {
+                element.getExpression().accept(this);
+            }
         }
 
         if (expr.getWindowElement() != null) {

Original file line number	Diff line number	Diff line change
`@@ -358,8 +358,10 @@ public void visit(AnalyticExpression expr) {`
`358`	`358`	`if (expr.getKeep() != null) {`
`359`	`359`	`expr.getKeep().accept(this);`
`360`	`360`	`}`
`361`		`- for (OrderByElement element : expr.getOrderByElements()) {`
`362`		`- element.getExpression().accept(this);`
	`361`	`+ if (expr.getFuncOrderBy() != null) {`
	`362`	`+ for (OrderByElement element : expr.getOrderByElements()) {`
	`363`	`+ element.getExpression().accept(this);`
	`364`	`+ }`
`363`	`365`	`}`
`364`	`366`
`365`	`367`	`if (expr.getWindowElement() != null) {`