Skip to content

[Improvement] Auth: Tab SOAP Access Restriction Form #11062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjansenDatabay merged 3 commits into from
Feb 5, 2026
+53 −23
Merged

[Improvement] Auth: Tab SOAP Access Restriction Form #11062

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f402de8
[Improvement] Auth: Tab SOAP Access Restriction Form
fhelfer Feb 5, 2026
f84965d
[Improvement] Auth: Tab SOAP CS-Fixer
fhelfer Feb 5, 2026
ce1db28
[Improvement] Auth: Tab SOAP code-style preferences
fhelfer Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 53 additions & 23 deletions components/ILIAS/Authentication/classes/class.ilObjAuthSettingsGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,8 @@ public function setAuthModeObject(): void
}

private function buildSOAPForm(
string $submit_action
string $submit_action,
string $show_action
): \ILIAS\UI\Component\Input\Container\Form\Form {
$role_list = $this->rbac_review->getRolesByFilter(2, $this->object->getId());
$roles = [];
Expand Down Expand Up @@ -671,22 +672,36 @@ private function buildSOAPForm(
)
->withValue((bool) $this->settings->get('soap_auth_user_default_role', ''));

$access = $this->rbac_system->checkAccess('write', $this->object->getRefId());
$inputs = [
'active' => $active,
'server' => $server,
'port' => $port,
'use_https' => $use_https,
'uri' => $uri,
'namespace' => $namespace,
'dotnet' => $dotnet,
'createuser' => $createuser,
'sendmail' => $sendmail,
'defaultrole' => $defaultrole,
'allowlocal' => $allowlocal
];

if (!$access) {
foreach ($inputs as $key => $input) {
$inputs[$key] = $input->withDisabled(true);
}
}

$form = $this->ui_factory->input()->container()->form()->standard(
$submit_action,
[
'active' => $active,
'server' => $server,
'port' => $port,
'use_https' => $use_https,
'uri' => $uri,
'namespace' => $namespace,
'dotnet' => $dotnet,
'createuser' => $createuser,
'sendmail' => $sendmail,
'defaultrole' => $defaultrole,
'allowlocal' => $allowlocal
]
$access ? $submit_action : $show_action,
$inputs
);

if (!$access) {
$form = $form->withSubmitLabel($this->lng->txt('refresh'));
}

return $form;
}

Expand All @@ -708,7 +723,7 @@ private function buildSOAPTestForm(
'soap_pw' => $soap_pw,
'new_user' => $new_user
]
)->withSubmitLabel('Send');
)->withSubmitLabel($this->lng->txt('send'));
}

public function editSOAPObject(): void
Expand All @@ -717,8 +732,13 @@ public function editSOAPObject(): void
$this->ilias->raiseError($this->lng->txt('permission_denied'), $this->ilias->error_obj->MESSAGE);
}

$soap_form = $this->buildSOAPForm($this->ctrl->getFormAction($this, 'saveSOAP'));
$test_form = $this->buildSOAPTestForm($this->ctrl->getFormAction($this, 'testSoapAuthConnection'));
$soap_form = $this->buildSOAPForm(
$this->ctrl->getFormAction($this, 'saveSOAP'),
$this->ctrl->getFormAction($this, 'editSOAP')
);
$test_form = $this->buildSOAPTestForm(
$this->ctrl->getFormAction($this, 'testSoapAuthConnection'),
);

$this->tabs_gui->setTabActive('auth_soap');
$panel = $this->ui_factory->panel()->standard('SOAP', [$soap_form, $test_form]);
Expand All @@ -731,15 +751,20 @@ public function testSoapAuthConnectionObject(): void
$this->ilias->raiseError($this->lng->txt('permission_denied'), $this->ilias->error_obj->MESSAGE);
}

$soap_form = $this->buildSOAPForm($this->ctrl->getFormAction($this, 'saveSOAP'));
$test_form = $this->buildSOAPTestForm($this->ctrl->getFormAction($this, 'testSoapAuthConnection'));
$soap_form = $this->buildSOAPForm(
$this->ctrl->getFormAction($this, 'saveSOAP'),
$this->ctrl->getFormAction($this, 'editSOAP')
);
$test_form = $this->buildSOAPTestForm(
$this->ctrl->getFormAction($this, 'testSoapAuthConnection')
);
$panel_content = [$soap_form, $test_form];
if ($this->request->getMethod() === 'POST') {
$test_form = $test_form->withRequest($this->request);
$result = $test_form->getData();
if ($result !== null) {
$panel_content[] = $this->ui_factory->legacy()->content(
ilSOAPAuth::testConnection($result['ext_uid'], $result['soap_pw'], $result['new_user'])
ilAuthSOAP::testConnection($result['ext_uid'], $result['soap_pw'], $result['new_user'])
);
}
}
Expand All @@ -754,8 +779,13 @@ public function saveSOAPObject(): void
$this->ilias->raiseError($this->lng->txt('permission_denied'), $this->ilias->error_obj->MESSAGE);
}

$soap_form = $this->buildSOAPForm($this->ctrl->getFormAction($this, 'saveSOAP'));
$test_form = $this->buildSOAPTestForm($this->ctrl->getFormAction($this, 'testSoapAuthConnection'));
$soap_form = $this->buildSOAPForm(
$this->ctrl->getFormAction($this, 'saveSOAP'),
$this->ctrl->getFormAction($this, 'editSOAP')
);
$test_form = $this->buildSOAPTestForm(
$this->ctrl->getFormAction($this, 'testSoapAuthConnection'),
);
if ($this->request->getMethod() === 'POST') {
$soap_form = $soap_form->withRequest($this->request);
$result = $soap_form->getData();
Expand Down