Skip to content

[Improvement] Auth: Tab OpenID Connect Access Restriction Form #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjansenDatabay merged 2 commits into from
Feb 5, 2026
+45 −5
Merged

[Improvement] Auth: Tab OpenID Connect Access Restriction Form #11059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b15f0
[Improvement] Auth: Tab OpenID Connect Access Restriction Form
fhelfer Feb 5, 2026
1c5c243
[Improvement] Auth: Tab OpenIDConnect code-style preferences
fhelfer Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 45 additions & 5 deletions components/ILIAS/OpenIdConnect/classes/class.ilOpenIdConnectSettingsGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,16 @@ private function initSettingsForm(): ilPropertyFormGUI
$user_attr->setRequired(true);
$form->addItem($user_attr);

if (!$this->checkAccessBool('write')) {
foreach ($form->getItems() as $item) {
if ($item instanceof ilFormSectionHeaderGUI) {
continue;
}

$item->setDisabled(true);
}
}

return $form;
}

Expand Down Expand Up @@ -444,7 +454,7 @@ private function scopes(): void

$this->setSubTabs(self::STAB_SCOPES);
$url = $this->settings->getProvider();
if ($url !== '') {
if ($url !== '' && $this->checkAccessBool('write')) {
$this->toolbar->setFormAction($this->ctrl->getFormAction($this));
$this->toolbar->addFormButton($this->lng->txt('auth_oidc_discover_scopes'), 'discoverScopesFromServer');
}
Expand All @@ -458,14 +468,19 @@ private function initScopesForm(): Form
$this->checkAccess('read');

$ui_container = [];
$ui_container = $this->buildScopeSelection($ui_container);
$has_write_access = $this->checkAccessBool('write');
$ui_container = $this->buildScopeSelection($ui_container, $has_write_access);

/** @var Form $form */
$form = $this->ui->input()->container()->form()->standard(
$this->ctrl->getFormAction($this, 'saveScopes'),
$has_write_access ? $this->ctrl->getFormAction($this, 'saveScopes') : $this->ctrl->getFormAction($this, 'scopes'),
$ui_container
)->withAdditionalTransformation($this->saniziteArrayElementsTrafo());

if (!$has_write_access) {
$form = $form->withSubmitLabel($this->lng->txt('refresh'));
}

return $form;
}

Expand Down Expand Up @@ -493,7 +508,7 @@ private function discoverScopesFromServer(): void
* @param list<FormInput> $ui_container
* @return list<FormInput>
*/
private function buildScopeSelection(array $ui_container): array
private function buildScopeSelection(array $ui_container, bool $has_write_access): array
{
$disabled_input = $this->ui
->input()
Expand Down Expand Up @@ -551,6 +566,12 @@ private function buildScopeSelection(array $ui_container): array
);
$ui_container[] = $group;

if (!$has_write_access) {
foreach ($ui_container as $key => $item) {
$ui_container[$key] = $item->withDisabled(true);
}
}

return $ui_container;
}

Expand Down Expand Up @@ -766,6 +787,14 @@ private function initRolesForm(): ilPropertyFormGUI

if ($this->checkAccessBool('write')) {
$form->addCommandButton('saveRoles', $this->lng->txt('save'));
} else {
foreach ($form->getItems() as $item) {
if ($item instanceof ilFormSectionHeaderGUI) {
continue;
}

$item->setDisabled(true);
}
}

return $form;
Expand Down Expand Up @@ -925,6 +954,13 @@ private function initUserMappingForm(): Form
$ui_container = $this->buildUserMappingInputFormUDF($field, $ui_container);
}

$has_write_access = $this->checkAccessBool('write');
if (!$has_write_access) {
foreach ($ui_container as $key => $item) {
$ui_container[$key] = $item->withDisabled(true);
}
}

$this->ctrl->setParameter(
$this,
'opic',
Expand All @@ -937,10 +973,14 @@ private function initUserMappingForm(): Form
->container()
->form()
->standard(
$this->ctrl->getFormAction($this, 'saveProfileMapping'),
$has_write_access ? $this->ctrl->getFormAction($this, 'saveProfileMapping') : $this->ctrl->getFormAction($this, 'profile'),
$ui_container
)->withAdditionalTransformation($this->saniziteArrayElementsTrafo());

if (!$has_write_access) {
$form = $form->withSubmitLabel($this->lng->txt('refresh'));
}

return $form;
}

Expand Down