Skip to content

Use embedded_can traits & types #95

@wojciech-graj

Description

@wojciech-graj

The embedded-can crate seems to be the de-facto standard CAN interface in rust, being used by e.g. embassy and the socketcan crate. As such, I believe it would make sense to use it in this crate.

At a bare minimum, this would require implementing the Can trait on the types responsible for sending/receiving CAN frames, and implementing embedded_can Frame on Frame.

However, a more full transition could be achieved by completely replacing the automotive Identifier with that from embedded-can, and removing the send/recv methods on the sender/receiver types. I think this would be the best approach.

@pd0wm please let me know what your thoughts are, as I'd be happy to implement these changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions