Rotated frames not rendering on Hashlink

[rifxii]

After updating HaxeFlixel and all of it's backend libraries to their latest versions, I've noticed sprites specifically won't render rotated frames. This issue only seems prevalent when targeting Hashlink and it does not seem to affect the C++ target on my end.

Using the debugger console and setting the frame's angle parameter to 0 made the affected frames render once again (minus the rotation).

Sample code:

class PlayState extends FlxState
{
	override public function create()
	{
		super.create();

		var sprite:FlxSprite = new FlxSprite();
		sprite.frames = FlxAtlasFrames.fromSparrow("assets/images/TestImage.png", "assets/images/TestImage.xml");
		sprite.animation.addByPrefix("static", "TestAnimation");
		sprite.animation.play("static");
		add(sprite);
	}
}

Sample sparrow atlas with rotated frame:

<?xml version="1.0" encoding="UTF-8"?>
<TextureAtlas imagePath="TestImage.png">
    <SubTexture name="TestAnimation0001" x="0" y="0" width="150" height="150" rotated="true"/>
</TextureAtlas>

[MaybeMaru]

So ive been playing around trying to fix this issue and it seems to come from abstract vectors being broken on hashlink. Im not entirely sure why but adding or removing traces without altering real code made the matrix calculations work or break, seeming at random. I made a quick fix that i could PR that calculates the matrix using another method, though tbh in my opinion I would just revert the MatrixVector, its a breaking change for people that used tileMatrix and blitMatrix (because of casting) and just overcomplicates it.

[Geokureli]

Can you prvide a simple example of the HL abstract issue, and clarify what you mean by "just revert the MatrixVector". What change needs to be reverted?

[MaybeMaru]

Can you prvide a simple example of the HL abstract issue, and clarify what you mean by "just revert the MatrixVector". What change needs to be reverted?

The problem comes from the abstract causing issues on HL specifically, I cant really pin point the exact issue but try running this piece of code both on the Hxcpp target and the HL target and it'll give different results for the matrix values (At least it does where its called in FlxFrame, which causes this rotated frames not rendering issue).

var tileMatrix = frame.tileMatrix.copyFrom(frame, false);
var calculatedMatrix:FlxMatrix = tileMatrix.copyTo(new FlxMatrix());
trace(calculatedMatrix);

Another problem with MatrixVector is that its lacking a to Vector<Float> in the abstract, so previous code that used tileMatrix or blitMatrix in the past will break.
For example, this piece of code that used to work before 6.1.0 breaks with the new MatrixVector:

var tileMatrix = frame.tileMatrix;
var tileMatrixA = tileMatrix[0];

If it's not something thats going to be reverted or made type safe it would be nice to atleast have some docs talking about the breaking change, like in the 6.0.0 update.

[Cheemsandfriends]

Can you prvide a simple example of the HL abstract issue

Can you test the code you're making that affects everyone at large? 🥀

Why was this even needed?

[Geokureli]

Looks like this is the change that caused the issue: #3395

Can you test the code you're making that affects everyone at large? 🥀

If this also affected you, let me know how.

[Geokureli]

@rifxii posted this in the #3454 and created a haxe issue

After a bit more testing I've discovered that the odd behavior with Hashlink is able to be reproduced on the other platforms that I've tested. I created an issue on the Haxe repo regarding this: HaxeFoundation/haxe#12331.

I'll close the PR for now since this seems to be a non-flixel issue.