Skip to content

Add missing value types to EfAnalysisConstants #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HandyS11 merged 2 commits into from
Feb 3, 2026
Merged

Add missing value types to EfAnalysisConstants #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982886b
Initial plan
Copilot Feb 3, 2026
cc0b83b
feat: add missing value types to EfAnalysisConstants
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/ProjGraph.Lib/Services/EfAnalysis/Constants/EfAnalysisConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ public static class DataTypes
public const string Long = "long";
public const string Single = "Single";
public const string Short = "short";
public const string Byte = "byte";
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .NET type name constant for Byte. Following the existing pattern (e.g., Int and Int32, Bool and Boolean), there should be a constant named Byte with value "Byte" to represent the .NET BCL type name, in addition to the lowercase byte keyword alias.

Copilot uses AI. Check for mistakes.
public const string SByte = "sbyte";
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .NET type name constant for SByte. Following the existing pattern (e.g., Int and Int32, Bool and Boolean), there should be a constant named SByte with value "SByte" to represent the .NET BCL type name, in addition to the lowercase sbyte keyword alias. This is necessary for proper type detection when the type is referenced by its .NET name.

Copilot uses AI. Check for mistakes.
public const string UShort = "ushort";
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing UInt16 constant for the .NET BCL type name. The unsigned short type has the .NET name UInt16, not UShort. Following the existing pattern (e.g., Long/Int64, UInt/UInt32), there should be both UShort with value "ushort" (the C# keyword) and UInt16 with value "UInt16" (the .NET type name).

Copilot uses AI. Check for mistakes.
public const string UInt = "uint";
public const string UInt32 = "UInt32";
public const string ULong = "ulong";
public const string UInt64 = "UInt64";
public const string Char = "char";
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .NET type name constant for Char. Following the existing pattern (e.g., Int and Int32, Bool and Boolean), there should be a constant named Char with value "Char" to represent the .NET BCL type name, in addition to the lowercase char keyword alias.

Copilot uses AI. Check for mistakes.

/// <summary>
/// A set of common .NET value types that are treated as having a default value in EF.
Expand All @@ -46,7 +54,15 @@ public static class DataTypes
Double,
Float,
Single,
Short
Short,
Byte,
SByte,
UShort,
UInt,
UInt32,
ULong,
UInt64,
Char
Comment on lines +58 to +65
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ValueTypes HashSet is missing the .NET BCL type name equivalents for the newly added types. Following the existing pattern where both C# keyword aliases and .NET type names are included (e.g., Int and Int32, Bool and Boolean), the following should be added after defining the missing constants: a reference to Byte (for "Byte"), a reference to SByte (for "SByte"), a reference to UInt16 (for "UInt16"), and a reference to Char (for "Char"). This ensures proper type detection regardless of whether the type is referenced using the C# keyword or the .NET type name.

Copilot uses AI. Check for mistakes.
};
}

Expand Down
Loading