-
Notifications
You must be signed in to change notification settings - Fork 85
Add GitHub issues integration #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
commit: |
403348c to
5075da7
Compare
5075da7 to
571bc06
Compare
SamyPesse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
| # GitHub | ||
| GITHUB_APP_INSTALL_URL: ${{ secrets.GITBOOK_GITHUB_APP_INSTALL_URL }} | ||
| GITHUB_APP_ID: ${{ secrets.GITBOOK_GITHUB_APP_ID }} | ||
| GITHUB_APP_NAME: ${{ secrets.GITHUB_APP_NAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
Should it be a 1password entry now? we should avoid secrets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name of the app that GitHub generates based on the title of the app that we provide. We need it to build the app installation URL (btw we use a similar approach in github-copilot integration). It changes based on the environment (e.g prod app != staging app != dev app), so we need to somehow pass it via the gitbook-manifest and be able to retrive it at runtime.
We don't have to store it in 1Password and hardcode the value in the manifest. But I don't know how to pass env variables per enviroment to integration other than passing the value as a secret.
Any suggestions?
This PR aims to add the GitHub issues integration.
Part https://linear.app/gitbook-x/issue/RND-8917/add-github-issues-integration