Revert "Fixed String& -> char*"

This reverts commit e721c80.

Eh I think we still want the String&, going to use c_str()

Author: ed7coyne

examples/FirebaseDemo_ESP8266/FirebaseDemo_ESP8266.ino

@@ -26,7 +26,7 @@
 #define WIFI_SSID "SSID"
 #define WIFI_PASSWORD "PASSWORD"
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

examples/FirebaseRoom_ESP8266/FirebaseRoom_ESP8266.ino

@@ -26,7 +26,7 @@
 #define WIFI_SSID "SSID"
 #define WIFI_PASSWORD "PASSWORD"
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

examples/FirebaseSerialHost_ESP8266/FirebaseSerialHost_ESP8266.ino

@@ -43,7 +43,7 @@ firebase::modem::SerialTransceiver transceiver;
 #define WIFI_SSID "SSID"
 #define WIFI_PASSWORD "PASSWORD"
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

examples/FirebaseStream_ESP8266/FirebaseStream_ESP8266.ino

@@ -35,7 +35,7 @@ FirebaseStream stream;
 
 Firebase fbase = Firebase(FIREBASE_HOST, FIREBASE_AUTH);
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

examples/Firebase_ESP8266_LEDs/Firebase_ESP8266_Neopixel/Firebase_ESP8266_Neopixel.ino

@@ -33,7 +33,7 @@ Adafruit_NeoPixel strip = Adafruit_NeoPixel(32, PIN, NEO_GRB + NEO_KHZ800);
 
 Firebase fbase = Firebase(FIREBASE_HOST, FIREBASE_AUTH);
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

test/travis/firebase_arduino_init.cc.snip

@@ -4,7 +4,7 @@
 #define WIFI_SSID "SSID"
 #define WIFI_PASSWORD "PASSWORD"
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

test/travis/firebase_init.cc.snip

@@ -6,7 +6,7 @@
 
 Firebase fbase = Firebase(FIREBASE_HOST, FIREBASE_AUTH);
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {

test/travis/no_firebase_init.cc.snip

@@ -2,7 +2,7 @@
 #define WIFI_SSID "SSID"
 #define WIFI_PASSWORD "PASSWORD"
 
-void ConnectWifi(const char* ssid, const char* password = "") {
+void ConnectWifi(const String& ssid, const String& password = "") {
   if (password != "") {
     WiFi.begin(ssid, password);
   } else {