Merge pull request #138 from ed7coyne/both-strings

Support both string types in FirebaseArduino.h

Author: proppy

src/FirebaseArduino.cpp

@@ -16,7 +16,7 @@
 
 #include "FirebaseArduino.h"
 
-void FirebaseArduino::begin(const char* host, const char* auth) {
+void FirebaseArduino::begin(const String& host, const String& auth) {
   http_.reset(FirebaseHttpClient::create());
   http_->setReuseConnection(true);
   host_ = host;
@@ -38,7 +38,7 @@ void FirebaseArduino::set(const String& path, const JsonVariant& value) {
   error_ = set.error();
 }
 
-FirebaseObject FirebaseArduino::get(const char* path) {
+FirebaseObject FirebaseArduino::get(const String& path) {
   auto get = FirebaseGet(host_, auth_, path, http_.get());
   error_ = get.error();
   if (failed()) {
@@ -47,7 +47,7 @@ FirebaseObject FirebaseArduino::get(const char* path) {
   return FirebaseObject(get.response());
 }
 
-int FirebaseArduino::getInt(const char* path) {
+int FirebaseArduino::getInt(const String& path) {
   auto get = FirebaseGet(host_, auth_, path, http_.get());
   error_ = get.error();
   if (failed()) {
@@ -57,7 +57,7 @@ int FirebaseArduino::getInt(const char* path) {
 }
 
 
-float FirebaseArduino::getFloat(const char* path) {
+float FirebaseArduino::getFloat(const String& path) {
   auto get = FirebaseGet(host_, auth_, path, http_.get());
   error_ = get.error();
   if (failed()) {
@@ -66,7 +66,7 @@ float FirebaseArduino::getFloat(const char* path) {
   return FirebaseObject(get.response()).getFloat();
 }
 
-String FirebaseArduino::getString(const char* path) {
+String FirebaseArduino::getString(const String& path) {
   auto get = FirebaseGet(host_, auth_, path, http_.get());
   error_ = get.error();
   if (failed()) {
@@ -75,21 +75,20 @@ String FirebaseArduino::getString(const char* path) {
   return FirebaseObject(get.response()).getString();
 }
 
-bool FirebaseArduino::getBool(const char* path) {
+bool FirebaseArduino::getBool(const String& path) {
   auto get = FirebaseGet(host_, auth_, path, http_.get());
   error_ = get.error();
   if (failed()) {
     return "";
   }
   return FirebaseObject(get.response()).getBool();
 }
-
-void FirebaseArduino::remove(const char* path) {
+void FirebaseArduino::remove(const String& path) {
   auto remove = FirebaseRemove(host_, auth_, path, http_.get());
   error_ = remove.error();
 }
 
-void FirebaseArduino::stream(const char* path) {
+void FirebaseArduino::stream(const String& path) {
   auto stream = FirebaseStream(host_, auth_, path, http_.get());
   error_ = stream.error();
 }

src/FirebaseArduino.h

@@ -35,7 +35,7 @@ class FirebaseArduino {
    * \param host Your firebase db host, usually X.firebaseio.com.
    * \param auth Optional credentials for the db, a secret or token.
    */
-  void begin(const char* host, const char* auth = "");
+  void begin(const String& host, const String& auth = "");
 
   /**
    * Writes data to a new child location under the parent at path. 
@@ -63,47 +63,47 @@ class FirebaseArduino {
    * \param path The path to the node you wish to retrieve.
    * \return The integer value located at that path. Will only be populated if success() is true.
    */
-  int getInt(const char* path);
+  int getInt(const String& path);
 
   /**
    * Gets the float value located at path.
    * You should check success() after calling.
    * \param path The path to the node you wish to retrieve.
    * \return The float value located at that path. Will only be populated if success() is true.
    */
-  float getFloat(const char* path);
+  float getFloat(const String& path);
 
   /**
    * Gets the string value located at path.
    * You should check success() after calling.
    * \param path The path to the node you wish to retrieve.
    * \return The string value located at that path. Will only be populated if success() is true.
    */
-  String getString(const char* path);
+  String getString(const String& path);
 
   /**
    * Gets the boolean value located at path.
    * You should check success() after calling.
    * \param path The path to the node you wish to retrieve.
    * \return The boolean value located at that path. Will only be populated if success() is true.
    */
-  bool getBool(const char* path);
+  bool getBool(const String& path);
 
   /**
    * Gets the json object value located at path.
    * You should check success() after calling.
    * \param path The path to the node you wish to retrieve.
    * \return a FirebaseObject value located at that path. Will only be populated if success() is true.
    */
-  FirebaseObject get(const char* path);
+  FirebaseObject get(const String& path);
 
   /**
    * Remove the node, and possibly entire tree, located at path.
    * You should check success() after calling.
    * \param path The path to the node you wish to remove,
    * including all of its children.
    */
-  void remove(const char* path);
+  void remove(const String& path);
 
   /**
    * Starts streaming any changes made to the node located at path, including
@@ -113,7 +113,7 @@ class FirebaseArduino {
    * monitoring available() and calling readEvent() to get new events.
    * \param path The path inside of your db to the node you wish to monitor.
    */
-  void stream(const char* path);
+  void stream(const String& path);
 
   /**
    * Checks if there are new events available. This is only meaningful once