checked all exceptions

FeDevv · FeDevv · commit 5fffdc05c3bd · 2025-12-19T15:20:03.000+01:00
diff --git a/GA-Maven/src/main/java/org/agroplanner/Main.java b/GA-Maven/src/main/java/org/agroplanner/Main.java
@@ -15,6 +15,4 @@ public static void main(String[] args) {
 /*
 * OBIETTIVI
 * 1. RISCRIVI I COMMENTI
-* 2. CONTROLLARE CODE SMELLS
-* 3. ricontrollare i flussi di exception
 */
diff --git a/GA-Maven/src/main/java/org/agroplanner/domainsystem/controllers/DomainService.java b/GA-Maven/src/main/java/org/agroplanner/domainsystem/controllers/DomainService.java
@@ -24,14 +24,10 @@
  */
 public class DomainService {
 
-    private final DomainFactory factory;
-
     /**
      * Initializes the service and retrieves the singleton instance of the Factory.
      */
-    public DomainService() {
-        this.factory = DomainFactory.getInstance();
-    }
+    public DomainService() {  }
 
     /**
      * Retrieves the list of supported domain types.
@@ -62,7 +58,7 @@ public List<DomainType> getAvailableDomainTypes() {
      * @return A new, fully validated instance of {@link Domain}.
      */
     public Domain createDomain(DomainType type, Map<String, Double> params) {
-        return factory.createDomain(type, params);
+        return DomainFactory.getInstance().createDomain(type, params);
     }
 
     /**
diff --git a/GA-Maven/src/main/java/org/agroplanner/domainsystem/model/DomainFactory.java b/GA-Maven/src/main/java/org/agroplanner/domainsystem/model/DomainFactory.java
@@ -20,8 +20,7 @@
  *
  * <p><strong>Pattern:</strong> Singleton (Initialization-on-demand holder idiom).</p>
  */
-public final class DomainFactory {
-
+public class DomainFactory {
 
     /**
      * Private constructor to prevent direct instantiation.
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/controllers/ExportConsoleController.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/controllers/ExportConsoleController.java
@@ -56,8 +56,8 @@ public void runExportWizard(Individual solution, Domain domain, PlantInventory i
         while (true) {
 
             // STEP 1: Select Format
-            view.showAvailableExports(service.getAvailableTypes());
-            Optional<ExportType> selectedType = view.askForExportType(service.getAvailableTypes());
+            view.showAvailableExports(service.getAvailableExportTypes());
+            Optional<ExportType> selectedType = view.askForExportType(service.getAvailableExportTypes());
 
             // If user cancels (returns Empty), exit the wizard.
             if (selectedType.isEmpty()) return;
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/controllers/ExportService.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/controllers/ExportService.java
@@ -29,20 +29,16 @@
  */
 public class ExportService {
 
-    private final ExporterFactory factory;
-
     /**
      * Initializes the service by retrieving the Factory instance.
      */
-    public ExportService() {
-        this.factory = ExporterFactory.getInstance();
-    }
+    public ExportService() {  }
 
     /**
      * Retrieves the list of supported export formats.
      * @return A list of all available {@link ExportType}s.
      */
-    public List<ExportType> getAvailableTypes() {
+    public List<ExportType> getAvailableExportTypes() {
         return Arrays.asList(ExportType.values());
     }
 
@@ -86,7 +82,7 @@ public String performExport(Individual solution, Domain domain, PlantInventory i
         // --- EXECUTION & ERROR WRAPPING ---
         try {
             // Get the specific strategy from the factory
-            BaseExporter exporter = factory.createExporter(type);
+            BaseExporter exporter = ExporterFactory.getInstance().createExporter(type);
 
             // Execute the template method.
             // If export() throws IOException, we catch it here.
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/ExporterFactory.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/ExporterFactory.java
@@ -20,7 +20,9 @@ public class ExporterFactory {
     // ------------------- SINGLETON PATTERN -------------------
 
     /** Private constructor to prevent direct instantiation. */
-    private ExporterFactory() {}
+    private ExporterFactory() {
+
+    }
 
     /**
      * Static Inner Class (Lazy Holder).
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/CSVExporter.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/CSVExporter.java
@@ -74,9 +74,9 @@ protected void performExport(Individual individual, Domain domain, PlantInventor
 
             for (InventoryEntry entry : inventory.getEntries()) {
                 // Esempio output: # - TOMATO (🍅): 50 units, r=1.50
-                writer.write(String.format(Locale.US, "# - %s (%s): %d units, r=%.2f",
-                        entry.getType().name(),      // Nome (ex key)
-                        entry.getType().getLabel(),  // Emoji (ex key)
+                writer.write(String.format(Locale.US, "# - %s (%s): %d units, r=%.2fm",
+                        entry.getType().name(),      // Nome
+                        entry.getType().getLabel(),  // Emoji
                         entry.getQuantity(),         // Quantità
                         entry.getRadius()));         // Raggio specificato per questa riga
 
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/PdfExporter.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/PdfExporter.java
@@ -88,7 +88,7 @@ protected void performExport(Individual individual, Domain domain, PlantInventor
             for (InventoryEntry item : inventory.getEntries()) {
 
                 // E.g.: " - 🍅 TOMATO: 50 units (r=1.50)"
-                String line = String.format(Locale.US, " - %s %s: %d units (r=%.2f)",
+                String line = String.format(Locale.US, " - %s %s: %d units (r=%.2fm)",
                         item.getType().getLabel(), // Emoji (recuperato da getType)
                         item.getType().name(),     // Nome (recuperato da getType)
                         item.getQuantity(),        // Quantità diretta dell'entry
@@ -122,9 +122,9 @@ protected void performExport(Individual individual, Domain domain, PlantInventor
             // Headers
             addHeaderCell(table, "ID");
             addHeaderCell(table, "Type");
-            addHeaderCell(table, "X");
-            addHeaderCell(table, "Y");
-            addHeaderCell(table, "Radius");
+            addHeaderCell(table, "X(m)");
+            addHeaderCell(table, "Y(m)");
+            addHeaderCell(table, "Radius(m)");
 
             // Data Population
             int index = 0;
diff --git a/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/TxtExporter.java b/GA-Maven/src/main/java/org/agroplanner/exportsystem/model/types/TxtExporter.java
@@ -65,7 +65,7 @@ protected void performExport(Individual individual, Domain domain, PlantInventor
             // Iteriamo sulla lista degli inserimenti
             for (InventoryEntry entry : inventory.getEntries()) {
                 // e.g. " - 🍅 TOMATO: 50 units (r=1.50)"
-                String line = String.format(Locale.US, " - %s %s: %d units (r=%.2f)",
+                String line = String.format(Locale.US, " - %s %s: %d units (r=%.2fm)",
                         entry.getType().getLabel(),  // Emoji
                         entry.getType().name(),      // Nome
                         entry.getQuantity(),         // Quantità
@@ -89,7 +89,7 @@ protected void performExport(Individual individual, Domain domain, PlantInventor
             // --- DATA LIST SECTION ---
             writer.write("--- Chromosomes (Coordinates) ---");
             writer.newLine();
-            writer.write("Format: [ID] TYPE | X | Y | Radius");
+            writer.write("Format: [ID] TYPE | X(m) | Y(m) | Radius(m)");
             writer.newLine();
 
             int index = 0;
diff --git a/GA-Maven/src/main/java/org/agroplanner/gasystem/controllers/EvolutionConsoleController.java b/GA-Maven/src/main/java/org/agroplanner/gasystem/controllers/EvolutionConsoleController.java
@@ -85,6 +85,13 @@ public Individual runEvolution() throws EvolutionTimeoutException, MaxAttemptsEx
             // EXECUTION: Delegate heavy lifting to the Service
             // This blocks until the cycle finishes or timeouts.
             lastSolution = service.executeEvolutionCycle();
+            // EXECUTION & TIMEOUT MANAGEMENT
+            // We purposefully do NOT catch EvolutionTimeoutException here.
+            // Logic:
+            // 1. If the Service enforces a timeout, it means the calculation is stuck.
+            // 2. We apply the "Fail Fast" principle: immediately bubble up the exception
+            //    to the MainController to abort the session and free resources.
+            // 3. Retrying locally (looping) after a timeout is usually futile and risks freezing the UI.
 
             Instant end = Instant.now();
             double durationMs = Duration.between(start, end).toMillis();
@@ -105,6 +112,21 @@ public Individual runEvolution() throws EvolutionTimeoutException, MaxAttemptsEx
         } while (currentAttempt < MAX_RETRY_ATTEMPTS);
 
 
+        // ==================================================================================
+        // CRITICAL FAILURE HANDLING STRATEGY (Bubble-Up)
+        // ==================================================================================
+        // Why do we throw exceptions here instead of handling them?
+        //
+        // 1. EXHAUSTED RECOVERY: The 'do-while' loop above IS the local recovery mechanism.
+        //    If we exit the loop, it means the algorithm failed to converge even after
+        //    MAX_RETRY_ATTEMPTS. The controller has done all it can.
+        //
+        // 2. FLOW CONTROL: By throwing the exception to the MainController, we trigger
+        //    a clean "Session Abort" and reset. If we caught it here, we would have to
+        //    return null/Optional, forcing the MainController to perform null-checks.
+        //    Exceptions provide a cleaner control flow for fatal errors.
+        // ==================================================================================
+
         // CRITICAL FAILURE (Exhausted Attempts)
         // If we exit the loop, it means we failed N times.
         // We construct a detailed error report and abort the session.
diff --git a/GA-Maven/src/main/java/org/agroplanner/gasystem/controllers/EvolutionService.java b/GA-Maven/src/main/java/org/agroplanner/gasystem/controllers/EvolutionService.java
@@ -124,7 +124,7 @@ public EvolutionService(Domain domain, PlantInventory inventory) {
      * @return The best {@link Individual} evolved during this cycle.
      * @throws EvolutionTimeoutException If the process exceeds the calculated time budget.
      */
-    public Individual executeEvolutionCycle() {
+    public Individual executeEvolutionCycle() throws EvolutionTimeoutException {
 
         // 1. Setup Time Budget (Safety Mechanism against infinite loops or excessive lag)
         long maxDurationMs = EvolutionUtils.calculateTimeBudget(inventory.getTotalPopulationSize());
diff --git a/GA-Maven/src/main/java/org/agroplanner/inventory/model/PlantInventory.java b/GA-Maven/src/main/java/org/agroplanner/inventory/model/PlantInventory.java
@@ -13,7 +13,7 @@ public PlantInventory() {
         this.entries = new ArrayList<>();
     }
 
-    public void addEntry(PlantType type, int quantity, double radius) {
+    public void addEntry(PlantType type, int quantity, double radius) throws InvalidInputException {
         // Validazione essenziale
         if (type == null) throw new InvalidInputException("PlantType cannot be null.");
         if (quantity <= 0) throw new InvalidInputException("Quantity must be positive.");
diff --git a/GA-Maven/src/main/java/org/agroplanner/optimizer/controllers/OptimizerConsoleController.java b/GA-Maven/src/main/java/org/agroplanner/optimizer/controllers/OptimizerConsoleController.java
@@ -64,7 +64,6 @@ public OptimizerConsoleController() {
         this.optView = new ConsoleOptimizerView(scanner);
 
         // Service Initialization
-        // These are stateless factories/calculators, so we instantiate them once.
         this.domainService = new DomainService();
         this.exportService = new ExportService();
     }
@@ -210,4 +209,23 @@ public void run() {
         // Cleanup
         scanner.close();
     }
+    // ==================================================================================
+    // ARCHITECTURAL NOTE: MANUAL DEPENDENCY INJECTION (WIRING)
+    // ==================================================================================
+    // Rationale for instantiating Views here and injecting them into Controllers:
+    //
+    // 1. DECOUPLING (Inversion of Control):
+    //    Controllers depend on 'View Interfaces' (e.g., DomainView), not concrete implementations.
+    //    This ensures the Business Logic is not hard-coded to the Console. We could swap
+    //    'ConsoleDomainView' with a 'JavaFXDomainView' without changing a single line of the Controller.
+    //
+    // 2. TESTABILITY:
+    //    By injecting the View from the outside, we can easily pass a "MockView" during Unit Tests.
+    //    This allows testing the Controller flow without blocking on real user input.
+    //
+    // 3. RESOURCE MANAGEMENT (The Scanner Issue):
+    //    We rely on a SINGLE shared 'Scanner' for System.in to prevent stream closure issues.
+    //    The MainController acts as the "Orchestrator" (Wiring), passing this shared resource
+    //    safely to the Views, keeping the Controllers clean of low-level I/O details.
+    // ==================================================================================
 }

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,7 @@`
`20`	`20`	`*`
`21`	`21`	`* <p><strong>Pattern:</strong> Singleton (Initialization-on-demand holder idiom).</p>`
`22`	`22`	`*/`
`23`		`-public final class DomainFactory {`
`24`		`-`
	`23`	`+public class DomainFactory {`
`25`	`24`
`26`	`25`	`/**`
`27`	`26`	`* Private constructor to prevent direct instantiation.`