From f79f5b94fa15a14294bfff46066fcc1598075cc1 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:13:55 -0500 Subject: [PATCH 01/16] feat(commands): add /compound-engineering-setup for configurable agents MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds a new setup command that allows users to configure which review agents to use instead of hardcoding them in workflows. This enables: - Multi-step onboarding with AskUserQuestion for easy setup - Auto-detection of project type (Rails, Python, TypeScript, etc.) - Three setup modes: Quick (smart defaults), Advanced, and Minimal - Configuration stored in .claude/compound-engineering.json - Support for both global (~/.claude/) and project-specific config Updated workflows to read from config: - /workflows:review - reads reviewAgents from config - /plan_review - reads planReviewAgents from config - /workflows:work - references config for reviewer agents - /workflows:compound - references config for specialized agents πŸ€– Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- .claude-plugin/marketplace.json | 4 +- .../.claude-plugin/plugin.json | 4 +- plugins/compound-engineering/CHANGELOG.md | 35 ++ plugins/compound-engineering/README.md | 7 +- .../commands/plan_review.md | 60 ++- .../compound-engineering/commands/setup.md | 456 ++++++++++++++++++ .../commands/workflows/compound.md | 27 +- .../commands/workflows/review.md | 67 ++- .../commands/workflows/work.md | 20 +- 9 files changed, 631 insertions(+), 49 deletions(-) create mode 100644 plugins/compound-engineering/commands/setup.md diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 4e22718b..d4cf1dc4 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -11,8 +11,8 @@ "plugins": [ { "name": "compound-engineering", - "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 28 specialized agents, 24 commands, and 15 skills.", - "version": "2.28.0", + "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 28 specialized agents, 25 commands, and 15 skills.", + "version": "2.29.0", "author": { "name": "Kieran Klaassen", "url": "https://github.com/kieranklaassen", diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index 97ea7426..a9f29f92 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "compound-engineering", - "version": "2.28.0", - "description": "AI-powered development tools. 28 agents, 24 commands, 15 skills, 1 MCP server for code review, research, design, and workflow automation.", + "version": "2.29.0", + "description": "AI-powered development tools. 28 agents, 25 commands, 15 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", "email": "kieran@every.to", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index dd1c7f9e..c8d162c0 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,6 +5,41 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.29.0] - 2026-01-25 + +### Added + +- **`/compound-engineering-setup` command** - Configure plugin agents and preferences + - Multi-step onboarding with AskUserQuestion for easy setup + - Auto-detects project type (Rails, Python, TypeScript, etc.) + - Three setup modes: Quick (smart defaults), Advanced (manual selection), Minimal + - Creates `.claude/compound-engineering.json` config file + - Supports global config (`~/.claude/`) or project-specific (`.claude/`) + +### Changed + +- **`/workflows:review`** - Now reads review agents from config file instead of hardcoding +- **`/plan_review`** - Now reads plan review agents from config file +- **`/workflows:work`** - References config for optional reviewer agents +- **`/workflows:compound`** - References config for specialized agent invocation + +### Configuration + +New config file format (`.claude/compound-engineering.json`): +```json +{ + "projectType": "rails", + "reviewAgents": ["kieran-rails-reviewer", "code-simplicity-reviewer", "security-sentinel"], + "planReviewAgents": ["kieran-rails-reviewer", "code-simplicity-reviewer"], + "conditionalAgents": { + "migrations": ["data-migration-expert", "deployment-verification-agent"], + "frontend": ["julik-frontend-races-reviewer"] + } +} +``` + +--- + ## [2.28.0] - 2026-01-21 ### Added diff --git a/plugins/compound-engineering/README.md b/plugins/compound-engineering/README.md index b1a710d3..9660ad8d 100644 --- a/plugins/compound-engineering/README.md +++ b/plugins/compound-engineering/README.md @@ -6,9 +6,9 @@ AI-powered development tools that get smarter with every use. Make each unit of | Component | Count | |-----------|-------| -| Agents | 27 | -| Commands | 20 | -| Skills | 14 | +| Agents | 28 | +| Commands | 25 | +| Skills | 15 | | MCP Servers | 1 | ## Agents @@ -90,6 +90,7 @@ Core workflow commands use `workflows:` prefix to avoid collisions with built-in | `/create-agent-skill` | Create or edit Claude Code skills | | `/generate_command` | Generate new slash commands | | `/heal-skill` | Fix skill documentation issues | +| `/compound-engineering-setup` | Configure plugin agents and preferences | | `/plan_review` | Multi-agent plan review in parallel | | `/report-bug` | Report a bug in the plugin | | `/reproduce-bug` | Reproduce bugs using logs and console | diff --git a/plugins/compound-engineering/commands/plan_review.md b/plugins/compound-engineering/commands/plan_review.md index 70ef5ddc..feeb0b04 100644 --- a/plugins/compound-engineering/commands/plan_review.md +++ b/plugins/compound-engineering/commands/plan_review.md @@ -4,4 +4,62 @@ description: Have multiple specialized agents review a plan in parallel argument-hint: "[plan file path or plan content]" --- -Have @agent-dhh-rails-reviewer @agent-kieran-rails-reviewer @agent-code-simplicity-reviewer review this plan in parallel. +# Plan Review + +Review a plan using configured agents from `.claude/compound-engineering.json`. + +## Load Configuration + + + +Check for configuration file: + +```bash +# Check project config first, then global +if [ -f .claude/compound-engineering.json ]; then + CONFIG_FILE=".claude/compound-engineering.json" +elif [ -f ~/.claude/compound-engineering.json ]; then + CONFIG_FILE="~/.claude/compound-engineering.json" +else + CONFIG_FILE="" +fi +``` + +**If config exists:** Read `planReviewAgents` array from the config file. + +**If no config exists:** Use these defaults: +- `code-simplicity-reviewer` +- `architecture-strategist` + +Or prompt: "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults?" + + + +## Execute Review + +For each agent in `planReviewAgents`: + +``` +Task {agent-name}("Review this plan: {plan content}") +``` + +Run all agents in parallel using multiple Task tool calls in a single message. + +## Example Config + +```json +{ + "planReviewAgents": [ + "kieran-rails-reviewer", + "code-simplicity-reviewer" + ] +} +``` + +## Fallback Defaults + +If no config and user wants defaults: +- **Rails projects**: `kieran-rails-reviewer`, `code-simplicity-reviewer` +- **Python projects**: `kieran-python-reviewer`, `code-simplicity-reviewer` +- **TypeScript projects**: `kieran-typescript-reviewer`, `code-simplicity-reviewer` +- **General**: `code-simplicity-reviewer`, `architecture-strategist` diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/commands/setup.md new file mode 100644 index 00000000..f417cade --- /dev/null +++ b/plugins/compound-engineering/commands/setup.md @@ -0,0 +1,456 @@ +--- +name: compound-engineering-setup +description: Configure compound-engineering plugin agents and preferences for your project +argument-hint: "[--global to configure globally]" +--- + +# Compound Engineering Setup + +Configure which review agents and workflows to use for this project. Creates a `.claude/compound-engineering.json` configuration file. + +## Detect Configuration Location + + + +Check if user passed `--global` argument: +- **If `--global`**: Configure at `~/.claude/compound-engineering.json` (applies to all projects) +- **Otherwise**: Configure at `.claude/compound-engineering.json` (project-specific) + +Check if configuration already exists: +```bash +# Check project config +test -f .claude/compound-engineering.json && echo "Project config exists" + +# Check global config +test -f ~/.claude/compound-engineering.json && echo "Global config exists" +``` + +If config exists, offer to edit existing or start fresh. + + + +## Step 1: Detect Project Type + + + +Detect the primary language/framework automatically: + +```bash +# Check for common project indicators +ls -la Gemfile package.json requirements.txt pyproject.toml Cargo.toml go.mod pom.xml 2>/dev/null +ls -la *.xcodeproj *.xcworkspace Package.swift 2>/dev/null +``` + +**Detection Rules:** +- `Gemfile` + `config/routes.rb` β†’ **Rails** +- `Gemfile` without Rails β†’ **Ruby** +- `package.json` + `tsconfig.json` β†’ **TypeScript** +- `package.json` without TypeScript β†’ **JavaScript** +- `requirements.txt` OR `pyproject.toml` β†’ **Python** +- `Cargo.toml` β†’ **Rust** +- `go.mod` β†’ **Go** +- `*.xcodeproj` OR `Package.swift` β†’ **Swift/iOS** +- None of the above β†’ **General** + +Store detected type for recommendations. + + + +## Step 2: Quick vs Advanced Setup + + + +Use AskUserQuestion to determine setup mode: + +``` +AskUserQuestion: + questions: + - question: "How would you like to configure compound-engineering?" + header: "Setup mode" + options: + - label: "Quick Setup (Recommended)" + description: "Use smart defaults based on your project type. Best for most users." + - label: "Advanced Setup" + description: "Manually select each agent and configure options. For power users." + - label: "Minimal Setup" + description: "Only essential agents (security + code quality). Fastest reviews." +``` + + + +## Step 3A: Quick Setup Flow + + + +If user chose "Quick Setup": + +### Rails Projects +Default config: +```json +{ + "projectType": "rails", + "reviewAgents": [ + "kieran-rails-reviewer", + "dhh-rails-reviewer", + "code-simplicity-reviewer", + "security-sentinel", + "performance-oracle" + ], + "planReviewAgents": [ + "kieran-rails-reviewer", + "code-simplicity-reviewer" + ], + "conditionalAgents": { + "migrations": ["data-migration-expert", "deployment-verification-agent"], + "frontend": ["julik-frontend-races-reviewer"], + "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + } +} +``` + +### Python Projects +Default config: +```json +{ + "projectType": "python", + "reviewAgents": [ + "kieran-python-reviewer", + "code-simplicity-reviewer", + "security-sentinel", + "performance-oracle" + ], + "planReviewAgents": [ + "kieran-python-reviewer", + "code-simplicity-reviewer" + ], + "conditionalAgents": { + "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + } +} +``` + +### TypeScript Projects +Default config: +```json +{ + "projectType": "typescript", + "reviewAgents": [ + "kieran-typescript-reviewer", + "code-simplicity-reviewer", + "security-sentinel", + "performance-oracle" + ], + "planReviewAgents": [ + "kieran-typescript-reviewer", + "code-simplicity-reviewer" + ], + "conditionalAgents": { + "frontend": ["julik-frontend-races-reviewer"], + "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + } +} +``` + +### General/Other Projects +Default config: +```json +{ + "projectType": "general", + "reviewAgents": [ + "code-simplicity-reviewer", + "security-sentinel", + "performance-oracle" + ], + "planReviewAgents": [ + "code-simplicity-reviewer" + ], + "conditionalAgents": { + "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + } +} +``` + + + +## Step 3B: Advanced Setup Flow + + + +If user chose "Advanced Setup", walk through each category: + +### Question 1: Primary Code Review Agents + +``` +AskUserQuestion: + questions: + - question: "Which code review agents should run on every PR?" + header: "Review agents" + multiSelect: true + options: + - label: "kieran-rails-reviewer" + description: "Rails conventions, naming, clarity (Rails projects)" + - label: "kieran-typescript-reviewer" + description: "TypeScript best practices, type safety" + - label: "kieran-python-reviewer" + description: "Python patterns, typing, best practices" + - label: "dhh-rails-reviewer" + description: "Opinionated Rails style from DHH's perspective" +``` + +### Question 2: Quality & Security Agents + +``` +AskUserQuestion: + questions: + - question: "Which quality and security agents should run?" + header: "Quality agents" + multiSelect: true + options: + - label: "code-simplicity-reviewer (Recommended)" + description: "Ensures code is as simple as possible" + - label: "security-sentinel (Recommended)" + description: "Security vulnerabilities and OWASP compliance" + - label: "performance-oracle" + description: "Performance issues and optimization" + - label: "architecture-strategist" + description: "Architectural patterns and design decisions" +``` + +### Question 3: Plan Review Agents + +``` +AskUserQuestion: + questions: + - question: "Which agents should review implementation plans?" + header: "Plan reviewers" + multiSelect: true + options: + - label: "Use same as code review (Recommended)" + description: "Reuse your code review agent selection" + - label: "code-simplicity-reviewer only" + description: "Lightweight plan reviews focused on simplicity" + - label: "Custom selection" + description: "Choose specific agents for plan reviews" +``` + +### Question 4: Conditional Agents + +``` +AskUserQuestion: + questions: + - question: "Enable conditional agents that run based on file changes?" + header: "Smart agents" + multiSelect: true + options: + - label: "Migration agents (Recommended)" + description: "data-migration-expert + deployment-verification for DB changes" + - label: "Frontend agents" + description: "julik-frontend-races-reviewer for JS/Stimulus code" + - label: "Architecture agents" + description: "pattern-recognition-specialist for structural changes" + - label: "None" + description: "Only run configured review agents" +``` + + + +## Step 3C: Minimal Setup Flow + + + +If user chose "Minimal Setup": + +```json +{ + "projectType": "{detected}", + "reviewAgents": [ + "code-simplicity-reviewer", + "security-sentinel" + ], + "planReviewAgents": [ + "code-simplicity-reviewer" + ], + "conditionalAgents": {} +} +``` + + + +## Step 4: Additional Options + + + +For all setup modes, ask: + +``` +AskUserQuestion: + questions: + - question: "Include agent-native-reviewer to verify features are accessible to AI agents?" + header: "Agent-native" + options: + - label: "Yes (Recommended)" + description: "Ensures new features can be used by Claude and other AI tools" + - label: "No" + description: "Skip agent accessibility checks" +``` + +If "Yes", add `"agent-native-reviewer"` to reviewAgents. + + + +## Step 5: Write Configuration + + + +Create the configuration file: + +```bash +# Ensure .claude directory exists +mkdir -p .claude + +# Write configuration (or to ~/.claude/ if --global) +``` + +Write the JSON configuration: + +```json +{ + "$schema": "https://raw.githubusercontent.com/EveryInc/compound-engineering-plugin/main/schemas/compound-engineering.schema.json", + "version": "1.0", + "projectType": "{detected_type}", + "reviewAgents": [ + // Selected agents + ], + "planReviewAgents": [ + // Selected agents + ], + "conditionalAgents": { + "migrations": ["data-migration-expert", "deployment-verification-agent"], + "frontend": ["julik-frontend-races-reviewer"], + "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + }, + "options": { + "agentNative": true, + "parallelReviews": true + } +} +``` + + + +## Step 6: Confirm and Summarize + + + +Present the configuration summary: + +```markdown +## Configuration Complete + +**Location:** `.claude/compound-engineering.json` +**Project Type:** {type} + +### Review Agents (run on every PR) +- {agent1} +- {agent2} +- ... + +### Plan Review Agents +- {agent1} +- ... + +### Conditional Agents +- **Migrations:** {agents or "disabled"} +- **Frontend:** {agents or "disabled"} +- **Architecture:** {agents or "disabled"} + +### Options +- Agent-native reviews: {enabled/disabled} +- Parallel reviews: {enabled/disabled} + +--- + +**Next steps:** +1. Run `/workflows:review` to test your configuration +2. Run `/compound-engineering-setup` again to modify settings +3. Commit `.claude/compound-engineering.json` to share with your team +``` + + + +## Configuration File Reference + + + +### Full Schema + +```json +{ + "$schema": "https://raw.githubusercontent.com/EveryInc/compound-engineering-plugin/main/schemas/compound-engineering.schema.json", + "version": "1.0", + "projectType": "rails|python|typescript|javascript|rust|go|swift|general", + + "reviewAgents": [ + "kieran-rails-reviewer", + "dhh-rails-reviewer", + "code-simplicity-reviewer", + "security-sentinel", + "performance-oracle" + ], + + "planReviewAgents": [ + "kieran-rails-reviewer", + "code-simplicity-reviewer" + ], + + "conditionalAgents": { + "migrations": ["data-migration-expert", "deployment-verification-agent"], + "frontend": ["julik-frontend-races-reviewer"], + "architecture": ["architecture-strategist", "pattern-recognition-specialist"], + "data": ["data-integrity-guardian"] + }, + + "options": { + "agentNative": true, + "parallelReviews": true, + "autoFix": false + } +} +``` + +### Available Agents + +**Code Review (language-specific):** +- `kieran-rails-reviewer` - Rails conventions and best practices +- `kieran-python-reviewer` - Python patterns and typing +- `kieran-typescript-reviewer` - TypeScript type safety +- `dhh-rails-reviewer` - Opinionated Rails style + +**Quality & Security:** +- `code-simplicity-reviewer` - Code simplicity and YAGNI +- `security-sentinel` - Security vulnerabilities +- `performance-oracle` - Performance optimization +- `architecture-strategist` - Architectural patterns +- `pattern-recognition-specialist` - Code patterns and anti-patterns + +**Specialized:** +- `data-migration-expert` - Database migration safety +- `deployment-verification-agent` - Deployment checklists +- `data-integrity-guardian` - Data model integrity +- `julik-frontend-races-reviewer` - JavaScript race conditions +- `agent-native-reviewer` - AI accessibility + + + +## Fallback Behavior + + + +If no configuration file exists when running `/workflows:review` or `/plan_review`: + +1. Check for `.claude/compound-engineering.json` +2. Check for `~/.claude/compound-engineering.json` +3. If neither exists, prompt: "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults?" +4. If user chooses defaults, use the General project defaults + + diff --git a/plugins/compound-engineering/commands/workflows/compound.md b/plugins/compound-engineering/commands/workflows/compound.md index 40426855..c5b4a2ab 100644 --- a/plugins/compound-engineering/commands/workflows/compound.md +++ b/plugins/compound-engineering/commands/workflows/compound.md @@ -62,12 +62,14 @@ This command launches multiple specialized subagents IN PARALLEL to maximize eff - Creates the file in correct location ### 7. **Optional: Specialized Agent Invocation** (Post-Documentation) - Based on problem type detected, automatically invoke applicable agents: - - **performance_issue** β†’ `performance-oracle` - - **security_issue** β†’ `security-sentinel` - - **database_issue** β†’ `data-integrity-guardian` - - **test_failure** β†’ `cora-test-reviewer` - - Any code-heavy issue β†’ `kieran-rails-reviewer` + `code-simplicity-reviewer` + Based on problem type detected, invoke agents from `.claude/compound-engineering.json` config: + - **performance_issue** β†’ `performance-oracle` (if configured) + - **security_issue** β†’ `security-sentinel` (if configured) + - **database_issue** β†’ `data-integrity-guardian` (if in `conditionalAgents.data`) + - **test_failure** β†’ test reviewer (if configured) + - Any code-heavy issue β†’ agents from `reviewAgents` + `code-simplicity-reviewer` + + **Note:** If no config exists, use project-appropriate defaults or prompt to run `/compound-engineering-setup`. ## What It Captures @@ -174,17 +176,18 @@ Build β†’ Test β†’ Find Issue β†’ Research β†’ Improve β†’ Document β†’ Validate ## Applicable Specialized Agents -Based on problem type, these agents can enhance documentation: +Based on problem type, agents from `.claude/compound-engineering.json` config enhance documentation. + +**Configure via:** `/compound-engineering-setup` -### Code Quality & Review -- **kieran-rails-reviewer**: Reviews code examples for Rails best practices +### Code Quality & Review (from `reviewAgents`) +- Language-specific reviewer (e.g., `kieran-rails-reviewer`, `kieran-python-reviewer`) - **code-simplicity-reviewer**: Ensures solution code is minimal and clear - **pattern-recognition-specialist**: Identifies anti-patterns or repeating issues -### Specific Domain Experts +### Specific Domain Experts (from `conditionalAgents`) - **performance-oracle**: Analyzes performance_issue category solutions - **security-sentinel**: Reviews security_issue solutions for vulnerabilities -- **cora-test-reviewer**: Creates test cases for prevention strategies - **data-integrity-guardian**: Reviews database_issue migrations and queries ### Enhancement & Documentation @@ -193,7 +196,7 @@ Based on problem type, these agents can enhance documentation: - **framework-docs-researcher**: Links to Rails/gem documentation references ### When to Invoke -- **Auto-triggered** (optional): Agents can run post-documentation for enhancement +- **Auto-triggered** (optional): Agents from config run post-documentation for enhancement - **Manual trigger**: User can invoke agents after /workflows:compound completes for deeper review ## Related Commands diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index 282c9f0a..6fdaa59c 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -48,25 +48,54 @@ Ensure that the code is ready for analysis (either in worktree or on current bra +#### Load Review Configuration + + + +Check for configuration file: + +```bash +# Check project config first, then global +if [ -f .claude/compound-engineering.json ]; then + CONFIG_FILE=".claude/compound-engineering.json" +elif [ -f ~/.claude/compound-engineering.json ]; then + CONFIG_FILE="~/.claude/compound-engineering.json" +else + CONFIG_FILE="" +fi +``` + +**If config exists:** Read agents from the configuration: +- `reviewAgents` - Primary agents to run on every PR +- `conditionalAgents` - Agents triggered by file patterns +- `options.agentNative` - Whether to include agent-native-reviewer + +**If no config exists:** Prompt user: +> "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults for this review?" + + + #### Parallel Agents to review the PR: -Run ALL or most of these agents at the same time: - -1. Task kieran-rails-reviewer(PR content) -2. Task dhh-rails-reviewer(PR title) -3. If turbo is used: Task rails-turbo-expert(PR content) -4. Task git-history-analyzer(PR content) -5. Task dependency-detective(PR content) -6. Task pattern-recognition-specialist(PR content) -7. Task architecture-strategist(PR content) -8. Task code-philosopher(PR content) -9. Task security-sentinel(PR content) -10. Task performance-oracle(PR content) -11. Task devops-harmony-analyst(PR content) -12. Task data-integrity-guardian(PR content) -13. Task agent-native-reviewer(PR content) - Verify new features are agent-accessible +**From `reviewAgents` in config** (or defaults if no config): + +Run all configured review agents in parallel. Example defaults: +- Task {first-configured-reviewer}(PR content) +- Task {second-configured-reviewer}(PR content) +- Task code-simplicity-reviewer(PR content) +- Task security-sentinel(PR content) +- Task performance-oracle(PR content) + +**Default reviewAgents (if no config):** +- Rails: `kieran-rails-reviewer`, `dhh-rails-reviewer`, `code-simplicity-reviewer`, `security-sentinel`, `performance-oracle` +- Python: `kieran-python-reviewer`, `code-simplicity-reviewer`, `security-sentinel`, `performance-oracle` +- TypeScript: `kieran-typescript-reviewer`, `code-simplicity-reviewer`, `security-sentinel`, `performance-oracle` +- General: `code-simplicity-reviewer`, `security-sentinel`, `performance-oracle` + +**If `options.agentNative` is true (default):** +- Task agent-native-reviewer(PR content) - Verify new features are agent-accessible @@ -367,12 +396,8 @@ After creating all todo files, present comprehensive summary: ### Review Agents Used: -- kieran-rails-reviewer -- security-sentinel -- performance-oracle -- architecture-strategist -- agent-native-reviewer -- [other agents] +- {List agents from config or defaults used} +- (configured via `.claude/compound-engineering.json`) ### Next Steps: diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index 36f95ae7..d92bda68 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -175,21 +175,25 @@ This command takes a work document (plan, specification, or todo file) and execu 2. **Consider Reviewer Agents** (Optional) - Use for complex, risky, or large changes: + Use for complex, risky, or large changes. Agents are configured via `.claude/compound-engineering.json`. - - **code-simplicity-reviewer**: Check for unnecessary complexity - - **kieran-rails-reviewer**: Verify Rails conventions (Rails projects) - - **performance-oracle**: Check for performance issues - - **security-sentinel**: Scan for security vulnerabilities - - **cora-test-reviewer**: Review test quality (Rails projects with comprehensive test coverage) + **If config exists:** Use agents from `reviewAgents` array. + + **If no config:** Use these defaults based on project type: + - **Rails**: `kieran-rails-reviewer`, `code-simplicity-reviewer` + - **Python**: `kieran-python-reviewer`, `code-simplicity-reviewer` + - **TypeScript**: `kieran-typescript-reviewer`, `code-simplicity-reviewer` + - **General**: `code-simplicity-reviewer`, `security-sentinel` Run reviewers in parallel with Task tool: ``` - Task(code-simplicity-reviewer): "Review changes for simplicity" - Task(kieran-rails-reviewer): "Check Rails conventions" + Task({configured-agent}): "Review changes" + Task(code-simplicity-reviewer): "Review for simplicity" ``` + **Tip:** Run `/compound-engineering-setup` to configure your preferred review agents. + Present findings to user and address critical issues. 3. **Final Validation** From 304c58d2174948d7a8535537965a12153c2bffe8 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:15:32 -0500 Subject: [PATCH 02/16] feat: auto-trigger setup when no config exists Workflows now detect missing config and offer inline quick setup: - "Quick Setup" - auto-detect project type, create config, continue - "Full Setup" - run /compound-engineering-setup for customization - "Skip" - use defaults just this once This ensures users get onboarded automatically when running any workflow for the first time, without needing to know about the setup command beforehand. Co-Authored-By: Claude Opus 4.5 --- .../commands/plan_review.md | 46 +++++++++++------ .../commands/workflows/review.md | 49 +++++++++++++------ .../commands/workflows/work.md | 17 +++++-- 3 files changed, 79 insertions(+), 33 deletions(-) diff --git a/plugins/compound-engineering/commands/plan_review.md b/plugins/compound-engineering/commands/plan_review.md index feeb0b04..4f739ca3 100644 --- a/plugins/compound-engineering/commands/plan_review.md +++ b/plugins/compound-engineering/commands/plan_review.md @@ -8,30 +8,46 @@ argument-hint: "[plan file path or plan content]" Review a plan using configured agents from `.claude/compound-engineering.json`. -## Load Configuration +## Load Configuration (Auto-Setup if Missing) -Check for configuration file: +**Step 1: Check for configuration file:** ```bash -# Check project config first, then global -if [ -f .claude/compound-engineering.json ]; then - CONFIG_FILE=".claude/compound-engineering.json" -elif [ -f ~/.claude/compound-engineering.json ]; then - CONFIG_FILE="~/.claude/compound-engineering.json" -else - CONFIG_FILE="" -fi +test -f .claude/compound-engineering.json && echo "project" || \ +test -f ~/.claude/compound-engineering.json && echo "global" || echo "none" ``` -**If config exists:** Read `planReviewAgents` array from the config file. +**Step 2: If config exists** β†’ Read `planReviewAgents` array and proceed. -**If no config exists:** Use these defaults: -- `code-simplicity-reviewer` -- `architecture-strategist` +**Step 3: If NO config exists** β†’ Run inline quick setup: -Or prompt: "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults?" +``` +AskUserQuestion: + questions: + - question: "No agent configuration found. How would you like to configure plan review agents?" + header: "Quick Setup" + options: + - label: "Quick Setup - Use smart defaults (Recommended)" + description: "Auto-detect project type and use appropriate agents." + - label: "Full Setup - Customize everything" + description: "Run /compound-engineering-setup for detailed configuration." + - label: "Skip - Use defaults just this once" + description: "Use general defaults for this review only." +``` + +**If "Quick Setup":** +1. Detect project type +2. Create `.claude/compound-engineering.json` with smart defaults +3. Continue with plan review using new config + +**If "Full Setup":** +1. Run `/compound-engineering-setup` +2. After setup, continue with plan review + +**If "Skip":** +1. Use defaults: `code-simplicity-reviewer`, `architecture-strategist` diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index 6fdaa59c..063f5424 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -48,30 +48,49 @@ Ensure that the code is ready for analysis (either in worktree or on current bra -#### Load Review Configuration +#### Load Review Configuration (Auto-Setup if Missing) -Check for configuration file: +**Step 1: Check for configuration file:** ```bash # Check project config first, then global -if [ -f .claude/compound-engineering.json ]; then - CONFIG_FILE=".claude/compound-engineering.json" -elif [ -f ~/.claude/compound-engineering.json ]; then - CONFIG_FILE="~/.claude/compound-engineering.json" -else - CONFIG_FILE="" -fi +test -f .claude/compound-engineering.json && echo "project" || \ +test -f ~/.claude/compound-engineering.json && echo "global" || echo "none" ``` -**If config exists:** Read agents from the configuration: -- `reviewAgents` - Primary agents to run on every PR -- `conditionalAgents` - Agents triggered by file patterns -- `options.agentNative` - Whether to include agent-native-reviewer +**Step 2: If config exists** β†’ Read agents from configuration and proceed. -**If no config exists:** Prompt user: -> "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults for this review?" +**Step 3: If NO config exists** β†’ Run inline quick setup: + +``` +AskUserQuestion: + questions: + - question: "No agent configuration found. How would you like to configure review agents?" + header: "Quick Setup" + options: + - label: "Quick Setup - Use smart defaults (Recommended)" + description: "Auto-detect project type and use appropriate agents. Takes 5 seconds." + - label: "Full Setup - Customize everything" + description: "Run /compound-engineering-setup for detailed configuration." + - label: "Skip - Use defaults just this once" + description: "Use general defaults for this review only, don't save config." +``` + +**If "Quick Setup":** +1. Detect project type (check for Gemfile+Rails, package.json+tsconfig, etc.) +2. Create `.claude/compound-engineering.json` with smart defaults for detected type +3. Inform user: "Created config for {project_type}. Run `/compound-engineering-setup` anytime to customize." +4. Continue with review using new config + +**If "Full Setup":** +1. Run `/compound-engineering-setup` (the full interactive flow) +2. After setup completes, continue with review + +**If "Skip":** +1. Use general defaults for this review only +2. Don't create config file diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index d92bda68..814aaf08 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -179,7 +179,20 @@ This command takes a work document (plan, specification, or todo file) and execu **If config exists:** Use agents from `reviewAgents` array. - **If no config:** Use these defaults based on project type: + **If no config exists and user wants reviewers:** + ``` + AskUserQuestion: + questions: + - question: "No config found. Set up review agents now?" + header: "Setup" + options: + - label: "Quick Setup (Recommended)" + description: "Create config with smart defaults for your project type" + - label: "Skip - Use defaults this time" + description: "Use general defaults without saving" + ``` + + **Default agents by project type:** - **Rails**: `kieran-rails-reviewer`, `code-simplicity-reviewer` - **Python**: `kieran-python-reviewer`, `code-simplicity-reviewer` - **TypeScript**: `kieran-typescript-reviewer`, `code-simplicity-reviewer` @@ -192,8 +205,6 @@ This command takes a work document (plan, specification, or todo file) and execu Task(code-simplicity-reviewer): "Review for simplicity" ``` - **Tip:** Run `/compound-engineering-setup` to configure your preferred review agents. - Present findings to user and address critical issues. 3. **Final Validation** From 898604c019cc03a12de310c59a83c1321b43bdac Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:28:52 -0500 Subject: [PATCH 03/16] feat(review): wire all conditionalAgents categories Extended /workflows:review to invoke conditional agents for: - migrations (existing) - frontend (new): JS/TS/Stimulus changes - architecture (new): structural changes, 10+ files - data (new): model/ActiveRecord changes Each category reads from conditionalAgents.* config key and runs appropriate specialized agents when file patterns match. Resolves: todos/001-ready-p2-conditional-agents-not-invoked.md Co-Authored-By: Claude Opus 4.5 --- .../commands/workflows/review.md | 68 ++++++++++++++++++- 1 file changed, 65 insertions(+), 3 deletions(-) diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index 063f5424..16feebc6 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -124,10 +124,14 @@ Run all configured review agents in parallel. Example defaults: These agents are run ONLY when the PR matches specific criteria. Check the PR files list to determine if they apply: -**If PR contains database migrations (db/migrate/*.rb files) or data backfills:** +--- + +**MIGRATIONS: If PR contains database migrations or data backfills:** -14. Task data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety -15. Task deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries +From `conditionalAgents.migrations` in config (defaults: `data-migration-expert`, `deployment-verification-agent`) + +- Task data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety +- Task deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries **When to run migration agents:** - PR includes files matching `db/migrate/*.rb` @@ -140,6 +144,64 @@ These agents are run ONLY when the PR matches specific criteria. Check the PR fi - `data-migration-expert`: Verifies hard-coded mappings match production reality (prevents swapped IDs), checks for orphaned associations, validates dual-write patterns - `deployment-verification-agent`: Produces executable pre/post-deploy checklists with SQL queries, rollback procedures, and monitoring plans +--- + +**FRONTEND: If PR contains JavaScript/TypeScript or frontend files:** + +From `conditionalAgents.frontend` in config (defaults: `julik-frontend-races-reviewer`) + +- Task julik-frontend-races-reviewer(PR content) - Reviews for race conditions, async issues, and frontend performance problems + +**When to run frontend agents:** +- PR includes files matching `*.js`, `*.ts`, `*.jsx`, `*.tsx` +- PR includes files in `app/javascript/**`, `app/assets/javascripts/**` +- PR includes files in `frontend/**`, `src/**` (for JS-heavy projects) +- PR modifies Stimulus controllers, Turbo frames, or Hotwire components +- PR includes CSS/SCSS changes with JavaScript interactions + +**What these agents check:** +- `julik-frontend-races-reviewer`: Detects async race conditions, improper event handling, memory leaks, Turbo/Stimulus lifecycle issues, and JavaScript performance anti-patterns + +--- + +**ARCHITECTURE: If PR contains significant structural changes:** + +From `conditionalAgents.architecture` in config (defaults: `architecture-strategist`, `pattern-recognition-specialist`) + +- Task architecture-strategist(PR content) - Evaluates architectural decisions, coupling, and system design +- Task pattern-recognition-specialist(PR content) - Identifies anti-patterns, code smells, and architectural drift + +**When to run architecture agents:** +- PR creates new directories or major new components +- PR changes 10+ files across multiple directories +- PR introduces new gems, packages, or dependencies +- PR modifies core infrastructure (config, initializers, middleware) +- PR refactors or moves significant code between modules +- PR title/body mentions: refactor, restructure, architecture, reorganize + +**What these agents check:** +- `architecture-strategist`: Evaluates separation of concerns, dependency direction, module boundaries, and long-term maintainability +- `pattern-recognition-specialist`: Identifies recurring anti-patterns, code duplication across the PR, and violations of established project patterns + +--- + +**DATA: If PR contains model or data-related changes:** + +From `conditionalAgents.data` in config (defaults: `data-integrity-guardian`) + +- Task data-integrity-guardian(PR content) - Reviews data integrity, validation, and query safety + +**When to run data agents:** +- PR includes files matching `app/models/*.rb`, `app/models/**/*.rb` +- PR includes concerns in `app/models/concerns/**` +- PR modifies ActiveRecord associations, validations, or callbacks +- PR includes changes to database queries or scopes +- PR modifies serializers, decorators, or data transformation logic +- PR title/body mentions: model, validation, association, query optimization + +**What these agents check:** +- `data-integrity-guardian`: Validates referential integrity, N+1 query risks, proper use of transactions, data consistency across associations, and safe handling of nullable fields + ### 4. Ultra-Thinking Deep Dive Phases From 246823a1b400917b1f4b98a12f63b04644e35f9b Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:29:08 -0500 Subject: [PATCH 04/16] chore: mark todo #001 as complete --- ...plete-p2-conditional-agents-not-invoked.md | 91 +++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 todos/001-complete-p2-conditional-agents-not-invoked.md diff --git a/todos/001-complete-p2-conditional-agents-not-invoked.md b/todos/001-complete-p2-conditional-agents-not-invoked.md new file mode 100644 index 00000000..a308ea4f --- /dev/null +++ b/todos/001-complete-p2-conditional-agents-not-invoked.md @@ -0,0 +1,91 @@ +--- +status: complete +priority: p2 +issue_id: "001" +tags: [code-review, architecture, quality, docs] +dependencies: [] +--- + +# Wire conditionalAgents into /workflows:review + +## Problem Statement + +The new setup command defines `conditionalAgents` (frontend, architecture, data), but `/workflows:review` only references migrations and ignores other conditional categories. This creates a configuration contract that is not actually executed during reviews. + +## Findings + +- `plugins/compound-engineering/commands/setup.md` introduces `conditionalAgents` keys beyond migrations. +- `plugins/compound-engineering/commands/workflows/review.md` contains no logic that reads or runs non-migration conditional agents. +- Result: users can configure conditional agents that never run. + +## Proposed Solutions + +### Option 1: Add explicit conditional agent rules to review workflow + +**Approach:** Extend `/workflows:review` with conditional checks for frontend, architecture, and data changes, then invoke configured agents. + +**Pros:** +- Aligns behavior with the new configuration surface. +- Preserves the documented β€œsmart agents” promise. + +**Cons:** +- Adds more workflow logic to maintain. + +**Effort:** Medium + +**Risk:** Low + +--- + +### Option 2: Restrict config to migrations only + +**Approach:** Remove non-migration categories from setup defaults and docs until the workflow supports them. + +**Pros:** +- Minimal change. +- Prevents misleading configuration. + +**Cons:** +- Reduces flexibility and value of the new setup command. + +**Effort:** Small + +**Risk:** Low + +--- + +### Option 3: Document non-migration conditionals as future/optional + +**Approach:** Keep config shape but explicitly mark non-migration categories as not yet wired. + +**Pros:** +- Sets correct expectations quickly. + +**Cons:** +- Still leaves dead config keys. + +**Effort:** Small + +**Risk:** Medium + +## Recommended Action + +## Technical Details + +Affected files: +- `plugins/compound-engineering/commands/setup.md` +- `plugins/compound-engineering/commands/workflows/review.md` + +## Resources + +- PR: https://github.com/EveryInc/compound-engineering-plugin/pull/124 + +## Acceptance Criteria + +- [ ] `/workflows:review` invokes configured conditional agents beyond migrations, or docs/config are narrowed to match reality. +- [ ] Behavior is documented with clear, testable trigger rules. + +## Work Log + +- 2026-01-26: Identified config/workflow mismatch during PR #124 review. +- 2026-01-25: **Approved for work** during triage session. Status: pending β†’ ready. From b7db6e71c55988e30bf1f59d35522dbe96623c38 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:33:36 -0500 Subject: [PATCH 05/16] feat(setup): add custom agent discovery and modify flow - Auto-detect custom agents in .claude/agents/ and ~/.claude/agents/ - Add modify existing config flow (add/remove agents, view config) - Include guide for creating custom review agents - Add customAgents mapping in config to track agent file paths - Update changelog with new config schema including customAgents Co-Authored-By: Claude Opus 4.5 --- plugins/compound-engineering/CHANGELOG.md | 13 +- .../compound-engineering/commands/setup.md | 558 +++++++++--------- 2 files changed, 305 insertions(+), 266 deletions(-) diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index c8d162c0..06dd4a64 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -15,6 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Three setup modes: Quick (smart defaults), Advanced (manual selection), Minimal - Creates `.claude/compound-engineering.json` config file - Supports global config (`~/.claude/`) or project-specific (`.claude/`) + - **Custom agent discovery**: Auto-detects agents in `.claude/agents/` and `~/.claude/agents/` + - **Modify flow**: Re-run setup to add/remove agents from existing config + - **Custom agent guide**: Instructions for creating your own review agents ### Changed @@ -28,12 +31,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 New config file format (`.claude/compound-engineering.json`): ```json { + "version": "1.0", "projectType": "rails", - "reviewAgents": ["kieran-rails-reviewer", "code-simplicity-reviewer", "security-sentinel"], + "reviewAgents": ["kieran-rails-reviewer", "code-simplicity-reviewer", "my-custom-reviewer"], "planReviewAgents": ["kieran-rails-reviewer", "code-simplicity-reviewer"], + "customAgents": { + "my-custom-reviewer": ".claude/agents/my-custom-reviewer.md" + }, "conditionalAgents": { "migrations": ["data-migration-expert", "deployment-verification-agent"], - "frontend": ["julik-frontend-races-reviewer"] + "frontend": ["julik-frontend-races-reviewer"], + "architecture": ["architecture-strategist"], + "data": ["data-integrity-guardian"] } } ``` diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/commands/setup.md index f417cade..b94e8396 100644 --- a/plugins/compound-engineering/commands/setup.md +++ b/plugins/compound-engineering/commands/setup.md @@ -8,37 +8,93 @@ argument-hint: "[--global to configure globally]" Configure which review agents and workflows to use for this project. Creates a `.claude/compound-engineering.json` configuration file. -## Detect Configuration Location +## Step 0: Detect Existing Config & Custom Agents - + -Check if user passed `--global` argument: -- **If `--global`**: Configure at `~/.claude/compound-engineering.json` (applies to all projects) -- **Otherwise**: Configure at `.claude/compound-engineering.json` (project-specific) +### Check for existing configuration: -Check if configuration already exists: ```bash # Check project config -test -f .claude/compound-engineering.json && echo "Project config exists" +test -f .claude/compound-engineering.json && echo "PROJECT_CONFIG_EXISTS" # Check global config -test -f ~/.claude/compound-engineering.json && echo "Global config exists" +test -f ~/.claude/compound-engineering.json && echo "GLOBAL_CONFIG_EXISTS" ``` -If config exists, offer to edit existing or start fresh. +### Scan for custom local agents: - +```bash +# Project-level custom agents +ls .claude/agents/*.md 2>/dev/null | head -20 + +# Global custom agents +ls ~/.claude/agents/*.md 2>/dev/null | head -20 + +# Project-level custom skills (that might be reviewers) +ls .claude/skills/*/SKILL.md 2>/dev/null | head -20 +``` -## Step 1: Detect Project Type +**For each discovered agent/skill file:** +1. Read the file's YAML frontmatter or first few lines +2. Extract `name` and `description` +3. Check if name contains "review" or description mentions "code review" +4. Store as `customAgents[]` array for later + +**Example discovered agents:** +``` +Found 3 custom agents: +- my-team-reviewer (.claude/agents/my-team-reviewer.md) - "Team-specific Rails conventions" +- api-reviewer (.claude/agents/api-reviewer.md) - "REST API design review" +- test-coverage-checker (~/.claude/agents/test-coverage-checker.md) - "Verify test coverage" +``` - + -Detect the primary language/framework automatically: +## Step 1: Determine Setup Mode (New vs Modify) + + + +**If config already exists:** + +``` +AskUserQuestion: + questions: + - question: "Configuration found. What would you like to do?" + header: "Setup" + options: + - label: "Modify existing config" + description: "Add/remove agents from your current configuration" + - label: "Start fresh" + description: "Delete current config and set up from scratch" + - label: "View current config" + description: "Show what's currently configured" +``` + +**If "View current config":** +1. Read and display the current `.claude/compound-engineering.json` +2. Show which agents are configured for each category +3. Ask again what they want to do + +**If "Modify existing config":** β†’ Go to Step 2B (Modify Flow) + +**If "Start fresh":** β†’ Go to Step 2A (New Setup Flow) + +**If no config exists:** β†’ Go to Step 2A (New Setup Flow) + + + +## Step 2A: New Setup Flow + + + +### Detect Project Type ```bash # Check for common project indicators -ls -la Gemfile package.json requirements.txt pyproject.toml Cargo.toml go.mod pom.xml 2>/dev/null -ls -la *.xcodeproj *.xcworkspace Package.swift 2>/dev/null +ls Gemfile package.json requirements.txt pyproject.toml Cargo.toml go.mod 2>/dev/null +test -f config/routes.rb && echo "RAILS" +test -f tsconfig.json && echo "TYPESCRIPT" ``` **Detection Rules:** @@ -49,285 +105,252 @@ ls -la *.xcodeproj *.xcworkspace Package.swift 2>/dev/null - `requirements.txt` OR `pyproject.toml` β†’ **Python** - `Cargo.toml` β†’ **Rust** - `go.mod` β†’ **Go** -- `*.xcodeproj` OR `Package.swift` β†’ **Swift/iOS** -- None of the above β†’ **General** - -Store detected type for recommendations. - - +- None β†’ **General** -## Step 2: Quick vs Advanced Setup - - - -Use AskUserQuestion to determine setup mode: +### Choose Setup Mode ``` AskUserQuestion: questions: - - question: "How would you like to configure compound-engineering?" + - question: "How would you like to configure review agents?" header: "Setup mode" options: - label: "Quick Setup (Recommended)" - description: "Use smart defaults based on your project type. Best for most users." + description: "Smart defaults for {detected_type} + any custom agents found" - label: "Advanced Setup" - description: "Manually select each agent and configure options. For power users." + description: "Manually select each agent including custom ones" - label: "Minimal Setup" - description: "Only essential agents (security + code quality). Fastest reviews." + description: "Only essential agents (security + simplicity)" ``` - +### Quick Setup - Apply Defaults + Custom Agents -## Step 3A: Quick Setup Flow +**For detected project type, use these defaults:** - +| Project Type | Review Agents | Plan Review Agents | +|--------------|---------------|-------------------| +| Rails | kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-rails-reviewer, code-simplicity-reviewer | +| Python | kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-python-reviewer, code-simplicity-reviewer | +| TypeScript | kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-typescript-reviewer, code-simplicity-reviewer | +| General | code-simplicity-reviewer, security-sentinel, performance-oracle | code-simplicity-reviewer | -If user chose "Quick Setup": +**If custom agents were discovered:** -### Rails Projects -Default config: -```json -{ - "projectType": "rails", - "reviewAgents": [ - "kieran-rails-reviewer", - "dhh-rails-reviewer", - "code-simplicity-reviewer", - "security-sentinel", - "performance-oracle" - ], - "planReviewAgents": [ - "kieran-rails-reviewer", - "code-simplicity-reviewer" - ], - "conditionalAgents": { - "migrations": ["data-migration-expert", "deployment-verification-agent"], - "frontend": ["julik-frontend-races-reviewer"], - "architecture": ["architecture-strategist", "pattern-recognition-specialist"] - } -} ``` - -### Python Projects -Default config: -```json -{ - "projectType": "python", - "reviewAgents": [ - "kieran-python-reviewer", - "code-simplicity-reviewer", - "security-sentinel", - "performance-oracle" - ], - "planReviewAgents": [ - "kieran-python-reviewer", - "code-simplicity-reviewer" - ], - "conditionalAgents": { - "architecture": ["architecture-strategist", "pattern-recognition-specialist"] - } -} -``` - -### TypeScript Projects -Default config: -```json -{ - "projectType": "typescript", - "reviewAgents": [ - "kieran-typescript-reviewer", - "code-simplicity-reviewer", - "security-sentinel", - "performance-oracle" - ], - "planReviewAgents": [ - "kieran-typescript-reviewer", - "code-simplicity-reviewer" - ], - "conditionalAgents": { - "frontend": ["julik-frontend-races-reviewer"], - "architecture": ["architecture-strategist", "pattern-recognition-specialist"] - } -} -``` - -### General/Other Projects -Default config: -```json -{ - "projectType": "general", - "reviewAgents": [ - "code-simplicity-reviewer", - "security-sentinel", - "performance-oracle" - ], - "planReviewAgents": [ - "code-simplicity-reviewer" - ], - "conditionalAgents": { - "architecture": ["architecture-strategist", "pattern-recognition-specialist"] - } -} +AskUserQuestion: + questions: + - question: "Found {N} custom agents. Add them to your review configuration?" + header: "Custom agents" + multiSelect: true + options: + - label: "{custom_agent_1_name}" + description: "{custom_agent_1_description}" + - label: "{custom_agent_2_name}" + description: "{custom_agent_2_description}" + - label: "Skip - don't add custom agents" + description: "Only use built-in agents" ``` - - -## Step 3B: Advanced Setup Flow - - +Add selected custom agents to `reviewAgents` array. -If user chose "Advanced Setup", walk through each category: +### Advanced Setup - Manual Selection -### Question 1: Primary Code Review Agents +**Question 1: Built-in Review Agents** ``` AskUserQuestion: questions: - - question: "Which code review agents should run on every PR?" - header: "Review agents" + - question: "Which built-in review agents should run on every PR?" + header: "Built-in agents" multiSelect: true options: - label: "kieran-rails-reviewer" - description: "Rails conventions, naming, clarity (Rails projects)" + description: "Rails conventions, naming, clarity" - label: "kieran-typescript-reviewer" description: "TypeScript best practices, type safety" - label: "kieran-python-reviewer" description: "Python patterns, typing, best practices" - label: "dhh-rails-reviewer" - description: "Opinionated Rails style from DHH's perspective" + description: "Opinionated Rails style" ``` -### Question 2: Quality & Security Agents +**Question 2: Custom Agents (if any discovered)** ``` AskUserQuestion: questions: - - question: "Which quality and security agents should run?" - header: "Quality agents" + - question: "Which of your custom agents should run on every PR?" + header: "Your agents" multiSelect: true options: - - label: "code-simplicity-reviewer (Recommended)" - description: "Ensures code is as simple as possible" - - label: "security-sentinel (Recommended)" - description: "Security vulnerabilities and OWASP compliance" - - label: "performance-oracle" - description: "Performance issues and optimization" - - label: "architecture-strategist" - description: "Architectural patterns and design decisions" + - label: "{custom_agent_1_name}" + description: "{custom_agent_1_description} ({path})" + - label: "{custom_agent_2_name}" + description: "{custom_agent_2_description} ({path})" ``` -### Question 3: Plan Review Agents +**Question 3: Quality & Security** ``` AskUserQuestion: questions: - - question: "Which agents should review implementation plans?" - header: "Plan reviewers" + - question: "Which quality and security agents should run?" + header: "Quality" multiSelect: true options: - - label: "Use same as code review (Recommended)" - description: "Reuse your code review agent selection" - - label: "code-simplicity-reviewer only" - description: "Lightweight plan reviews focused on simplicity" - - label: "Custom selection" - description: "Choose specific agents for plan reviews" + - label: "code-simplicity-reviewer (Recommended)" + description: "Ensures code is as simple as possible" + - label: "security-sentinel (Recommended)" + description: "Security vulnerabilities and OWASP compliance" + - label: "performance-oracle" + description: "Performance issues and optimization" + - label: "agent-native-reviewer" + description: "Verify features are AI-accessible" ``` -### Question 4: Conditional Agents +**Question 4: Conditional Agents** ``` AskUserQuestion: questions: - - question: "Enable conditional agents that run based on file changes?" - header: "Smart agents" + - question: "Enable smart agents that run based on what files changed?" + header: "Conditional" multiSelect: true options: - label: "Migration agents (Recommended)" - description: "data-migration-expert + deployment-verification for DB changes" + description: "data-migration-expert for DB changes" - label: "Frontend agents" - description: "julik-frontend-races-reviewer for JS/Stimulus code" + description: "julik-frontend-races-reviewer for JS/TS" - label: "Architecture agents" - description: "pattern-recognition-specialist for structural changes" - - label: "None" - description: "Only run configured review agents" + description: "architecture-strategist for structural changes" + - label: "Data agents" + description: "data-integrity-guardian for model changes" ``` - + -## Step 3C: Minimal Setup Flow +## Step 2B: Modify Existing Config - + -If user chose "Minimal Setup": +Read current configuration and present current state: -```json -{ - "projectType": "{detected}", - "reviewAgents": [ - "code-simplicity-reviewer", - "security-sentinel" - ], - "planReviewAgents": [ - "code-simplicity-reviewer" - ], - "conditionalAgents": {} -} +```markdown +## Current Configuration + +**Project Type:** {type} + +**Review Agents ({count}):** +- βœ“ kieran-rails-reviewer +- βœ“ code-simplicity-reviewer +- βœ“ security-sentinel +- βœ“ my-custom-reviewer (custom) + +**Plan Review Agents ({count}):** +- βœ“ kieran-rails-reviewer +- βœ“ code-simplicity-reviewer + +**Conditional Agents:** +- Migrations: data-migration-expert, deployment-verification-agent +- Frontend: julik-frontend-races-reviewer +- Architecture: (none) +- Data: (none) ``` - +``` +AskUserQuestion: + questions: + - question: "What would you like to modify?" + header: "Modify" + options: + - label: "Add agents" + description: "Add more agents to your configuration" + - label: "Remove agents" + description: "Remove agents you don't want" + - label: "Change conditional agents" + description: "Modify which agents run for specific file types" + - label: "Done" + description: "Save and exit" +``` + +### Add Agents Flow + +Show agents NOT currently in config: -## Step 4: Additional Options +``` +AskUserQuestion: + questions: + - question: "Select agents to ADD to your configuration:" + header: "Add agents" + multiSelect: true + options: + - label: "dhh-rails-reviewer" + description: "Opinionated Rails style (not currently enabled)" + - label: "performance-oracle" + description: "Performance issues (not currently enabled)" + - label: "{new_custom_agent}" + description: "Your custom agent (discovered in .claude/agents/)" +``` - +### Remove Agents Flow -For all setup modes, ask: +Show agents currently IN config: ``` AskUserQuestion: questions: - - question: "Include agent-native-reviewer to verify features are accessible to AI agents?" - header: "Agent-native" + - question: "Select agents to REMOVE from your configuration:" + header: "Remove agents" + multiSelect: true options: - - label: "Yes (Recommended)" - description: "Ensures new features can be used by Claude and other AI tools" - - label: "No" - description: "Skip agent accessibility checks" + - label: "kieran-rails-reviewer" + description: "Currently enabled - will be removed" + - label: "security-sentinel" + description: "Currently enabled - will be removed" ``` -If "Yes", add `"agent-native-reviewer"` to reviewAgents. +After each modification, loop back to "What would you like to modify?" until user selects "Done". - + -## Step 5: Write Configuration +## Step 3: Write Configuration -Create the configuration file: +**Determine target path:** +- If `--global`: `~/.claude/compound-engineering.json` +- Otherwise: `.claude/compound-engineering.json` +**Create directory if needed:** ```bash -# Ensure .claude directory exists -mkdir -p .claude - -# Write configuration (or to ~/.claude/ if --global) +mkdir -p .claude # or ~/.claude for global ``` -Write the JSON configuration: +**Write JSON configuration:** ```json { - "$schema": "https://raw.githubusercontent.com/EveryInc/compound-engineering-plugin/main/schemas/compound-engineering.schema.json", "version": "1.0", "projectType": "{detected_type}", "reviewAgents": [ - // Selected agents + "kieran-rails-reviewer", + "code-simplicity-reviewer", + "security-sentinel", + "my-custom-reviewer" ], "planReviewAgents": [ - // Selected agents + "kieran-rails-reviewer", + "code-simplicity-reviewer" ], + "customAgents": { + "my-custom-reviewer": ".claude/agents/my-custom-reviewer.md", + "api-reviewer": "~/.claude/agents/api-reviewer.md" + }, "conditionalAgents": { "migrations": ["data-migration-expert", "deployment-verification-agent"], "frontend": ["julik-frontend-races-reviewer"], - "architecture": ["architecture-strategist", "pattern-recognition-specialist"] + "architecture": ["architecture-strategist", "pattern-recognition-specialist"], + "data": ["data-integrity-guardian"] }, "options": { "agentNative": true, @@ -336,89 +359,109 @@ Write the JSON configuration: } ``` +**Note:** The `customAgents` object maps custom agent names to their file paths, so workflows know where to find them. + -## Step 6: Confirm and Summarize +## Step 4: Summary -Present the configuration summary: - ```markdown -## Configuration Complete +## Configuration Complete! -**Location:** `.claude/compound-engineering.json` -**Project Type:** {type} +**Saved to:** `.claude/compound-engineering.json` +**Project Type:** Rails ### Review Agents (run on every PR) -- {agent1} -- {agent2} -- ... +**Built-in:** +- kieran-rails-reviewer +- code-simplicity-reviewer +- security-sentinel -### Plan Review Agents -- {agent1} -- ... +**Custom:** +- my-custom-reviewer (.claude/agents/) -### Conditional Agents -- **Migrations:** {agents or "disabled"} -- **Frontend:** {agents or "disabled"} -- **Architecture:** {agents or "disabled"} +### Plan Review Agents +- kieran-rails-reviewer +- code-simplicity-reviewer -### Options -- Agent-native reviews: {enabled/disabled} -- Parallel reviews: {enabled/disabled} +### Conditional Agents (run when relevant files change) +| Trigger | Agents | +|---------|--------| +| DB Migrations | data-migration-expert, deployment-verification-agent | +| Frontend (JS/TS) | julik-frontend-races-reviewer | +| Architecture | architecture-strategist | +| Data/Models | data-integrity-guardian | --- -**Next steps:** +**What's next:** 1. Run `/workflows:review` to test your configuration -2. Run `/compound-engineering-setup` again to modify settings +2. Run `/compound-engineering-setup` to modify settings anytime 3. Commit `.claude/compound-engineering.json` to share with your team + +**Add more custom agents:** +Create `.claude/agents/my-agent.md` with your custom review logic, +then re-run `/compound-engineering-setup` to add it to your config. ``` -## Configuration File Reference +## Creating Custom Agents - + -### Full Schema +To create your own review agent that gets auto-discovered: -```json -{ - "$schema": "https://raw.githubusercontent.com/EveryInc/compound-engineering-plugin/main/schemas/compound-engineering.schema.json", - "version": "1.0", - "projectType": "rails|python|typescript|javascript|rust|go|swift|general", +### 1. Create the agent file - "reviewAgents": [ - "kieran-rails-reviewer", - "dhh-rails-reviewer", - "code-simplicity-reviewer", - "security-sentinel", - "performance-oracle" - ], +**Project-level:** `.claude/agents/my-reviewer.md` +**Global:** `~/.claude/agents/my-reviewer.md` - "planReviewAgents": [ - "kieran-rails-reviewer", - "code-simplicity-reviewer" - ], +### 2. Use this template: - "conditionalAgents": { - "migrations": ["data-migration-expert", "deployment-verification-agent"], - "frontend": ["julik-frontend-races-reviewer"], - "architecture": ["architecture-strategist", "pattern-recognition-specialist"], - "data": ["data-integrity-guardian"] - }, +```markdown +--- +name: my-team-reviewer +description: Reviews code for our team's specific conventions +--- - "options": { - "agentNative": true, - "parallelReviews": true, - "autoFix": false - } -} +# My Team Reviewer + +You are a code reviewer specializing in our team's conventions. + +## Review Checklist + +- [ ] Check naming conventions match our style guide +- [ ] Verify error handling follows our patterns +- [ ] Ensure logging is consistent +- [ ] Check for proper documentation + +## When reviewing, focus on: + +1. **Naming**: We use snake_case for methods, PascalCase for classes +2. **Errors**: All errors should be logged with context +3. **Tests**: Every public method needs a test + +## Output format + +Provide findings as a bulleted list with file:line references. ``` -### Available Agents +### 3. Re-run setup + +```bash +/compound-engineering-setup +``` + +Your agent will be discovered and offered as an option! + + + +## Available Built-in Agents + + **Code Review (language-specific):** - `kieran-rails-reviewer` - Rails conventions and best practices @@ -432,25 +475,12 @@ Present the configuration summary: - `performance-oracle` - Performance optimization - `architecture-strategist` - Architectural patterns - `pattern-recognition-specialist` - Code patterns and anti-patterns +- `agent-native-reviewer` - AI accessibility verification -**Specialized:** +**Specialized (conditional):** - `data-migration-expert` - Database migration safety - `deployment-verification-agent` - Deployment checklists - `data-integrity-guardian` - Data model integrity - `julik-frontend-races-reviewer` - JavaScript race conditions -- `agent-native-reviewer` - AI accessibility - - - -## Fallback Behavior - - - -If no configuration file exists when running `/workflows:review` or `/plan_review`: - -1. Check for `.claude/compound-engineering.json` -2. Check for `~/.claude/compound-engineering.json` -3. If neither exists, prompt: "No configuration found. Run `/compound-engineering-setup` to configure agents, or use defaults?" -4. If user chooses defaults, use the General project defaults - + From a1413c912706d774621d07151f0c02dcdacfb340 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 25 Jan 2026 23:42:55 -0500 Subject: [PATCH 06/16] chore: remove completed todos directory Co-Authored-By: Claude Opus 4.5 --- ...plete-p2-conditional-agents-not-invoked.md | 91 ------------------- 1 file changed, 91 deletions(-) delete mode 100644 todos/001-complete-p2-conditional-agents-not-invoked.md diff --git a/todos/001-complete-p2-conditional-agents-not-invoked.md b/todos/001-complete-p2-conditional-agents-not-invoked.md deleted file mode 100644 index a308ea4f..00000000 --- a/todos/001-complete-p2-conditional-agents-not-invoked.md +++ /dev/null @@ -1,91 +0,0 @@ ---- -status: complete -priority: p2 -issue_id: "001" -tags: [code-review, architecture, quality, docs] -dependencies: [] ---- - -# Wire conditionalAgents into /workflows:review - -## Problem Statement - -The new setup command defines `conditionalAgents` (frontend, architecture, data), but `/workflows:review` only references migrations and ignores other conditional categories. This creates a configuration contract that is not actually executed during reviews. - -## Findings - -- `plugins/compound-engineering/commands/setup.md` introduces `conditionalAgents` keys beyond migrations. -- `plugins/compound-engineering/commands/workflows/review.md` contains no logic that reads or runs non-migration conditional agents. -- Result: users can configure conditional agents that never run. - -## Proposed Solutions - -### Option 1: Add explicit conditional agent rules to review workflow - -**Approach:** Extend `/workflows:review` with conditional checks for frontend, architecture, and data changes, then invoke configured agents. - -**Pros:** -- Aligns behavior with the new configuration surface. -- Preserves the documented β€œsmart agents” promise. - -**Cons:** -- Adds more workflow logic to maintain. - -**Effort:** Medium - -**Risk:** Low - ---- - -### Option 2: Restrict config to migrations only - -**Approach:** Remove non-migration categories from setup defaults and docs until the workflow supports them. - -**Pros:** -- Minimal change. -- Prevents misleading configuration. - -**Cons:** -- Reduces flexibility and value of the new setup command. - -**Effort:** Small - -**Risk:** Low - ---- - -### Option 3: Document non-migration conditionals as future/optional - -**Approach:** Keep config shape but explicitly mark non-migration categories as not yet wired. - -**Pros:** -- Sets correct expectations quickly. - -**Cons:** -- Still leaves dead config keys. - -**Effort:** Small - -**Risk:** Medium - -## Recommended Action - -## Technical Details - -Affected files: -- `plugins/compound-engineering/commands/setup.md` -- `plugins/compound-engineering/commands/workflows/review.md` - -## Resources - -- PR: https://github.com/EveryInc/compound-engineering-plugin/pull/124 - -## Acceptance Criteria - -- [ ] `/workflows:review` invokes configured conditional agents beyond migrations, or docs/config are narrowed to match reality. -- [ ] Behavior is documented with clear, testable trigger rules. - -## Work Log - -- 2026-01-26: Identified config/workflow mismatch during PR #124 review. -- 2026-01-25: **Approved for work** during triage session. Status: pending β†’ ready. From 045c2795a1b079718c9130a591314f71b560c4e5 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Wed, 28 Jan 2026 06:04:00 -0800 Subject: [PATCH 07/16] [2.29.1] Improve /workflows:brainstorm question flow - Add "Ask more questions" option at handoff phase - Clarify that Claude should ask the user questions (not wait for user) - Require resolving ALL open questions before offering to proceed Co-Authored-By: Claude Opus 4.5 --- .../compound-engineering/.claude-plugin/plugin.json | 2 +- plugins/compound-engineering/CHANGELOG.md | 11 +++++++++++ .../commands/workflows/brainstorm.md | 9 +++++++-- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index a9f29f92..20f67369 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "compound-engineering", - "version": "2.29.0", + "version": "2.29.1", "description": "AI-powered development tools. 28 agents, 25 commands, 15 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index 06dd4a64..0d7cdcc5 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,6 +5,17 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.29.1] - 2026-01-28 + +### Improved + +- **`/workflows:brainstorm` command** - Better question flow + - Added "Ask more questions" option at handoff phase + - Clarified that Claude should ask the user questions (not wait for user to ask) + - Added requirement to resolve ALL open questions before offering to proceed to planning + +--- + ## [2.29.0] - 2026-01-25 ### Added diff --git a/plugins/compound-engineering/commands/workflows/brainstorm.md b/plugins/compound-engineering/commands/workflows/brainstorm.md index 3cb204d7..578eba62 100644 --- a/plugins/compound-engineering/commands/workflows/brainstorm.md +++ b/plugins/compound-engineering/commands/workflows/brainstorm.md @@ -78,6 +78,8 @@ Write a brainstorm document to `docs/brainstorms/YYYY-MM-DD--brainstorm.m Ensure `docs/brainstorms/` directory exists before writing. +**IMPORTANT:** Before proceeding to Phase 4, check if there are any Open Questions listed in the brainstorm document. If there are open questions, YOU MUST ask the user about each one using AskUserQuestion before offering to proceed to planning. Move resolved questions to a "Resolved Questions" section. + ### Phase 4: Handoff Use **AskUserQuestion tool** to present next steps: @@ -86,8 +88,11 @@ Use **AskUserQuestion tool** to present next steps: **Options:** 1. **Proceed to planning** - Run `/workflows:plan` (will auto-detect this brainstorm) -2. **Refine design further** - Continue exploring -3. **Done for now** - Return later +2. **Ask more questions** - I have more questions to clarify before moving on +3. **Refine design further** - Continue exploring the design +4. **Done for now** - Return later + +**If user selects "Ask more questions":** YOU (Claude) return to Phase 1.2 (Collaborative Dialogue) and continue asking the USER questions one at a time to further refine the design. The user wants YOU to probe deeper - ask about edge cases, constraints, preferences, or areas not yet explored. Continue until the user is satisfied, then return to Phase 4. ## Output Summary From bc29af13bdf17d2ac9db3313aec35720c5792c37 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 8 Feb 2026 21:43:39 -0800 Subject: [PATCH 08/16] Simplify plugin settings: replace 486-line wizard with .local.md pattern MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Rewrite setup.md (486 β†’ 95 lines): detect project type, create .claude/compound-engineering.local.md with smart defaults - Make review.md and work.md config-aware: read agents from .local.md frontmatter, fall back to auto-detected defaults - Wire schema-drift-detector into review.md migrations conditional block - Delete technical_review.md (duplicated /plan_review) - Add disable-model-invocation to setup.md - Bump to v2.32.0 Co-Authored-By: Claude Opus 4.6 --- .claude-plugin/marketplace.json | 2 +- ...2-08-feat-simplify-plugin-settings-plan.md | 195 +++++++ .../.claude-plugin/plugin.json | 2 +- plugins/compound-engineering/CHANGELOG.md | 22 + plugins/compound-engineering/README.md | 2 +- .../compound-engineering/commands/setup.md | 501 ++---------------- .../commands/technical_review.md | 8 - .../commands/workflows/compound.md | 1 + .../commands/workflows/review.md | 49 +- .../commands/workflows/work.md | 20 +- 10 files changed, 311 insertions(+), 491 deletions(-) create mode 100644 docs/plans/2026-02-08-feat-simplify-plugin-settings-plan.md delete mode 100644 plugins/compound-engineering/commands/technical_review.md diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 92f36240..fdf6a4de 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -12,7 +12,7 @@ { "name": "compound-engineering", "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 24 commands, and 18 skills.", - "version": "2.31.0", + "version": "2.32.0", "author": { "name": "Kieran Klaassen", "url": "https://github.com/kieranklaassen", diff --git a/docs/plans/2026-02-08-feat-simplify-plugin-settings-plan.md b/docs/plans/2026-02-08-feat-simplify-plugin-settings-plan.md new file mode 100644 index 00000000..e619a98a --- /dev/null +++ b/docs/plans/2026-02-08-feat-simplify-plugin-settings-plan.md @@ -0,0 +1,195 @@ +--- +title: Simplify Plugin Settings with .local.md Pattern +type: feat +date: 2026-02-08 +--- + +# Simplify Plugin Settings + +## Overview + +Replace the 486-line `/compound-engineering-setup` wizard and JSON config with the `.local.md` plugin-settings pattern. Make agent configuration dead simple: a YAML frontmatter file users edit directly, with a lightweight setup command that generates the template. + +## Problem Statement + +The current branch (`feat/compound-engineering-setup`) has: +- A 486-line setup command with Quick/Advanced/Minimal modes, add/remove loops, custom agent discovery +- JSON config file (`.claude/compound-engineering.json`) β€” not the plugin-settings convention +- Config-loading boilerplate that would be duplicated across 4 workflow commands +- Over-engineered for "which agents should review my code?" + +Meanwhile, the workflow commands on main have hardcoded agent lists that can't be customized per-project. + +## Proposed Solution + +Use `.claude/compound-engineering.local.md` with YAML frontmatter. Three simple changes: + +1. **Rewrite `setup.md`** (486 β†’ ~60 lines) β€” detect project type, create template file +2. **Add config reading to workflow commands** (~5 lines each) β€” read file, fall back to defaults +3. **Config is optional** β€” everything works without it via auto-detection + +### Settings File Format + +```markdown +--- +review_agents: [kieran-rails-reviewer, code-simplicity-reviewer, security-sentinel] +plan_review_agents: [kieran-rails-reviewer, code-simplicity-reviewer] +--- + +# Review Context + +Any extra instructions for review agents go here. +Focus on N+1 queries β€” we've had issues in the brief system. +Skip agent-native checks for internal admin pages. +``` + +That's it. No `conditionalAgents`, no `options`, no `customAgents` mapping. Conditional agents (migration, frontend, architecture, data) stay hardcoded in the review command β€” they trigger based on file patterns, not config. + +## Implementation Plan + +### Phase 1: Rewrite setup.md + +**File:** `plugins/compound-engineering/commands/setup.md` +**From:** 486 lines β†’ **To:** ~60 lines + +The setup command should: + +- [x] Detect project type (Gemfile+Rails, tsconfig, pyproject.toml, etc.) +- [x] Check if `.claude/compound-engineering.local.md` already exists +- [x] If exists: show current config, ask if user wants to regenerate +- [x] If not: create `.claude/compound-engineering.local.md` with smart defaults for detected type +- [x] Display the file path and tell user they can edit it directly +- [x] No wizard, no multi-step AskUserQuestion flows, no modify loops + +**Default agents by project type:** + +| Type | review_agents | plan_review_agents | +|------|--------------|-------------------| +| Rails | kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-rails-reviewer, code-simplicity-reviewer | +| Python | kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-python-reviewer, code-simplicity-reviewer | +| TypeScript | kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-typescript-reviewer, code-simplicity-reviewer | +| General | code-simplicity-reviewer, security-sentinel, performance-oracle | code-simplicity-reviewer, architecture-strategist | + +### Phase 2: Update review.md + +**File:** `plugins/compound-engineering/commands/workflows/review.md` +**Change:** Replace hardcoded agent list (lines 64-81) with config-aware section + +Add before the parallel agents section (~5 lines): + +```markdown +#### Load Review Agents + +Read `.claude/compound-engineering.local.md` (project) or `~/.claude/compound-engineering.local.md` (global). +If found, use `review_agents` from YAML frontmatter. If not found, auto-detect project type and use defaults: +- Rails: kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- Python: kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- TypeScript: kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- General: code-simplicity-reviewer, security-sentinel, performance-oracle + +Run all review agents in parallel using Task tool. +``` + +**Keep conditional agents hardcoded** β€” they trigger on file patterns (db/migrate, *.ts, etc.), not user preference. This is correct behavior. + +**Add `schema-drift-detector` as a conditional agent** β€” currently exists as an agent but isn't wired into any command. Add it to the migrations conditional block: + +```markdown +**MIGRATIONS: If PR contains database migrations or schema.rb changes:** + +- Task schema-drift-detector(PR content) - Detects unrelated schema.rb changes (run FIRST) +- Task data-migration-expert(PR content) - Validates ID mappings, rollback safety +- Task deployment-verification-agent(PR content) - Go/No-Go deployment checklist + +**When to run:** PR includes `db/migrate/*.rb` OR `db/schema.rb` +``` + +`schema-drift-detector` should run first per its own docs β€” catches drift before other DB reviewers waste time on unrelated changes. + +### Phase 3: Update work.md + +**File:** `plugins/compound-engineering/commands/workflows/work.md` +**Change:** Replace hardcoded agent list in "Consider Reviewer Agents" section (lines 180-193) + +Replace with: + +```markdown +If review agents are needed, read from `.claude/compound-engineering.local.md` frontmatter (`review_agents`). +If no config, use project-appropriate defaults. Run in parallel with Task tool. +``` + +### Phase 4: Update compound.md + +**File:** `plugins/compound-engineering/commands/workflows/compound.md` +**Change:** Update Phase 3 "Optional Enhancement" (lines 92-98) and "Applicable Specialized Agents" section (lines 214-234) + +The specialized agents in compound.md are problem-type-based (performance β†’ performance-oracle, security β†’ security-sentinel). These should stay hardcoded β€” they're not "review agents", they're domain experts triggered by problem category. No config needed. + +**Only change:** Add a note that users can customize review agents via `/compound-engineering-setup`, but don't add config-reading logic here. + +## Acceptance Criteria + +- [ ] `setup.md` is under 80 lines +- [ ] Running `/compound-engineering-setup` creates `.claude/compound-engineering.local.md` with correct defaults +- [ ] Running `/compound-engineering-setup` when config exists shows current config and asks before overwriting +- [ ] `/workflows:review` reads agents from `.local.md` when present +- [ ] `/workflows:review` falls back to auto-detected defaults when no config +- [ ] `/workflows:work` reads agents from `.local.md` when present +- [ ] `compound.md` unchanged except for a reference to the setup command +- [ ] No JSON config files β€” only `.local.md` +- [ ] Config file is optional β€” everything works without it +- [ ] Conditional agents (migrations, frontend, architecture, data) remain hardcoded in review.md + +### Phase 5: Structural Cleanup + +**5a. Delete `technical_review.md`** + +`commands/technical_review.md` is a one-line command (`Have @agent-dhh-rails-reviewer @agent-kieran-rails-reviewer @agent-code-simplicity-reviewer review...`) with `disable-model-invocation: true`. It duplicates the `/plan_review` skill. Delete it. + +- [x] Delete `plugins/compound-engineering/commands/technical_review.md` + +**5b. Add `disable-model-invocation: true` to `setup.md`** + +The setup command is deliberate β€” users run it explicitly. It should not be auto-invoked. + +- [x] Add `disable-model-invocation: true` to `setup.md` frontmatter + +**5c. Update component counts** + +After changes: 29 agents, 24 commands (25 - 1 deleted technical_review), 18 skills, 1 MCP. + +Wait β€” with setup.md added and technical_review.md deleted: 25 - 1 = 24. Same as main. Verify actual count after changes. + +- [x] Update `plugin.json` description with correct counts +- [x] Update `marketplace.json` description with correct counts +- [x] Update `README.md` component counts table + +**5d. Update CHANGELOG.md** + +- [x] Add entry for v2.32.0 documenting: settings support, schema-drift-detector wired in, technical_review removed + +## Acceptance Criteria + +- [ ] `setup.md` is under 80 lines +- [ ] `setup.md` has `disable-model-invocation: true` +- [ ] Running `/compound-engineering-setup` creates `.claude/compound-engineering.local.md` with correct defaults +- [ ] Running `/compound-engineering-setup` when config exists shows current config and asks before overwriting +- [ ] `/workflows:review` reads agents from `.local.md` when present +- [ ] `/workflows:review` falls back to auto-detected defaults when no config +- [ ] `/workflows:review` runs `schema-drift-detector` for PRs with migrations or schema.rb +- [ ] `/workflows:work` reads agents from `.local.md` when present +- [ ] `compound.md` unchanged except for a reference to the setup command +- [ ] `technical_review.md` deleted +- [ ] No JSON config files β€” only `.local.md` +- [ ] Config file is optional β€” everything works without it +- [ ] Conditional agents (migrations, frontend, architecture, data) remain hardcoded in review.md +- [ ] Component counts match across plugin.json, marketplace.json, and README.md + +## What We're NOT Doing + +- No multi-step wizard (users edit the file directly) +- No custom agent discovery (users add agent names to the YAML list) +- No `conditionalAgents` config (stays hardcoded by file pattern) +- No `options` object (agentNative, parallelReviews β€” not needed) +- No global vs project distinction in the command (just check both paths) +- No config-loading boilerplate duplicated across commands diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index f84b1a8d..783bb68c 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "compound-engineering", - "version": "2.31.0", + "version": "2.32.0", "description": "AI-powered development tools. 29 agents, 24 commands, 18 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index ec002913..1e536861 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,6 +5,28 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.32.0] - 2026-02-08 + +### Added + +- **`/compound-engineering-setup` command** β€” Configure which review agents run for your project + - Auto-detects project type (Rails, Python, TypeScript, etc.) + - Creates `.claude/compound-engineering.local.md` with smart defaults + - Uses plugin-settings pattern (YAML frontmatter + markdown body for review context) +- **`schema-drift-detector` wired into `/workflows:review`** β€” Detects unrelated schema.rb changes in PRs with migrations + +### Changed + +- **`/workflows:review`** β€” Now reads review agents from `.claude/compound-engineering.local.md` settings file, falls back to auto-detected defaults +- **`/workflows:work`** β€” Review agents now configurable via settings file +- **`/workflows:compound`** β€” Added reference to `/compound-engineering-setup` for agent customization + +### Removed + +- **`/technical_review` command** β€” Superseded by `/plan_review` skill + +--- + ## [2.31.0] - 2026-02-08 ### Added diff --git a/plugins/compound-engineering/README.md b/plugins/compound-engineering/README.md index 0aa55435..ac2b0672 100644 --- a/plugins/compound-engineering/README.md +++ b/plugins/compound-engineering/README.md @@ -94,7 +94,7 @@ Core workflow commands use `workflows:` prefix to avoid collisions with built-in | `/create-agent-skill` | Create or edit Claude Code skills | | `/generate_command` | Generate new slash commands | | `/heal-skill` | Fix skill documentation issues | -| `/technical_review` | Multi-agent technical/architecture review in parallel | +| `/compound-engineering-setup` | Configure review agents for your project | | `/report-bug` | Report a bug in the plugin | | `/reproduce-bug` | Reproduce bugs using logs and console | | `/resolve_parallel` | Resolve TODO comments in parallel | diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/commands/setup.md index b94e8396..8ada9f14 100644 --- a/plugins/compound-engineering/commands/setup.md +++ b/plugins/compound-engineering/commands/setup.md @@ -1,486 +1,95 @@ --- name: compound-engineering-setup -description: Configure compound-engineering plugin agents and preferences for your project -argument-hint: "[--global to configure globally]" +description: Configure review agents for your project +disable-model-invocation: true --- # Compound Engineering Setup -Configure which review agents and workflows to use for this project. Creates a `.claude/compound-engineering.json` configuration file. +Create a `.claude/compound-engineering.local.md` settings file with review agent defaults for this project. -## Step 0: Detect Existing Config & Custom Agents +## Step 1: Check Existing Config - +Read `.claude/compound-engineering.local.md`. If it exists, display the current contents and use AskUserQuestion: -### Check for existing configuration: +**Question:** "Settings file already exists. What would you like to do?" +**Options:** +1. **Regenerate with new defaults** β€” Overwrite with fresh auto-detected defaults +2. **View and edit** β€” Open the file for manual editing +3. **Cancel** β€” Keep current settings -```bash -# Check project config -test -f .claude/compound-engineering.json && echo "PROJECT_CONFIG_EXISTS" - -# Check global config -test -f ~/.claude/compound-engineering.json && echo "GLOBAL_CONFIG_EXISTS" -``` +If "View and edit": show the file contents and remind user to edit it directly. +If "Cancel": stop. -### Scan for custom local agents: +## Step 2: Detect Project Type ```bash -# Project-level custom agents -ls .claude/agents/*.md 2>/dev/null | head -20 - -# Global custom agents -ls ~/.claude/agents/*.md 2>/dev/null | head -20 - -# Project-level custom skills (that might be reviewers) -ls .claude/skills/*/SKILL.md 2>/dev/null | head -20 -``` - -**For each discovered agent/skill file:** -1. Read the file's YAML frontmatter or first few lines -2. Extract `name` and `description` -3. Check if name contains "review" or description mentions "code review" -4. Store as `customAgents[]` array for later - -**Example discovered agents:** -``` -Found 3 custom agents: -- my-team-reviewer (.claude/agents/my-team-reviewer.md) - "Team-specific Rails conventions" -- api-reviewer (.claude/agents/api-reviewer.md) - "REST API design review" -- test-coverage-checker (~/.claude/agents/test-coverage-checker.md) - "Verify test coverage" -``` - - - -## Step 1: Determine Setup Mode (New vs Modify) - - - -**If config already exists:** - -``` -AskUserQuestion: - questions: - - question: "Configuration found. What would you like to do?" - header: "Setup" - options: - - label: "Modify existing config" - description: "Add/remove agents from your current configuration" - - label: "Start fresh" - description: "Delete current config and set up from scratch" - - label: "View current config" - description: "Show what's currently configured" -``` - -**If "View current config":** -1. Read and display the current `.claude/compound-engineering.json` -2. Show which agents are configured for each category -3. Ask again what they want to do - -**If "Modify existing config":** β†’ Go to Step 2B (Modify Flow) - -**If "Start fresh":** β†’ Go to Step 2A (New Setup Flow) - -**If no config exists:** β†’ Go to Step 2A (New Setup Flow) - - - -## Step 2A: New Setup Flow - - - -### Detect Project Type - -```bash -# Check for common project indicators -ls Gemfile package.json requirements.txt pyproject.toml Cargo.toml go.mod 2>/dev/null -test -f config/routes.rb && echo "RAILS" -test -f tsconfig.json && echo "TYPESCRIPT" -``` - -**Detection Rules:** -- `Gemfile` + `config/routes.rb` β†’ **Rails** -- `Gemfile` without Rails β†’ **Ruby** -- `package.json` + `tsconfig.json` β†’ **TypeScript** -- `package.json` without TypeScript β†’ **JavaScript** -- `requirements.txt` OR `pyproject.toml` β†’ **Python** -- `Cargo.toml` β†’ **Rust** -- `go.mod` β†’ **Go** -- None β†’ **General** - -### Choose Setup Mode - -``` -AskUserQuestion: - questions: - - question: "How would you like to configure review agents?" - header: "Setup mode" - options: - - label: "Quick Setup (Recommended)" - description: "Smart defaults for {detected_type} + any custom agents found" - - label: "Advanced Setup" - description: "Manually select each agent including custom ones" - - label: "Minimal Setup" - description: "Only essential agents (security + simplicity)" -``` - -### Quick Setup - Apply Defaults + Custom Agents - -**For detected project type, use these defaults:** - -| Project Type | Review Agents | Plan Review Agents | -|--------------|---------------|-------------------| -| Rails | kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-rails-reviewer, code-simplicity-reviewer | -| Python | kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-python-reviewer, code-simplicity-reviewer | -| TypeScript | kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle | kieran-typescript-reviewer, code-simplicity-reviewer | -| General | code-simplicity-reviewer, security-sentinel, performance-oracle | code-simplicity-reviewer | - -**If custom agents were discovered:** - -``` -AskUserQuestion: - questions: - - question: "Found {N} custom agents. Add them to your review configuration?" - header: "Custom agents" - multiSelect: true - options: - - label: "{custom_agent_1_name}" - description: "{custom_agent_1_description}" - - label: "{custom_agent_2_name}" - description: "{custom_agent_2_description}" - - label: "Skip - don't add custom agents" - description: "Only use built-in agents" +test -f Gemfile && test -f config/routes.rb && echo "rails" || \ +test -f Gemfile && echo "ruby" || \ +test -f tsconfig.json && echo "typescript" || \ +test -f package.json && echo "javascript" || \ +test -f pyproject.toml && echo "python" || \ +test -f requirements.txt && echo "python" || \ +echo "general" ``` -Add selected custom agents to `reviewAgents` array. +## Step 3: Write Settings File -### Advanced Setup - Manual Selection - -**Question 1: Built-in Review Agents** - -``` -AskUserQuestion: - questions: - - question: "Which built-in review agents should run on every PR?" - header: "Built-in agents" - multiSelect: true - options: - - label: "kieran-rails-reviewer" - description: "Rails conventions, naming, clarity" - - label: "kieran-typescript-reviewer" - description: "TypeScript best practices, type safety" - - label: "kieran-python-reviewer" - description: "Python patterns, typing, best practices" - - label: "dhh-rails-reviewer" - description: "Opinionated Rails style" -``` - -**Question 2: Custom Agents (if any discovered)** - -``` -AskUserQuestion: - questions: - - question: "Which of your custom agents should run on every PR?" - header: "Your agents" - multiSelect: true - options: - - label: "{custom_agent_1_name}" - description: "{custom_agent_1_description} ({path})" - - label: "{custom_agent_2_name}" - description: "{custom_agent_2_description} ({path})" -``` - -**Question 3: Quality & Security** - -``` -AskUserQuestion: - questions: - - question: "Which quality and security agents should run?" - header: "Quality" - multiSelect: true - options: - - label: "code-simplicity-reviewer (Recommended)" - description: "Ensures code is as simple as possible" - - label: "security-sentinel (Recommended)" - description: "Security vulnerabilities and OWASP compliance" - - label: "performance-oracle" - description: "Performance issues and optimization" - - label: "agent-native-reviewer" - description: "Verify features are AI-accessible" -``` - -**Question 4: Conditional Agents** - -``` -AskUserQuestion: - questions: - - question: "Enable smart agents that run based on what files changed?" - header: "Conditional" - multiSelect: true - options: - - label: "Migration agents (Recommended)" - description: "data-migration-expert for DB changes" - - label: "Frontend agents" - description: "julik-frontend-races-reviewer for JS/TS" - - label: "Architecture agents" - description: "architecture-strategist for structural changes" - - label: "Data agents" - description: "data-integrity-guardian for model changes" -``` - - - -## Step 2B: Modify Existing Config - - - -Read current configuration and present current state: +Create `.claude/compound-engineering.local.md` using the Write tool with defaults for the detected project type: +**Rails:** ```markdown -## Current Configuration - -**Project Type:** {type} - -**Review Agents ({count}):** -- βœ“ kieran-rails-reviewer -- βœ“ code-simplicity-reviewer -- βœ“ security-sentinel -- βœ“ my-custom-reviewer (custom) - -**Plan Review Agents ({count}):** -- βœ“ kieran-rails-reviewer -- βœ“ code-simplicity-reviewer - -**Conditional Agents:** -- Migrations: data-migration-expert, deployment-verification-agent -- Frontend: julik-frontend-races-reviewer -- Architecture: (none) -- Data: (none) -``` - -``` -AskUserQuestion: - questions: - - question: "What would you like to modify?" - header: "Modify" - options: - - label: "Add agents" - description: "Add more agents to your configuration" - - label: "Remove agents" - description: "Remove agents you don't want" - - label: "Change conditional agents" - description: "Modify which agents run for specific file types" - - label: "Done" - description: "Save and exit" -``` - -### Add Agents Flow - -Show agents NOT currently in config: - -``` -AskUserQuestion: - questions: - - question: "Select agents to ADD to your configuration:" - header: "Add agents" - multiSelect: true - options: - - label: "dhh-rails-reviewer" - description: "Opinionated Rails style (not currently enabled)" - - label: "performance-oracle" - description: "Performance issues (not currently enabled)" - - label: "{new_custom_agent}" - description: "Your custom agent (discovered in .claude/agents/)" -``` - -### Remove Agents Flow - -Show agents currently IN config: - -``` -AskUserQuestion: - questions: - - question: "Select agents to REMOVE from your configuration:" - header: "Remove agents" - multiSelect: true - options: - - label: "kieran-rails-reviewer" - description: "Currently enabled - will be removed" - - label: "security-sentinel" - description: "Currently enabled - will be removed" -``` - -After each modification, loop back to "What would you like to modify?" until user selects "Done". - - - -## Step 3: Write Configuration - - - -**Determine target path:** -- If `--global`: `~/.claude/compound-engineering.json` -- Otherwise: `.claude/compound-engineering.json` - -**Create directory if needed:** -```bash -mkdir -p .claude # or ~/.claude for global +--- +review_agents: [kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] +plan_review_agents: [kieran-rails-reviewer, code-simplicity-reviewer] +--- ``` -**Write JSON configuration:** - -```json -{ - "version": "1.0", - "projectType": "{detected_type}", - "reviewAgents": [ - "kieran-rails-reviewer", - "code-simplicity-reviewer", - "security-sentinel", - "my-custom-reviewer" - ], - "planReviewAgents": [ - "kieran-rails-reviewer", - "code-simplicity-reviewer" - ], - "customAgents": { - "my-custom-reviewer": ".claude/agents/my-custom-reviewer.md", - "api-reviewer": "~/.claude/agents/api-reviewer.md" - }, - "conditionalAgents": { - "migrations": ["data-migration-expert", "deployment-verification-agent"], - "frontend": ["julik-frontend-races-reviewer"], - "architecture": ["architecture-strategist", "pattern-recognition-specialist"], - "data": ["data-integrity-guardian"] - }, - "options": { - "agentNative": true, - "parallelReviews": true - } -} +**Python:** +```markdown +--- +review_agents: [kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] +plan_review_agents: [kieran-python-reviewer, code-simplicity-reviewer] +--- ``` -**Note:** The `customAgents` object maps custom agent names to their file paths, so workflows know where to find them. - - - -## Step 4: Summary - - - +**TypeScript:** ```markdown -## Configuration Complete! - -**Saved to:** `.claude/compound-engineering.json` -**Project Type:** Rails - -### Review Agents (run on every PR) -**Built-in:** -- kieran-rails-reviewer -- code-simplicity-reviewer -- security-sentinel - -**Custom:** -- my-custom-reviewer (.claude/agents/) - -### Plan Review Agents -- kieran-rails-reviewer -- code-simplicity-reviewer - -### Conditional Agents (run when relevant files change) -| Trigger | Agents | -|---------|--------| -| DB Migrations | data-migration-expert, deployment-verification-agent | -| Frontend (JS/TS) | julik-frontend-races-reviewer | -| Architecture | architecture-strategist | -| Data/Models | data-integrity-guardian | - --- - -**What's next:** -1. Run `/workflows:review` to test your configuration -2. Run `/compound-engineering-setup` to modify settings anytime -3. Commit `.claude/compound-engineering.json` to share with your team - -**Add more custom agents:** -Create `.claude/agents/my-agent.md` with your custom review logic, -then re-run `/compound-engineering-setup` to add it to your config. +review_agents: [kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] +plan_review_agents: [kieran-typescript-reviewer, code-simplicity-reviewer] +--- ``` - - -## Creating Custom Agents - - - -To create your own review agent that gets auto-discovered: - -### 1. Create the agent file - -**Project-level:** `.claude/agents/my-reviewer.md` -**Global:** `~/.claude/agents/my-reviewer.md` - -### 2. Use this template: - +**General:** ```markdown --- -name: my-team-reviewer -description: Reviews code for our team's specific conventions +review_agents: [code-simplicity-reviewer, security-sentinel, performance-oracle] +plan_review_agents: [code-simplicity-reviewer, architecture-strategist] --- +``` -# My Team Reviewer - -You are a code reviewer specializing in our team's conventions. +Always append this body after the frontmatter: -## Review Checklist +```markdown -- [ ] Check naming conventions match our style guide -- [ ] Verify error handling follows our patterns -- [ ] Ensure logging is consistent -- [ ] Check for proper documentation +# Review Context -## When reviewing, focus on: +Add project-specific review instructions here. +These notes are available to all review agents during /workflows:review. +``` -1. **Naming**: We use snake_case for methods, PascalCase for classes -2. **Errors**: All errors should be logged with context -3. **Tests**: Every public method needs a test +## Step 4: Confirm -## Output format +Display: -Provide findings as a bulleted list with file:line references. ``` +Settings saved to .claude/compound-engineering.local.md -### 3. Re-run setup +Detected: {project_type} +Review agents: {agent list} +Plan review agents: {agent list} -```bash -/compound-engineering-setup +Edit the file anytime to add/remove agents or add review context. +Run /workflows:review to use your configured agents. ``` - -Your agent will be discovered and offered as an option! - - - -## Available Built-in Agents - - - -**Code Review (language-specific):** -- `kieran-rails-reviewer` - Rails conventions and best practices -- `kieran-python-reviewer` - Python patterns and typing -- `kieran-typescript-reviewer` - TypeScript type safety -- `dhh-rails-reviewer` - Opinionated Rails style - -**Quality & Security:** -- `code-simplicity-reviewer` - Code simplicity and YAGNI -- `security-sentinel` - Security vulnerabilities -- `performance-oracle` - Performance optimization -- `architecture-strategist` - Architectural patterns -- `pattern-recognition-specialist` - Code patterns and anti-patterns -- `agent-native-reviewer` - AI accessibility verification - -**Specialized (conditional):** -- `data-migration-expert` - Database migration safety -- `deployment-verification-agent` - Deployment checklists -- `data-integrity-guardian` - Data model integrity -- `julik-frontend-races-reviewer` - JavaScript race conditions - - diff --git a/plugins/compound-engineering/commands/technical_review.md b/plugins/compound-engineering/commands/technical_review.md deleted file mode 100644 index 7298df40..00000000 --- a/plugins/compound-engineering/commands/technical_review.md +++ /dev/null @@ -1,8 +0,0 @@ ---- -name: technical_review -description: Have multiple specialized agents review the technical approach and architecture of a plan in parallel -argument-hint: "[plan file path or plan content]" -disable-model-invocation: true ---- - -Have @agent-dhh-rails-reviewer @agent-kieran-rails-reviewer @agent-code-simplicity-reviewer review the technical approach in this plan in parallel. diff --git a/plugins/compound-engineering/commands/workflows/compound.md b/plugins/compound-engineering/commands/workflows/compound.md index 7f647d2f..062c449f 100644 --- a/plugins/compound-engineering/commands/workflows/compound.md +++ b/plugins/compound-engineering/commands/workflows/compound.md @@ -232,6 +232,7 @@ Based on problem type, these agents can enhance documentation: ### When to Invoke - **Auto-triggered** (optional): Agents can run post-documentation for enhancement - **Manual trigger**: User can invoke agents after /workflows:compound completes for deeper review +- **Customize agents**: Run `/compound-engineering-setup` to configure which review agents are used across all workflows ## Related Commands diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index e6593034..cfafb9b0 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -59,25 +59,31 @@ The following paths are compound-engineering pipeline artifacts and must never b If a review agent flags any file in these directories for cleanup or removal, discard that finding during synthesis. Do not create a todo for it. +#### Load Review Agents + +Read `.claude/compound-engineering.local.md` (project-level) or `~/.claude/compound-engineering.local.md` (global fallback). If found, use `review_agents` from YAML frontmatter. If the markdown body contains review context, pass it to each agent as additional instructions. + +If no settings file exists, auto-detect project type and use defaults: + +- **Rails** (Gemfile + config/routes.rb): kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- **Python** (pyproject.toml or requirements.txt): kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- **TypeScript** (tsconfig.json): kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle +- **General**: code-simplicity-reviewer, security-sentinel, performance-oracle + +Run `/compound-engineering-setup` to create a settings file with defaults. + #### Parallel Agents to review the PR: -Run ALL or most of these agents at the same time: - -1. Task kieran-rails-reviewer(PR content) -2. Task dhh-rails-reviewer(PR title) -3. If turbo is used: Task rails-turbo-expert(PR content) -4. Task git-history-analyzer(PR content) -5. Task dependency-detective(PR content) -6. Task pattern-recognition-specialist(PR content) -7. Task architecture-strategist(PR content) -8. Task code-philosopher(PR content) -9. Task security-sentinel(PR content) -10. Task performance-oracle(PR content) -11. Task devops-harmony-analyst(PR content) -12. Task data-integrity-guardian(PR content) -13. Task agent-native-reviewer(PR content) - Verify new features are agent-accessible +Run all configured review agents in parallel using Task tool. For each agent in the `review_agents` list: + +``` +Task {agent-name}(PR content + review context from settings body) +``` + +Additionally, always run: +- Task agent-native-reviewer(PR content) - Verify new features are agent-accessible @@ -87,19 +93,20 @@ Run ALL or most of these agents at the same time: These agents are run ONLY when the PR matches specific criteria. Check the PR files list to determine if they apply: -**If PR contains database migrations (db/migrate/*.rb files) or data backfills:** +**MIGRATIONS: If PR contains database migrations, schema.rb, or data backfills:** -14. Task data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety -15. Task deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries +- Task schema-drift-detector(PR content) - Detects unrelated schema.rb changes by cross-referencing against included migrations (run FIRST) +- Task data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety +- Task deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries -**When to run migration agents:** -- PR includes files matching `db/migrate/*.rb` +**When to run:** +- PR includes files matching `db/migrate/*.rb` or `db/schema.rb` - PR modifies columns that store IDs, enums, or mappings - PR includes data backfill scripts or rake tasks -- PR changes how data is read/written (e.g., changing from FK to string column) - PR title/body mentions: migration, backfill, data transformation, ID mapping **What these agents check:** +- `schema-drift-detector`: Cross-references schema.rb changes against PR migrations to catch unrelated columns/indexes from local database state - `data-migration-expert`: Verifies hard-coded mappings match production reality (prevents swapped IDs), checks for orphaned associations, validates dual-write patterns - `deployment-verification-agent`: Produces executable pre/post-deploy checklists with SQL queries, rollback procedures, and monitoring plans diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index 230300c3..8da8a29a 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -175,22 +175,16 @@ This command takes a work document (plan, specification, or todo file) and execu 2. **Consider Reviewer Agents** (Optional) - Use for complex, risky, or large changes: + Use for complex, risky, or large changes. Read agents from `.claude/compound-engineering.local.md` frontmatter (`review_agents`). If no settings file, auto-detect project type and use defaults: - - **code-simplicity-reviewer**: Check for unnecessary complexity - - **kieran-rails-reviewer**: Verify Rails conventions (Rails projects) - - **performance-oracle**: Check for performance issues - - **security-sentinel**: Scan for security vulnerabilities - - **cora-test-reviewer**: Review test quality (Rails projects with comprehensive test coverage) + - **Rails**: kieran-rails-reviewer, code-simplicity-reviewer + - **Python**: kieran-python-reviewer, code-simplicity-reviewer + - **TypeScript**: kieran-typescript-reviewer, code-simplicity-reviewer + - **General**: code-simplicity-reviewer, security-sentinel - Run reviewers in parallel with Task tool: + Run configured agents in parallel with Task tool. Present findings and address critical issues. - ``` - Task(code-simplicity-reviewer): "Review changes for simplicity" - Task(kieran-rails-reviewer): "Check Rails conventions" - ``` - - Present findings to user and address critical issues. + Run `/compound-engineering-setup` to configure which agents to use. 3. **Final Validation** - All TodoWrite tasks marked completed From dad6b4b646c58a26a1b52e652838b61311fe00cf Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Sun, 8 Feb 2026 22:05:54 -0800 Subject: [PATCH 09/16] Rewrite .claude/ paths for OpenCode/Codex targets, add npm publish workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Converters now rewrite .claude/ β†’ .opencode/ (OpenCode) and .codex/ (Codex) in command bodies and agent bodies so .local.md settings work cross-platform - Apply transformContentForCodex to agent bodies (was only commands before) - Add GitHub Action to auto-publish to npm on version bump merge to main - Bump to v0.4.0 Co-Authored-By: Claude Opus 4.6 --- .github/workflows/publish.yml | 61 ++++++++ ...cal-md-settings-for-opencode-codex-plan.md | 143 ++++++++++++++++++ package.json | 2 +- src/converters/claude-to-codex.ts | 9 +- src/converters/claude-to-opencode.ts | 10 +- tests/codex-converter.test.ts | 67 ++++++++ tests/converter.test.ts | 66 ++++++++ 7 files changed, 353 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/publish.yml create mode 100644 docs/plans/2026-02-08-feat-convert-local-md-settings-for-opencode-codex-plan.md diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml new file mode 100644 index 00000000..51eab178 --- /dev/null +++ b/.github/workflows/publish.yml @@ -0,0 +1,61 @@ +name: Publish to npm + +on: + push: + branches: [main] + paths: [package.json] + +jobs: + publish: + runs-on: ubuntu-latest + permissions: + contents: read + id-token: write + + steps: + - uses: actions/checkout@v4 + + - name: Setup Bun + uses: oven-sh/setup-bun@v2 + with: + bun-version: latest + + - name: Install dependencies + run: bun install + + - name: Run tests + run: bun test + + - name: Check if version changed + id: version + run: | + PUBLISHED=$(npm view @every-env/compound-plugin version 2>/dev/null || echo "0.0.0") + LOCAL=$(node -p "require('./package.json').version") + echo "published=$PUBLISHED" >> "$GITHUB_OUTPUT" + echo "local=$LOCAL" >> "$GITHUB_OUTPUT" + if [ "$PUBLISHED" = "$LOCAL" ]; then + echo "changed=false" >> "$GITHUB_OUTPUT" + else + echo "changed=true" >> "$GITHUB_OUTPUT" + fi + + - name: Setup Node for npm publish + if: steps.version.outputs.changed == 'true' + uses: actions/setup-node@v4 + with: + node-version: 22 + registry-url: https://registry.npmjs.org + + - name: Publish + if: steps.version.outputs.changed == 'true' + run: npm publish --provenance --access public + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + + - name: Summary + run: | + if [ "${{ steps.version.outputs.changed }}" = "true" ]; then + echo "Published @every-env/compound-plugin@${{ steps.version.outputs.local }}" >> "$GITHUB_STEP_SUMMARY" + else + echo "Version ${{ steps.version.outputs.local }} already published, skipping." >> "$GITHUB_STEP_SUMMARY" + fi diff --git a/docs/plans/2026-02-08-feat-convert-local-md-settings-for-opencode-codex-plan.md b/docs/plans/2026-02-08-feat-convert-local-md-settings-for-opencode-codex-plan.md new file mode 100644 index 00000000..c477abe7 --- /dev/null +++ b/docs/plans/2026-02-08-feat-convert-local-md-settings-for-opencode-codex-plan.md @@ -0,0 +1,143 @@ +--- +title: Convert .local.md Settings for OpenCode and Codex +type: feat +date: 2026-02-08 +--- + +# Convert .local.md Settings for OpenCode and Codex + +## Overview + +PR #124 introduces `.claude/compound-engineering.local.md` β€” a YAML frontmatter settings file that workflow commands (`review.md`, `work.md`) read at runtime to decide which agents to run. The conversion script already handles agents, commands, skills, hooks, and MCP servers. It does **not** handle `.local.md` settings files. + +The question: can OpenCode and Codex support this same pattern? And what does the converter need to do? + +## Analysis: What `.local.md` Actually Does + +The settings file does two things: + +1. **YAML frontmatter** with structured config: `review_agents: [list]`, `plan_review_agents: [list]` +2. **Markdown body** with free-text instructions passed to review agents as context + +The commands (`review.md`, `work.md`) read this file at runtime using the Read tool and use the values to decide which Task agents to spawn. This is **prompt-level logic** β€” it's instructions in the command body telling the AI "read this file, parse it, act on it." + +## Key Insight: This Already Works + +The converter already converts `review.md` and `work.md` command bodies verbatim (for OpenCode) or as generated skills (for Codex). The instructions that say "Read `.claude/compound-engineering.local.md`" are just markdown text inside the command body. When the converter outputs them: + +- **OpenCode**: The command template includes the full body. The AI reads it, follows the instructions, reads the settings file. +- **Codex**: The command becomes a prompt + generated skill. The skill body includes the instructions. The AI reads it, follows the instructions, reads the settings file. + +**The `.local.md` file itself is not a plugin component** β€” it's a runtime artifact created per-project by the user (via `/compound-engineering-setup`). The converter doesn't need to bundle it. + +## What Needs Attention + +### 1. Setup Command Has `disable-model-invocation: true` + +`setup.md` has `disable-model-invocation: true`. The converter already handles this correctly: + +- **OpenCode** (`claude-to-opencode.ts:117`): Skips commands with `disableModelInvocation` +- **Codex** (`claude-to-codex.ts:22`): Filters them out of prompts and generated skills + +This means `/compound-engineering-setup` won't be auto-invocable in either target. That's correct β€” it's a deliberate user action. But it also means users of the converted plugin have **no way to run setup**. They'd need to manually create the `.local.md` file. + +### 2. The `.local.md` File Path Is Claude-Specific + +The commands reference `.claude/compound-engineering.local.md`. In OpenCode, the equivalent directory is `.opencode/`. In Codex, it's `.codex/`. The converter currently does **no text rewriting** of file paths inside command bodies. + +### 3. Slash Command References in Config-Aware Sections + +The commands say things like "Run `/compound-engineering-setup` to create a settings file." The Codex converter already transforms `/command-name` β†’ `/prompts:command-name`, but since setup has `disable-model-invocation`, there's no matching prompt. This reference becomes a dead link. + +### 4. `Task {agent-name}(...)` Syntax in Review Commands + +`review.md` uses `Task {agent-name}(PR content)` β€” the Codex converter already transforms these to `$skill-name` references. OpenCode passes them through as template text. + +## Proposed Solution + +### Phase 1: Add Settings File Path Rewriting to Converters + +Both converters should rewrite `.claude/` paths inside command bodies to the target-appropriate directory. + +**File:** `src/converters/claude-to-opencode.ts` + +Add a `transformContentForOpenCode(body)` function that replaces: +- `.claude/compound-engineering.local.md` β†’ `.opencode/compound-engineering.local.md` +- `~/.claude/compound-engineering.local.md` β†’ `~/.config/opencode/compound-engineering.local.md` + +Apply it in `convertCommands()` to the command body before storing as template. + +**File:** `src/converters/claude-to-codex.ts` + +Extend `transformContentForCodex(body)` to also replace: +- `.claude/compound-engineering.local.md` β†’ `.codex/compound-engineering.local.md` +- `~/.claude/compound-engineering.local.md` β†’ `~/.codex/compound-engineering.local.md` + +### Phase 2: Generate Setup Equivalent for Each Target + +Since `setup.md` is excluded by `disable-model-invocation`, the converter should generate a **target-native setup instruction** that tells users how to create the settings file. + +**Option A: Include setup as a non-auto-invocable command anyway** (recommended) + +Change the converters to include `disable-model-invocation` commands but mark them appropriately: +- **OpenCode**: Include in command map but add a `manual: true` flag or comment +- **Codex**: Include as a prompt (user can still invoke it manually via `/prompts:compound-engineering-setup`) + +This is the simplest approach β€” the setup instructions are useful even if not auto-triggered. + +**Option B: Generate a README/instructions file** + +Create a `compound-engineering-settings.md` file in the output that documents how to create the settings file for the target platform. More complex, less useful. + +**Recommendation: Option A** β€” just stop filtering out `disable-model-invocation` commands entirely. Both OpenCode and Codex support user-invoked commands/prompts. The flag exists to prevent Claude from auto-invoking during conversation, not to hide the command entirely. + +### Phase 3: Update Tests + +**File:** `tests/converter.test.ts` + +- Add test that `.claude/` paths in command bodies are rewritten to `.opencode/` paths +- Update existing `disable-model-invocation` test to verify the command IS included (if Option A) + +**File:** `tests/codex-converter.test.ts` + +- Add test that `.claude/` paths are rewritten to `.codex/` paths +- Add test that setup command is included as a prompt (if Option A) +- Add test that slash command references to setup are preserved correctly + +### Phase 4: Add Fixture for Settings-Aware Command + +**File:** `tests/fixtures/sample-plugin/commands/settings-aware-command.md` + +```markdown +--- +name: workflows:review +description: Run comprehensive code reviews +--- + +Read `.claude/compound-engineering.local.md` for agent config. +If not found, use defaults. +Run `/compound-engineering-setup` to create settings. +``` + +Test that the converter rewrites the paths and command references correctly. + +## Acceptance Criteria + +- [ ] OpenCode converter rewrites `.claude/` β†’ `.opencode/` in command bodies +- [ ] Codex converter rewrites `.claude/` β†’ `.codex/` in command/skill bodies +- [ ] Global path `~/.claude/` rewritten to target-appropriate global path +- [ ] `disable-model-invocation` commands are included (not filtered) in both targets +- [ ] Tests cover path rewriting for both targets +- [ ] Tests cover setup command inclusion +- [ ] Existing tests still pass + +## What We're NOT Doing + +- Not bundling the `.local.md` file itself (it's user-created per-project) +- Not converting YAML frontmatter format (both targets can read `.md` files with YAML) +- Not adding target-specific setup wizards (the instructions in the command body work across all targets) +- Not rewriting `AskUserQuestion` tool references (all three platforms support equivalent interactive tools) + +## Complexity Assessment + +This is a **small change** β€” mostly string replacement in the converters plus updating the `disable-model-invocation` filter. The `.local.md` pattern is prompt-level instructions, not a proprietary API. It works anywhere an AI can read a file and follow instructions. diff --git a/package.json b/package.json index e7d4551c..eb3293bf 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@every-env/compound-plugin", - "version": "0.3.0", + "version": "0.4.0", "type": "module", "private": false, "bin": { diff --git a/src/converters/claude-to-codex.ts b/src/converters/claude-to-codex.ts index 2b12daaf..c98eedb1 100644 --- a/src/converters/claude-to-codex.ts +++ b/src/converters/claude-to-codex.ts @@ -46,7 +46,7 @@ function convertAgent(agent: ClaudeAgent, usedNames: Set): CodexGenerate ) const frontmatter: Record = { name, description } - let body = agent.body.trim() + let body = transformContentForCodex(agent.body.trim()) if (agent.capabilities && agent.capabilities.length > 0) { const capabilities = agent.capabilities.map((capability) => `- ${capability}`).join("\n") body = `## Capabilities\n${capabilities}\n\n${body}`.trim() @@ -121,7 +121,12 @@ function transformContentForCodex(body: string): string { return `/prompts:${normalizedName}` }) - // 3. Transform @agent-name references + // 3. Rewrite .claude/ paths to .codex/ + result = result + .replace(/~\/\.claude\//g, "~/.codex/") + .replace(/\.claude\//g, ".codex/") + + // 4. Transform @agent-name references // Match: @agent-name in text (not emails) const agentRefPattern = /@([a-z][a-z0-9-]*-(?:agent|reviewer|researcher|analyst|specialist|oracle|sentinel|guardian|strategist))/gi result = result.replace(agentRefPattern, (_match, agentName: string) => { diff --git a/src/converters/claude-to-opencode.ts b/src/converters/claude-to-opencode.ts index 5d675f96..9d871a8a 100644 --- a/src/converters/claude-to-opencode.ts +++ b/src/converters/claude-to-opencode.ts @@ -103,7 +103,7 @@ function convertAgent(agent: ClaudeAgent, options: ClaudeToOpenCodeOptions) { } } - const content = formatFrontmatter(frontmatter, agent.body) + const content = formatFrontmatter(frontmatter, rewriteClaudePaths(agent.body)) return { name: agent.name, @@ -117,7 +117,7 @@ function convertCommands(commands: ClaudeCommand[]): Record { + const plugin: ClaudePlugin = { + ...fixturePlugin, + commands: [ + { + name: "review", + description: "Review command", + body: `Read \`.claude/compound-engineering.local.md\` (project-level) or \`~/.claude/compound-engineering.local.md\` (global fallback). + +If no settings file exists, auto-detect project type. + +Run \`/compound-engineering-setup\` to create a settings file.`, + sourcePath: "/tmp/plugin/commands/review.md", + }, + ], + agents: [], + skills: [], + } + + const bundle = convertClaudeToCodex(plugin, { + agentMode: "subagent", + inferTemperature: false, + permissions: "none", + }) + + const commandSkill = bundle.generatedSkills.find((s) => s.name === "review") + expect(commandSkill).toBeDefined() + const parsed = parseFrontmatter(commandSkill!.content) + + // .claude/ paths should be rewritten to .codex/ + expect(parsed.body).toContain(".codex/compound-engineering.local.md") + expect(parsed.body).not.toContain(".claude/compound-engineering.local.md") + + // Global path should be rewritten + expect(parsed.body).toContain("~/.codex/compound-engineering.local.md") + expect(parsed.body).not.toContain("~/.claude/compound-engineering.local.md") + }) + + test("rewrites .claude/ paths in agent skill bodies", () => { + const plugin: ClaudePlugin = { + ...fixturePlugin, + commands: [], + skills: [], + agents: [ + { + name: "config-reader", + description: "Reads config", + body: "Read `.claude/compound-engineering.local.md` for config.", + sourcePath: "/tmp/plugin/agents/config-reader.md", + }, + ], + } + + const bundle = convertClaudeToCodex(plugin, { + agentMode: "subagent", + inferTemperature: false, + permissions: "none", + }) + + const agentSkill = bundle.generatedSkills.find((s) => s.name === "config-reader") + expect(agentSkill).toBeDefined() + const parsed = parseFrontmatter(agentSkill!.content) + + expect(parsed.body).toContain(".codex/compound-engineering.local.md") + expect(parsed.body).not.toContain(".claude/compound-engineering.local.md") + }) + test("truncates generated skill descriptions to Codex limits and single line", () => { const longDescription = `Line one\nLine two ${"a".repeat(2000)}` const plugin: ClaudePlugin = { diff --git a/tests/converter.test.ts b/tests/converter.test.ts index 71aedad0..227f8c7e 100644 --- a/tests/converter.test.ts +++ b/tests/converter.test.ts @@ -3,6 +3,7 @@ import path from "path" import { loadClaudePlugin } from "../src/parsers/claude" import { convertClaudeToOpenCode } from "../src/converters/claude-to-opencode" import { parseFrontmatter } from "../src/utils/frontmatter" +import type { ClaudePlugin } from "../src/types/claude" const fixtureRoot = path.join(import.meta.dir, "fixtures", "sample-plugin") @@ -183,4 +184,69 @@ describe("convertClaudeToOpenCode", () => { // Normal commands should still be present expect(bundle.config.command?.["workflows:review"]).toBeDefined() }) + + test("rewrites .claude/ paths to .opencode/ in command bodies", () => { + const plugin: ClaudePlugin = { + root: "/tmp/plugin", + manifest: { name: "fixture", version: "1.0.0" }, + agents: [], + commands: [ + { + name: "review", + description: "Review command", + body: `Read \`.claude/compound-engineering.local.md\` (project-level) or \`~/.claude/compound-engineering.local.md\` (global fallback). + +If no settings file exists, auto-detect project type. + +Run \`/compound-engineering-setup\` to create a settings file.`, + sourcePath: "/tmp/plugin/commands/review.md", + }, + ], + skills: [], + } + + const bundle = convertClaudeToOpenCode(plugin, { + agentMode: "subagent", + inferTemperature: false, + permissions: "none", + }) + + const template = bundle.config.command?.["review"]?.template ?? "" + + // .claude/ paths should be rewritten to .opencode/ + expect(template).toContain(".opencode/compound-engineering.local.md") + expect(template).not.toContain(".claude/compound-engineering.local.md") + + // Global path should be rewritten + expect(template).toContain("~/.config/opencode/compound-engineering.local.md") + expect(template).not.toContain("~/.claude/compound-engineering.local.md") + }) + + test("rewrites .claude/ paths in agent bodies", () => { + const plugin: ClaudePlugin = { + root: "/tmp/plugin", + manifest: { name: "fixture", version: "1.0.0" }, + agents: [ + { + name: "test-agent", + description: "Test agent", + body: "Read `.claude/compound-engineering.local.md` for config.", + sourcePath: "/tmp/plugin/agents/test-agent.md", + }, + ], + commands: [], + skills: [], + } + + const bundle = convertClaudeToOpenCode(plugin, { + agentMode: "subagent", + inferTemperature: false, + permissions: "none", + }) + + const agentFile = bundle.agents.find((a) => a.name === "test-agent") + expect(agentFile).toBeDefined() + expect(agentFile!.content).toContain(".opencode/compound-engineering.local.md") + expect(agentFile!.content).not.toContain(".claude/compound-engineering.local.md") + }) }) From c781dcbae25525268b789678629cfeb55596cc31 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Mon, 9 Feb 2026 16:23:47 -0800 Subject: [PATCH 10/16] feat(workflows-work): require post-deploy monitoring section Add a mandatory Post-Deploy Monitoring & Validation section to the /workflows:work PR template, include no-impact fallback guidance, and enforce it in the quality checklist. --- .../commands/workflows/work.md | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index 8da8a29a..6b61a818 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -194,6 +194,16 @@ This command takes a work document (plan, specification, or todo file) and execu - Figma designs match (if applicable) - No console errors or warnings +4. **Prepare Operational Validation Plan** (REQUIRED) + - Add a `## Post-Deploy Monitoring & Validation` section to the PR description for every change. + - Include concrete: + - Log queries/search terms + - Metrics or dashboards to watch + - Expected healthy signals + - Failure signals and rollback/mitigation trigger + - Validation window and owner + - If there is truly no production/runtime impact, still include the section with: `No additional operational monitoring required` and a one-line reason. + ### Phase 4: Ship It 1. **Create Commit** @@ -263,6 +273,22 @@ This command takes a work document (plan, specification, or todo file) and execu - Tests added/modified - Manual testing performed + ## Post-Deploy Monitoring & Validation + - **What to monitor/search** + - Logs: + - Metrics/Dashboards: + - **Validation checks (queries/commands)** + - `command or query here` + - **Expected healthy behavior** + - Expected signal(s) + - **Failure signal(s) / rollback trigger** + - Trigger + immediate action + - **Validation window & owner** + - Window: + - Owner: + - **If no operational impact** + - `No additional operational monitoring required: ` + ## Before / After Screenshots | Before | After | |--------|-------| @@ -401,6 +427,7 @@ Before creating PR, verify: - [ ] Figma designs match implementation (if applicable) - [ ] Before/after screenshots captured and uploaded (for UI changes) - [ ] Commit messages follow conventional format +- [ ] PR description includes Post-Deploy Monitoring & Validation section (or explicit no-impact rationale) - [ ] PR description includes summary, testing notes, and screenshots - [ ] PR description includes Compound Engineered badge From 2dd3e53a4c214e834d108f1a762e9b9068b826b0 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 08:19:21 -0800 Subject: [PATCH 11/16] Add learnings-researcher to review workflow, fix docs site counts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add learnings-researcher as parallel agent #14 in /workflows:review so past solutions from docs/solutions/ are surfaced during code review - Make /release-docs command invocable (remove disable-model-invocation) - Fix stale counts across docs site (agents 28β†’29, commands 19β†’24, skills 15β†’18, MCP servers 2β†’1) - Bump version to 2.32.1 Co-Authored-By: Claude Opus 4.6 --- .claude-plugin/marketplace.json | 2 +- docs/index.html | 24 +++++++++---------- docs/pages/changelog.html | 20 ++++++++++++++++ .../.claude-plugin/plugin.json | 2 +- plugins/compound-engineering/CHANGELOG.md | 8 +++++++ .../commands/release-docs.md | 1 - .../commands/workflows/review.md | 2 ++ 7 files changed, 44 insertions(+), 15 deletions(-) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 92f36240..b5296b38 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -12,7 +12,7 @@ { "name": "compound-engineering", "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 24 commands, and 18 skills.", - "version": "2.31.0", + "version": "2.32.1", "author": { "name": "Kieran Klaassen", "url": "https://github.com/kieranklaassen", diff --git a/docs/index.html b/docs/index.html index ec26ee37..a3d05961 100644 --- a/docs/index.html +++ b/docs/index.html @@ -4,7 +4,7 @@ Compounding Engineering - AI-Powered Development Tools for Claude Code - + @@ -12,7 +12,7 @@ - + @@ -155,13 +155,13 @@
- Version 2.28.0 released! + Version 2.32.1 released!

Your Code Reviews Just Got 12 Expert Opinions. In 30 Seconds.

- Here's what happened when we shipped yesterday: security audit, performance analysis, architectural review, pattern detection, and eight more specialized checksβ€”all running in parallel. No meetings. No waiting. Just answers. That's compounding engineering: 28 specialized agents, 24 workflow commands, and 15 skills that make today's work easier than yesterday's. + Here's what happened when we shipped yesterday: security audit, performance analysis, architectural review, pattern detection, and eight more specialized checksβ€”all running in parallel. No meetings. No waiting. Just answers. That's compounding engineering: 29 specialized agents, 24 workflow commands, and 18 skills that make today's work easier than yesterday's.

@@ -179,7 +179,7 @@

-
28
+
29
Specialized Agents
@@ -189,7 +189,7 @@

-
15
+
18
Intelligent Skills
@@ -244,7 +244,7 @@

Delegate

The security-sentinel has checked 10,000 PRs for SQL injection. The kieran-rails-reviewer never approves a controller with business logic. They don't get tired, don't skip Friday afternoon reviews, don't forget the conventions you agreed on in March. Run /work and watch your plan execute with quality gates that actually enforce your standardsβ€”every single time.

- 27 specialized agents + 29 specialized agents /work dhh-rails-style skill git-worktree skill @@ -292,7 +292,7 @@

Compound

- 27 Specialized Agents + 29 Specialized Agents

Think of them as coworkers who never quit. The security-sentinel has seen every SQL injection variant. The kieran-rails-reviewer enforces conventions with zero compromise. The performance-oracle spots N+1 queries while you're still reading the PR. Run them solo or launch twelve in parallelβ€”your choice. @@ -531,7 +531,7 @@

Documentation Agent (1)

- 19 Powerful Commands + 24 Powerful Commands

Slash commands that replace entire workflows. /review is your code review committee. /plan is your research team. /triage sorts 50 todos in the time it takes you to read five. Each one automates hours of work into a single line. @@ -683,7 +683,7 @@

Utility Commands

- 12 Intelligent Skills + 18 Intelligent Skills

Domain expertise on tap. Need to write a Ruby gem? The andrew-kane-gem-writer knows the patterns Andrew uses in 50+ popular gems. Building a Rails app? The dhh-rails-style enforces 37signals conventions. Generating images? The gemini-imagegen has Google's AI on speed dial. Just invoke the skill and watch it work. @@ -825,7 +825,7 @@

Image Generation

- Two MCP Servers + 1 MCP Server

Playwright gives Claude a browserβ€”it can click buttons, take screenshots, fill forms, and validate what your users actually see. Context7 gives it instant access to docs for 100+ frameworks. Need to know how Next.js handles dynamic routes? Context7 fetches the answer in real-time instead of hallucinating from outdated training data. @@ -989,7 +989,7 @@

Frequently Asked Questions

Free & Open Source

Install Once. Compound Forever.

- Your next code review takes 30 seconds. The one after that? Even faster. That's compounding. Get 27 expert agents, 19 workflow commands, and 12 specialized skills working for you right now. + Your next code review takes 30 seconds. The one after that? Even faster. That's compounding. Get 29 expert agents, 24 workflow commands, and 18 specialized skills working for you right now.

diff --git a/docs/pages/changelog.html b/docs/pages/changelog.html index 7cf731cf..f02542d1 100644 --- a/docs/pages/changelog.html +++ b/docs/pages/changelog.html @@ -48,6 +48,7 @@

Resources

On This Page

    +
  • v2.32.1
  • v2.6.0
  • v2.5.0
  • v2.4.1
    • @@ -86,6 +87,25 @@

    Changelog

    Keep a Changelog conventions.

    + +
    +
    +

    v2.32.1

    + 2026-02-12 +
    + +
    +

    Changed

    +
      +
    • + /workflows:review command - Added learnings-researcher + agent to the parallel review phase. The review now searches docs/solutions/ for past + issues related to the PR's modules and patterns, surfacing "Known Pattern" findings during synthesis. +
      • +
    +
    +
    +
    diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index 382bb8a3..7886767b 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "compound-engineering", - "version": "2.31.1", + "version": "2.32.1", "description": "AI-powered development tools. 29 agents, 24 commands, 18 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index cc21da61..a9252587 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,6 +5,14 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.32.1] - 2026-02-12 + +### Changed + +- **`/workflows:review` command** β€” Added `learnings-researcher` agent to the parallel review phase. The review now searches `docs/solutions/` for past issues related to the PR's modules and patterns, surfacing "Known Pattern" findings during synthesis. Closes the compound loop: `/workflows:compound` writes solutions β†’ `/workflows:plan` reads them before building β†’ `/workflows:review` reads them before reviewing. + +--- + ## [2.32.0] - 2026-02-11 ### Added diff --git a/plugins/compound-engineering/commands/release-docs.md b/plugins/compound-engineering/commands/release-docs.md index 6f96e09c..903d6aeb 100644 --- a/plugins/compound-engineering/commands/release-docs.md +++ b/plugins/compound-engineering/commands/release-docs.md @@ -2,7 +2,6 @@ name: release-docs description: Build and update the documentation site with current plugin components argument-hint: "[optional: --dry-run to preview changes without writing]" -disable-model-invocation: true --- # Release Documentation Command diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index e6593034..fefee464 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -78,6 +78,7 @@ Run ALL or most of these agents at the same time: 11. Task devops-harmony-analyst(PR content) 12. Task data-integrity-guardian(PR content) 13. Task agent-native-reviewer(PR content) - Verify new features are agent-accessible +14. Task learnings-researcher(PR content) - Search docs/solutions/ for past issues related to this PR's modules and patterns @@ -218,6 +219,7 @@ Remove duplicates, prioritize by severity and impact. - [ ] Collect findings from all parallel agents +- [ ] Surface learnings-researcher results: if past solutions are relevant, flag them as "Known Pattern" with links to docs/solutions/ files - [ ] Discard any findings that recommend deleting or gitignoring files in `docs/plans/` or `docs/solutions/` (see Protected Artifacts above) - [ ] Categorize by type: security, performance, architecture, quality, etc. - [ ] Assign severity levels: πŸ”΄ CRITICAL (P1), 🟑 IMPORTANT (P2), πŸ”΅ NICE-TO-HAVE (P3) From 7feea6f4571d40261853fed691513202b9432da9 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 08:21:27 -0800 Subject: [PATCH 12/16] Move /release-docs to local .claude/commands/, bump to 2.32.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Repo maintenance command doesn't need to be distributed to plugin users. Update command count 24 β†’ 23 across plugin.json, marketplace.json, and docs. Co-Authored-By: Claude Opus 4.6 --- .claude-plugin/marketplace.json | 4 ++-- .../commands/release-docs.md | 0 docs/index.html | 12 ++++++------ docs/pages/changelog.html | 19 +++++++++++++++++++ .../.claude-plugin/plugin.json | 4 ++-- plugins/compound-engineering/CHANGELOG.md | 8 ++++++++ 6 files changed, 37 insertions(+), 10 deletions(-) rename {plugins/compound-engineering => .claude}/commands/release-docs.md (100%) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index b5296b38..29139c15 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -11,8 +11,8 @@ "plugins": [ { "name": "compound-engineering", - "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 24 commands, and 18 skills.", - "version": "2.32.1", + "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 23 commands, and 18 skills.", + "version": "2.32.2", "author": { "name": "Kieran Klaassen", "url": "https://github.com/kieranklaassen", diff --git a/plugins/compound-engineering/commands/release-docs.md b/.claude/commands/release-docs.md similarity index 100% rename from plugins/compound-engineering/commands/release-docs.md rename to .claude/commands/release-docs.md diff --git a/docs/index.html b/docs/index.html index a3d05961..08021995 100644 --- a/docs/index.html +++ b/docs/index.html @@ -4,7 +4,7 @@ Compounding Engineering - AI-Powered Development Tools for Claude Code - + @@ -155,13 +155,13 @@
    - Version 2.32.1 released! + Version 2.32.2 released!

    Your Code Reviews Just Got 12 Expert Opinions. In 30 Seconds.

    - Here's what happened when we shipped yesterday: security audit, performance analysis, architectural review, pattern detection, and eight more specialized checksβ€”all running in parallel. No meetings. No waiting. Just answers. That's compounding engineering: 29 specialized agents, 24 workflow commands, and 18 skills that make today's work easier than yesterday's. + Here's what happened when we shipped yesterday: security audit, performance analysis, architectural review, pattern detection, and eight more specialized checksβ€”all running in parallel. No meetings. No waiting. Just answers. That's compounding engineering: 29 specialized agents, 23 workflow commands, and 18 skills that make today's work easier than yesterday's.

    @@ -184,7 +184,7 @@

    -
    24
    +
    23
    Slash Commands
    @@ -531,7 +531,7 @@

    Documentation Agent (1)

    - 24 Powerful Commands + 23 Powerful Commands

    Slash commands that replace entire workflows. /review is your code review committee. /plan is your research team. /triage sorts 50 todos in the time it takes you to read five. Each one automates hours of work into a single line. @@ -989,7 +989,7 @@

    Frequently Asked Questions

    Free & Open Source

    Install Once. Compound Forever.

    - Your next code review takes 30 seconds. The one after that? Even faster. That's compounding. Get 29 expert agents, 24 workflow commands, and 18 specialized skills working for you right now. + Your next code review takes 30 seconds. The one after that? Even faster. That's compounding. Get 29 expert agents, 23 workflow commands, and 18 specialized skills working for you right now.

    diff --git a/docs/pages/changelog.html b/docs/pages/changelog.html index f02542d1..dd0c72dc 100644 --- a/docs/pages/changelog.html +++ b/docs/pages/changelog.html @@ -48,6 +48,7 @@

    Resources

    On This Page

      +
    • v2.32.2
    • v2.32.1
    • v2.6.0
    • v2.5.0
      • @@ -87,6 +88,24 @@

      Changelog

      Keep a Changelog conventions.

      + +
      +
      +

      v2.32.2

      + 2026-02-12 +
      + +
      +

      Changed

      +
        +
      • + /release-docs command moved from plugin to local .claude/commands/ - + This is a repository maintenance command and should not be distributed to users. Command count reduced from 24 to 23. +
        • +
      +
      +
      +
      diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index 7886767b..bd085ab8 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "compound-engineering", - "version": "2.32.1", - "description": "AI-powered development tools. 29 agents, 24 commands, 18 skills, 1 MCP server for code review, research, design, and workflow automation.", + "version": "2.32.2", + "description": "AI-powered development tools. 29 agents, 23 commands, 18 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", "email": "kieran@every.to", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index a9252587..c29cbea7 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,6 +5,14 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.32.2] - 2026-02-12 + +### Changed + +- **`/release-docs` command** β€” Moved from plugin to local `.claude/commands/` since it's a repo maintenance command, not something distributed to plugin users. Plugin command count: 24 β†’ 23. + +--- + ## [2.32.1] - 2026-02-12 ### Changed From d0d6c042380824c1f9d497fd3911f76a47cba960 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 08:31:37 -0800 Subject: [PATCH 13/16] Move settings to project root: compound-engineering.local.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Tool-agnostic location β€” works for Claude, Codex, OpenCode without path rewriting. No global fallback, just project root. Update commands (setup, review, work) and converter tests. Co-Authored-By: Claude Opus 4.6 --- plugins/compound-engineering/commands/setup.md | 8 ++++---- .../commands/workflows/review.md | 2 +- .../commands/workflows/work.md | 2 +- tests/codex-converter.test.ts | 17 ++++++----------- tests/converter.test.ts | 17 ++++++----------- 5 files changed, 18 insertions(+), 28 deletions(-) diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/commands/setup.md index 8ada9f14..6031204f 100644 --- a/plugins/compound-engineering/commands/setup.md +++ b/plugins/compound-engineering/commands/setup.md @@ -6,11 +6,11 @@ disable-model-invocation: true # Compound Engineering Setup -Create a `.claude/compound-engineering.local.md` settings file with review agent defaults for this project. +Create a `compound-engineering.local.md` settings file with review agent defaults for this project. ## Step 1: Check Existing Config -Read `.claude/compound-engineering.local.md`. If it exists, display the current contents and use AskUserQuestion: +Read `compound-engineering.local.md`. If it exists, display the current contents and use AskUserQuestion: **Question:** "Settings file already exists. What would you like to do?" **Options:** @@ -35,7 +35,7 @@ echo "general" ## Step 3: Write Settings File -Create `.claude/compound-engineering.local.md` using the Write tool with defaults for the detected project type: +Create `compound-engineering.local.md` using the Write tool with defaults for the detected project type: **Rails:** ```markdown @@ -84,7 +84,7 @@ These notes are available to all review agents during /workflows:review. Display: ``` -Settings saved to .claude/compound-engineering.local.md +Settings saved to compound-engineering.local.md Detected: {project_type} Review agents: {agent list} diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index 6cd10981..358c5816 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -61,7 +61,7 @@ If a review agent flags any file in these directories for cleanup or removal, di #### Load Review Agents -Read `.claude/compound-engineering.local.md` (project-level) or `~/.claude/compound-engineering.local.md` (global fallback). If found, use `review_agents` from YAML frontmatter. If the markdown body contains review context, pass it to each agent as additional instructions. +Read `compound-engineering.local.md` in the project root. If found, use `review_agents` from YAML frontmatter. If the markdown body contains review context, pass it to each agent as additional instructions. If no settings file exists, auto-detect project type and use defaults: diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index 6b61a818..9f8f57ec 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -175,7 +175,7 @@ This command takes a work document (plan, specification, or todo file) and execu 2. **Consider Reviewer Agents** (Optional) - Use for complex, risky, or large changes. Read agents from `.claude/compound-engineering.local.md` frontmatter (`review_agents`). If no settings file, auto-detect project type and use defaults: + Use for complex, risky, or large changes. Read agents from `compound-engineering.local.md` frontmatter (`review_agents`). If no settings file, auto-detect project type and use defaults: - **Rails**: kieran-rails-reviewer, code-simplicity-reviewer - **Python**: kieran-python-reviewer, code-simplicity-reviewer diff --git a/tests/codex-converter.test.ts b/tests/codex-converter.test.ts index fba79be6..b6650b1d 100644 --- a/tests/codex-converter.test.ts +++ b/tests/codex-converter.test.ts @@ -217,7 +217,7 @@ Don't confuse with file paths like /tmp/output.md or /dev/null.`, { name: "review", description: "Review command", - body: `Read \`.claude/compound-engineering.local.md\` (project-level) or \`~/.claude/compound-engineering.local.md\` (global fallback). + body: `Read \`compound-engineering.local.md\` in the project root. If no settings file exists, auto-detect project type. @@ -239,13 +239,8 @@ Run \`/compound-engineering-setup\` to create a settings file.`, expect(commandSkill).toBeDefined() const parsed = parseFrontmatter(commandSkill!.content) - // .claude/ paths should be rewritten to .codex/ - expect(parsed.body).toContain(".codex/compound-engineering.local.md") - expect(parsed.body).not.toContain(".claude/compound-engineering.local.md") - - // Global path should be rewritten - expect(parsed.body).toContain("~/.codex/compound-engineering.local.md") - expect(parsed.body).not.toContain("~/.claude/compound-engineering.local.md") + // Tool-agnostic path in project root β€” no rewriting needed + expect(parsed.body).toContain("compound-engineering.local.md") }) test("rewrites .claude/ paths in agent skill bodies", () => { @@ -257,7 +252,7 @@ Run \`/compound-engineering-setup\` to create a settings file.`, { name: "config-reader", description: "Reads config", - body: "Read `.claude/compound-engineering.local.md` for config.", + body: "Read `compound-engineering.local.md` for config.", sourcePath: "/tmp/plugin/agents/config-reader.md", }, ], @@ -273,8 +268,8 @@ Run \`/compound-engineering-setup\` to create a settings file.`, expect(agentSkill).toBeDefined() const parsed = parseFrontmatter(agentSkill!.content) - expect(parsed.body).toContain(".codex/compound-engineering.local.md") - expect(parsed.body).not.toContain(".claude/compound-engineering.local.md") + // Tool-agnostic path in project root β€” no rewriting needed + expect(parsed.body).toContain("compound-engineering.local.md") }) test("truncates generated skill descriptions to Codex limits and single line", () => { diff --git a/tests/converter.test.ts b/tests/converter.test.ts index 227f8c7e..87d87aee 100644 --- a/tests/converter.test.ts +++ b/tests/converter.test.ts @@ -194,7 +194,7 @@ describe("convertClaudeToOpenCode", () => { { name: "review", description: "Review command", - body: `Read \`.claude/compound-engineering.local.md\` (project-level) or \`~/.claude/compound-engineering.local.md\` (global fallback). + body: `Read \`compound-engineering.local.md\` in the project root. If no settings file exists, auto-detect project type. @@ -213,13 +213,8 @@ Run \`/compound-engineering-setup\` to create a settings file.`, const template = bundle.config.command?.["review"]?.template ?? "" - // .claude/ paths should be rewritten to .opencode/ - expect(template).toContain(".opencode/compound-engineering.local.md") - expect(template).not.toContain(".claude/compound-engineering.local.md") - - // Global path should be rewritten - expect(template).toContain("~/.config/opencode/compound-engineering.local.md") - expect(template).not.toContain("~/.claude/compound-engineering.local.md") + // Tool-agnostic path in project root β€” no rewriting needed + expect(template).toContain("compound-engineering.local.md") }) test("rewrites .claude/ paths in agent bodies", () => { @@ -230,7 +225,7 @@ Run \`/compound-engineering-setup\` to create a settings file.`, { name: "test-agent", description: "Test agent", - body: "Read `.claude/compound-engineering.local.md` for config.", + body: "Read `compound-engineering.local.md` for config.", sourcePath: "/tmp/plugin/agents/test-agent.md", }, ], @@ -246,7 +241,7 @@ Run \`/compound-engineering-setup\` to create a settings file.`, const agentFile = bundle.agents.find((a) => a.name === "test-agent") expect(agentFile).toBeDefined() - expect(agentFile!.content).toContain(".opencode/compound-engineering.local.md") - expect(agentFile!.content).not.toContain(".claude/compound-engineering.local.md") + // Tool-agnostic path in project root β€” no rewriting needed + expect(agentFile!.content).toContain("compound-engineering.local.md") }) }) From e8c5a7df9e8d6a479245c4feab774db998fd21dc Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 08:58:03 -0800 Subject: [PATCH 14/16] Make /compound-engineering-setup interactive with auto-detect fast path Two paths: "Auto-configure" (one click, smart defaults) or "Customize" (pick stack, focus areas, review depth). Uses AskUserQuestion throughout. Co-Authored-By: Claude Opus 4.6 --- .../compound-engineering/commands/setup.md | 172 +++++++++++++----- 1 file changed, 127 insertions(+), 45 deletions(-) diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/commands/setup.md index 6031204f..9c3a6ee3 100644 --- a/plugins/compound-engineering/commands/setup.md +++ b/plugins/compound-engineering/commands/setup.md @@ -6,23 +6,31 @@ disable-model-invocation: true # Compound Engineering Setup -Create a `compound-engineering.local.md` settings file with review agent defaults for this project. +Interactive setup for `compound-engineering.local.md` β€” configures which agents run during `/workflows:review`. ## Step 1: Check Existing Config -Read `compound-engineering.local.md`. If it exists, display the current contents and use AskUserQuestion: +Read `compound-engineering.local.md`. If it exists, display current settings summary and use AskUserQuestion: -**Question:** "Settings file already exists. What would you like to do?" -**Options:** -1. **Regenerate with new defaults** β€” Overwrite with fresh auto-detected defaults -2. **View and edit** β€” Open the file for manual editing -3. **Cancel** β€” Keep current settings +``` +question: "Settings file already exists. What would you like to do?" +header: "Config" +options: + - label: "Reconfigure" + description: "Run the interactive setup again from scratch" + - label: "View current" + description: "Show the file contents, then stop" + - label: "Cancel" + description: "Keep current settings" +``` -If "View and edit": show the file contents and remind user to edit it directly. +If "View current": read and display the file, then stop. If "Cancel": stop. ## Step 2: Detect Project Type +Auto-detect the project stack: + ```bash test -f Gemfile && test -f config/routes.rb && echo "rails" || \ test -f Gemfile && echo "ruby" || \ @@ -33,63 +41,137 @@ test -f requirements.txt && echo "python" || \ echo "general" ``` -## Step 3: Write Settings File +Display what was detected, then ask: -Create `compound-engineering.local.md` using the Write tool with defaults for the detected project type: - -**Rails:** -```markdown ---- -review_agents: [kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] -plan_review_agents: [kieran-rails-reviewer, code-simplicity-reviewer] ---- +``` +question: "Detected {type} project. How would you like to configure?" +header: "Setup" +options: + - label: "Auto-configure (Recommended)" + description: "Use smart defaults for {type}. Done in one click." + - label: "Customize" + description: "Choose focus areas, review depth, and agents yourself." ``` -**Python:** -```markdown ---- -review_agents: [kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] -plan_review_agents: [kieran-python-reviewer, code-simplicity-reviewer] ---- +### If Auto-configure β†’ Skip to Step 5 with these defaults: + +**Rails:** `kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` +**Python:** `kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` +**TypeScript:** `kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` +**General:** `code-simplicity-reviewer, security-sentinel, performance-oracle, architecture-strategist` + +### If Customize β†’ Continue to Step 3 + +## Step 3: Confirm Stack (Customize path only) + +Use AskUserQuestion to confirm or override the detected stack: + +``` +question: "Which stack should we optimize for?" +header: "Stack" +options: + - label: "{detected_type} (Recommended)" + description: "Auto-detected from project files" + - label: "Rails" + description: "Ruby on Rails β€” adds DHH-style and Rails-specific reviewers" + - label: "Python" + description: "Python β€” adds Pythonic pattern reviewer" + - label: "TypeScript" + description: "TypeScript β€” adds type safety reviewer" ``` -**TypeScript:** -```markdown ---- -review_agents: [kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle] -plan_review_agents: [kieran-typescript-reviewer, code-simplicity-reviewer] ---- +Only show options that differ from the detected type. + +## Step 4a: Choose Review Focus Areas (Customize path only) + +Use AskUserQuestion with multiSelect: + +``` +question: "Which review areas matter most for this project?" +header: "Focus" +multiSelect: true +options: + - label: "Security" + description: "Vulnerability scanning, auth, input validation (security-sentinel)" + - label: "Performance" + description: "N+1 queries, memory leaks, complexity (performance-oracle)" + - label: "Architecture" + description: "Design patterns, SOLID, separation of concerns (architecture-strategist)" + - label: "Code simplicity" + description: "Over-engineering, YAGNI violations (code-simplicity-reviewer)" ``` -**General:** -```markdown ---- -review_agents: [code-simplicity-reviewer, security-sentinel, performance-oracle] -plan_review_agents: [code-simplicity-reviewer, architecture-strategist] ---- +## Step 4b: Choose Review Depth (Customize path only) + +Use AskUserQuestion: + +``` +question: "How thorough should reviews be?" +header: "Depth" +options: + - label: "Thorough (Recommended)" + description: "Stack reviewers + all selected focus agents." + - label: "Fast" + description: "Stack reviewers + code simplicity only. Less context, quicker." + - label: "Comprehensive" + description: "All of the above + git history, data integrity, agent-native checks." ``` -Always append this body after the frontmatter: +## Step 5: Build Agent List and Write File + +Map selections to agents: + +**Stack-specific agents (always included):** +- Rails β†’ `kieran-rails-reviewer, dhh-rails-reviewer` +- Python β†’ `kieran-python-reviewer` +- TypeScript β†’ `kieran-typescript-reviewer` +- General β†’ (none) + +**Focus area agents (from Step 4a, or all four for auto-configure):** +- Security β†’ `security-sentinel` +- Performance β†’ `performance-oracle` +- Architecture β†’ `architecture-strategist` +- Code simplicity β†’ `code-simplicity-reviewer` + +**Depth extras (from Step 4b, or "Thorough" for auto-configure):** +- Thorough: stack + selected focus areas +- Fast: stack + `code-simplicity-reviewer` only +- Comprehensive: stack + all focus areas + `git-history-analyzer, data-integrity-guardian, agent-native-reviewer` + +**Plan review agents:** always use the stack-specific reviewer + `code-simplicity-reviewer`. + +Write `compound-engineering.local.md`: ```markdown +--- +review_agents: [{computed agent list}] +plan_review_agents: [{computed plan agent list}] +--- # Review Context Add project-specific review instructions here. -These notes are available to all review agents during /workflows:review. +These notes are passed to all review agents during /workflows:review and /workflows:work. + +Examples: +- "We use Turbo Frames heavily β€” check for frame-busting issues" +- "Our API is public β€” extra scrutiny on input validation" +- "Performance-critical: we serve 10k req/s on this endpoint" ``` -## Step 4: Confirm +## Step 6: Confirm -Display: +Display summary: ``` -Settings saved to compound-engineering.local.md +Saved to compound-engineering.local.md -Detected: {project_type} -Review agents: {agent list} -Plan review agents: {agent list} +Stack: {type} +Review depth: {depth} +Agents: {count} configured + {agent list, one per line} -Edit the file anytime to add/remove agents or add review context. -Run /workflows:review to use your configured agents. +Tip: Add project-specific instructions in the "Review Context" section. + Run /workflows:review to use your configured agents. + Re-run /compound-engineering-setup anytime to reconfigure. ``` From 532d0410bd08da2c25dfe87da318c252850c7f07 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 09:01:11 -0800 Subject: [PATCH 15/16] Replace /compound-engineering-setup command with setup skill Setup is now a skill invoked on-demand when compound-engineering.local.md doesn't exist. Review and work commands just say "invoke the setup skill" instead of inlining the full setup flow. - Remove commands/setup.md (command) - Add skills/setup/SKILL.md (skill with interactive AskUserQuestion flow) - Simplify review.md and work.md to reference the skill - Counts: 29 agents, 22 commands, 19 skills Co-Authored-By: Claude Opus 4.6 --- .claude-plugin/marketplace.json | 2 +- .../.claude-plugin/plugin.json | 2 +- .../commands/workflows/compound.md | 2 +- .../commands/workflows/review.md | 9 +-- .../commands/workflows/work.md | 9 +-- .../setup.md => skills/setup/SKILL.md} | 65 ++++++++----------- 6 files changed, 33 insertions(+), 56 deletions(-) rename plugins/compound-engineering/{commands/setup.md => skills/setup/SKILL.md} (63%) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 29139c15..013519b1 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -11,7 +11,7 @@ "plugins": [ { "name": "compound-engineering", - "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 23 commands, and 18 skills.", + "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 22 commands, and 19 skills.", "version": "2.32.2", "author": { "name": "Kieran Klaassen", diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index bd085ab8..003163d9 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "compound-engineering", "version": "2.32.2", - "description": "AI-powered development tools. 29 agents, 23 commands, 18 skills, 1 MCP server for code review, research, design, and workflow automation.", + "description": "AI-powered development tools. 29 agents, 22 commands, 19 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", "email": "kieran@every.to", diff --git a/plugins/compound-engineering/commands/workflows/compound.md b/plugins/compound-engineering/commands/workflows/compound.md index 062c449f..9dffc1a4 100644 --- a/plugins/compound-engineering/commands/workflows/compound.md +++ b/plugins/compound-engineering/commands/workflows/compound.md @@ -232,7 +232,7 @@ Based on problem type, these agents can enhance documentation: ### When to Invoke - **Auto-triggered** (optional): Agents can run post-documentation for enhancement - **Manual trigger**: User can invoke agents after /workflows:compound completes for deeper review -- **Customize agents**: Run `/compound-engineering-setup` to configure which review agents are used across all workflows +- **Customize agents**: Edit `compound-engineering.local.md` or invoke the `setup` skill to configure which review agents are used across all workflows ## Related Commands diff --git a/plugins/compound-engineering/commands/workflows/review.md b/plugins/compound-engineering/commands/workflows/review.md index 358c5816..d0ba78f4 100644 --- a/plugins/compound-engineering/commands/workflows/review.md +++ b/plugins/compound-engineering/commands/workflows/review.md @@ -63,14 +63,7 @@ If a review agent flags any file in these directories for cleanup or removal, di Read `compound-engineering.local.md` in the project root. If found, use `review_agents` from YAML frontmatter. If the markdown body contains review context, pass it to each agent as additional instructions. -If no settings file exists, auto-detect project type and use defaults: - -- **Rails** (Gemfile + config/routes.rb): kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle -- **Python** (pyproject.toml or requirements.txt): kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle -- **TypeScript** (tsconfig.json): kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle -- **General**: code-simplicity-reviewer, security-sentinel, performance-oracle - -Run `/compound-engineering-setup` to create a settings file with defaults. +If no settings file exists, invoke the `setup` skill to create one. Then read the newly created file and continue. #### Parallel Agents to review the PR: diff --git a/plugins/compound-engineering/commands/workflows/work.md b/plugins/compound-engineering/commands/workflows/work.md index 9f8f57ec..625889b6 100644 --- a/plugins/compound-engineering/commands/workflows/work.md +++ b/plugins/compound-engineering/commands/workflows/work.md @@ -175,17 +175,10 @@ This command takes a work document (plan, specification, or todo file) and execu 2. **Consider Reviewer Agents** (Optional) - Use for complex, risky, or large changes. Read agents from `compound-engineering.local.md` frontmatter (`review_agents`). If no settings file, auto-detect project type and use defaults: - - - **Rails**: kieran-rails-reviewer, code-simplicity-reviewer - - **Python**: kieran-python-reviewer, code-simplicity-reviewer - - **TypeScript**: kieran-typescript-reviewer, code-simplicity-reviewer - - **General**: code-simplicity-reviewer, security-sentinel + Use for complex, risky, or large changes. Read agents from `compound-engineering.local.md` frontmatter (`review_agents`). If no settings file, invoke the `setup` skill to create one. Run configured agents in parallel with Task tool. Present findings and address critical issues. - Run `/compound-engineering-setup` to configure which agents to use. - 3. **Final Validation** - All TodoWrite tasks marked completed - All tests pass diff --git a/plugins/compound-engineering/commands/setup.md b/plugins/compound-engineering/skills/setup/SKILL.md similarity index 63% rename from plugins/compound-engineering/commands/setup.md rename to plugins/compound-engineering/skills/setup/SKILL.md index 9c3a6ee3..239739a4 100644 --- a/plugins/compound-engineering/commands/setup.md +++ b/plugins/compound-engineering/skills/setup/SKILL.md @@ -1,16 +1,16 @@ --- -name: compound-engineering-setup -description: Configure review agents for your project +name: setup +description: Configure which review agents run for your project. Auto-detects stack and writes compound-engineering.local.md. disable-model-invocation: true --- # Compound Engineering Setup -Interactive setup for `compound-engineering.local.md` β€” configures which agents run during `/workflows:review`. +Interactive setup for `compound-engineering.local.md` β€” configures which agents run during `/workflows:review` and `/workflows:work`. ## Step 1: Check Existing Config -Read `compound-engineering.local.md`. If it exists, display current settings summary and use AskUserQuestion: +Read `compound-engineering.local.md` in the project root. If it exists, display current settings summary and use AskUserQuestion: ``` question: "Settings file already exists. What would you like to do?" @@ -27,7 +27,7 @@ options: If "View current": read and display the file, then stop. If "Cancel": stop. -## Step 2: Detect Project Type +## Step 2: Detect and Ask Auto-detect the project stack: @@ -41,7 +41,7 @@ test -f requirements.txt && echo "python" || \ echo "general" ``` -Display what was detected, then ask: +Use AskUserQuestion: ``` question: "Detected {type} project. How would you like to configure?" @@ -50,21 +50,21 @@ options: - label: "Auto-configure (Recommended)" description: "Use smart defaults for {type}. Done in one click." - label: "Customize" - description: "Choose focus areas, review depth, and agents yourself." + description: "Choose stack, focus areas, and review depth." ``` -### If Auto-configure β†’ Skip to Step 5 with these defaults: +### If Auto-configure β†’ Skip to Step 4 with defaults: -**Rails:** `kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` -**Python:** `kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` -**TypeScript:** `kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle` -**General:** `code-simplicity-reviewer, security-sentinel, performance-oracle, architecture-strategist` +- **Rails:** `[kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]` +- **Python:** `[kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]` +- **TypeScript:** `[kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]` +- **General:** `[code-simplicity-reviewer, security-sentinel, performance-oracle, architecture-strategist]` -### If Customize β†’ Continue to Step 3 +### If Customize β†’ Step 3 -## Step 3: Confirm Stack (Customize path only) +## Step 3: Customize (3 questions) -Use AskUserQuestion to confirm or override the detected stack: +**a. Stack** β€” confirm or override: ``` question: "Which stack should we optimize for?" @@ -82,12 +82,10 @@ options: Only show options that differ from the detected type. -## Step 4a: Choose Review Focus Areas (Customize path only) - -Use AskUserQuestion with multiSelect: +**b. Focus areas** β€” multiSelect: ``` -question: "Which review areas matter most for this project?" +question: "Which review areas matter most?" header: "Focus" multiSelect: true options: @@ -101,9 +99,7 @@ options: description: "Over-engineering, YAGNI violations (code-simplicity-reviewer)" ``` -## Step 4b: Choose Review Depth (Customize path only) - -Use AskUserQuestion: +**c. Depth:** ``` question: "How thorough should reviews be?" @@ -114,31 +110,29 @@ options: - label: "Fast" description: "Stack reviewers + code simplicity only. Less context, quicker." - label: "Comprehensive" - description: "All of the above + git history, data integrity, agent-native checks." + description: "All above + git history, data integrity, agent-native checks." ``` -## Step 5: Build Agent List and Write File - -Map selections to agents: +## Step 4: Build Agent List and Write File -**Stack-specific agents (always included):** +**Stack-specific agents:** - Rails β†’ `kieran-rails-reviewer, dhh-rails-reviewer` - Python β†’ `kieran-python-reviewer` - TypeScript β†’ `kieran-typescript-reviewer` - General β†’ (none) -**Focus area agents (from Step 4a, or all four for auto-configure):** +**Focus area agents:** - Security β†’ `security-sentinel` - Performance β†’ `performance-oracle` - Architecture β†’ `architecture-strategist` - Code simplicity β†’ `code-simplicity-reviewer` -**Depth extras (from Step 4b, or "Thorough" for auto-configure):** +**Depth:** - Thorough: stack + selected focus areas - Fast: stack + `code-simplicity-reviewer` only -- Comprehensive: stack + all focus areas + `git-history-analyzer, data-integrity-guardian, agent-native-reviewer` +- Comprehensive: all above + `git-history-analyzer, data-integrity-guardian, agent-native-reviewer` -**Plan review agents:** always use the stack-specific reviewer + `code-simplicity-reviewer`. +**Plan review agents:** stack-specific reviewer + `code-simplicity-reviewer`. Write `compound-engineering.local.md`: @@ -159,9 +153,7 @@ Examples: - "Performance-critical: we serve 10k req/s on this endpoint" ``` -## Step 6: Confirm - -Display summary: +## Step 5: Confirm ``` Saved to compound-engineering.local.md @@ -171,7 +163,6 @@ Review depth: {depth} Agents: {count} configured {agent list, one per line} -Tip: Add project-specific instructions in the "Review Context" section. - Run /workflows:review to use your configured agents. - Re-run /compound-engineering-setup anytime to reconfigure. +Tip: Edit the "Review Context" section to add project-specific instructions. + Re-run this setup anytime to reconfigure. ``` From be091a9644488f37c269c69e9e343930502bed82 Mon Sep 17 00:00:00 2001 From: Kieran Klaassen Date: Thu, 12 Feb 2026 09:41:52 -0800 Subject: [PATCH 16/16] Prepare v2.33.0 release: setup skill, configurable review agents - Bump version to 2.33.0 - Consolidate CHANGELOG entries for this branch - Fix README: update counts (29/22/19), add setup + resolve-pr-parallel skills - Remove stale /compound-engineering-setup command reference Co-Authored-By: Claude Opus 4.6 --- .claude-plugin/marketplace.json | 2 +- .../.claude-plugin/plugin.json | 2 +- plugins/compound-engineering/CHANGELOG.md | 26 +++++++------------ plugins/compound-engineering/README.md | 8 +++--- 4 files changed, 17 insertions(+), 21 deletions(-) diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 013519b1..563dfcd8 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -12,7 +12,7 @@ { "name": "compound-engineering", "description": "AI-powered development tools that get smarter with every use. Make each unit of engineering work easier than the last. Includes 29 specialized agents, 22 commands, and 19 skills.", - "version": "2.32.2", + "version": "2.33.0", "author": { "name": "Kieran Klaassen", "url": "https://github.com/kieranklaassen", diff --git a/plugins/compound-engineering/.claude-plugin/plugin.json b/plugins/compound-engineering/.claude-plugin/plugin.json index 003163d9..a74039ac 100644 --- a/plugins/compound-engineering/.claude-plugin/plugin.json +++ b/plugins/compound-engineering/.claude-plugin/plugin.json @@ -1,6 +1,6 @@ { "name": "compound-engineering", - "version": "2.32.2", + "version": "2.33.0", "description": "AI-powered development tools. 29 agents, 22 commands, 19 skills, 1 MCP server for code review, research, design, and workflow automation.", "author": { "name": "Kieran Klaassen", diff --git a/plugins/compound-engineering/CHANGELOG.md b/plugins/compound-engineering/CHANGELOG.md index 0537f59f..b80621c6 100644 --- a/plugins/compound-engineering/CHANGELOG.md +++ b/plugins/compound-engineering/CHANGELOG.md @@ -5,33 +5,27 @@ All notable changes to the compound-engineering plugin will be documented in thi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## [2.32.2] - 2026-02-12 - -### Changed - -- **`/release-docs` command** β€” Moved from plugin to local `.claude/commands/` since it's a repo maintenance command, not something distributed to plugin users. Plugin command count: 24 β†’ 23. - ---- - -## [2.32.1] - 2026-02-12 +## [2.33.0] - 2026-02-12 ### Added -- **`/compound-engineering-setup` command** β€” Configure which review agents run for your project +- **`setup` skill** β€” Interactive configurator for review agents - Auto-detects project type (Rails, Python, TypeScript, etc.) - - Creates `.compound-engineering.local.md` with smart defaults - - Uses plugin-settings pattern (YAML frontmatter + markdown body for review context) -- **`schema-drift-detector` wired into `/workflows:review`** β€” Detects unrelated schema.rb changes in PRs with migrations + - Two paths: "Auto-configure" (one click) or "Customize" (pick stack, focus areas, depth) + - Writes `compound-engineering.local.md` in project root (tool-agnostic β€” works for Claude, Codex, OpenCode) + - Invoked automatically by `/workflows:review` when no settings file exists +- **`learnings-researcher` in `/workflows:review`** β€” Always-run agent that searches `docs/solutions/` for past issues related to the PR +- **`schema-drift-detector` wired into `/workflows:review`** β€” Conditional agent for PRs with migrations ### Changed -- **`/workflows:review` command** β€” Now reads review agents from settings file, falls back to auto-detected defaults. Added `learnings-researcher` agent to always-run list to surface past solutions during review. +- **`/workflows:review`** β€” Now reads review agents from `compound-engineering.local.md` settings file. Falls back to invoking setup skill if no file exists. - **`/workflows:work`** β€” Review agents now configurable via settings file -- **`/workflows:compound`** β€” Added reference to `/compound-engineering-setup` for agent customization +- **`/release-docs` command** β€” Moved from plugin to local `.claude/commands/` (repo maintenance, not distributed) ### Removed -- **`/technical_review` command** β€” Superseded by `/plan_review` skill +- **`/technical_review` command** β€” Superseded by configurable review agents --- diff --git a/plugins/compound-engineering/README.md b/plugins/compound-engineering/README.md index ac2b0672..ec1ad83b 100644 --- a/plugins/compound-engineering/README.md +++ b/plugins/compound-engineering/README.md @@ -7,8 +7,8 @@ AI-powered development tools that get smarter with every use. Make each unit of | Component | Count | |-----------|-------| | Agents | 29 | -| Commands | 25 | -| Skills | 16 | +| Commands | 22 | +| Skills | 19 | | MCP Servers | 1 | ## Agents @@ -94,7 +94,7 @@ Core workflow commands use `workflows:` prefix to avoid collisions with built-in | `/create-agent-skill` | Create or edit Claude Code skills | | `/generate_command` | Generate new slash commands | | `/heal-skill` | Fix skill documentation issues | -| `/compound-engineering-setup` | Configure review agents for your project | +| `/sync` | Sync Claude Code config across machines | | `/report-bug` | Report a bug in the plugin | | `/reproduce-bug` | Reproduce bugs using logs and console | | `/resolve_parallel` | Resolve TODO comments in parallel | @@ -134,6 +134,8 @@ Core workflow commands use `workflows:` prefix to avoid collisions with built-in | `every-style-editor` | Review copy for Every's style guide compliance | | `file-todos` | File-based todo tracking system | | `git-worktree` | Manage Git worktrees for parallel development | +| `resolve-pr-parallel` | Resolve PR review comments in parallel | +| `setup` | Configure which review agents run for your project | ### Multi-Agent Orchestration