Skip to content

Commit e6d2377

Browse files
committed
Redis Cluster: keysPattern -> keyPattern
1 parent e4d96c6 commit e6d2377

File tree

5 files changed

+40
-40
lines changed

5 files changed

+40
-40
lines changed

driver/src/main/java/jdbc/client/helpers/query/parser/QueryParser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ private QueryParser() {
120120
// keys pattern queries
121121
if (command == Command.KEYS) {
122122
String pattern = getFirst(params);
123-
return new RedisKeysPatternQuery(compositeCommand, params, pattern, columnHint, nodeHint, isBlocking);
123+
return new RedisKeyPatternQuery(compositeCommand, params, pattern, columnHint, nodeHint, isBlocking);
124124
}
125125
if (command == Command.SCAN) {
126126
Integer matchIndex = getIndex(params, p -> Keyword.MATCH.name().equalsIgnoreCase(p));
127127
String pattern = matchIndex == null || matchIndex == params.length - 1 ? null : params[matchIndex + 1];
128-
return new RedisKeysPatternQuery(compositeCommand, params, pattern, columnHint, nodeHint, isBlocking);
128+
return new RedisKeyPatternQuery(compositeCommand, params, pattern, columnHint, nodeHint, isBlocking);
129129
}
130130

131131
return new RedisQuery(compositeCommand, params, columnHint, nodeHint, BLOCKING_COMMANDS.contains(command));

driver/src/main/java/jdbc/client/impl/RedisClientBase.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import jdbc.client.RedisClient;
44
import jdbc.client.helpers.query.RedisQueryHelper;
55
import jdbc.client.helpers.result.RedisResultHelper;
6-
import jdbc.client.structures.query.RedisKeysPatternQuery;
6+
import jdbc.client.structures.query.RedisKeyPatternQuery;
77
import jdbc.client.structures.query.RedisQuery;
88
import jdbc.client.structures.query.RedisSetDatabaseQuery;
99
import jdbc.client.structures.result.RedisResult;
@@ -30,7 +30,7 @@ public final RedisResult execute(String sql) throws SQLException {
3030

3131
public Object execute(@NotNull RedisQuery query) throws SQLException {
3232
if (query instanceof RedisSetDatabaseQuery) return executeImpl((RedisSetDatabaseQuery) query);
33-
if (query instanceof RedisKeysPatternQuery) return executeImpl((RedisKeysPatternQuery) query);
33+
if (query instanceof RedisKeyPatternQuery) return executeImpl((RedisKeyPatternQuery) query);
3434
return executeImpl(query);
3535
}
3636

@@ -39,7 +39,7 @@ private Object executeImpl(@NotNull RedisSetDatabaseQuery query) {
3939
return setDatabase(query.getDbIndex());
4040
}
4141

42-
protected Object executeImpl(@NotNull RedisKeysPatternQuery query) throws SQLException {
42+
protected Object executeImpl(@NotNull RedisKeyPatternQuery query) throws SQLException {
4343
return executeImpl((RedisQuery) query);
4444
}
4545

driver/src/main/java/jdbc/client/impl/cluster/RedisJedisClusterClient.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import jdbc.client.impl.RedisJedisURIBase.CompleteHostAndPortMapper;
66
import jdbc.client.impl.standalone.RedisJedisClient;
77
import jdbc.client.structures.query.NodeHint;
8-
import jdbc.client.structures.query.RedisKeysPatternQuery;
8+
import jdbc.client.structures.query.RedisKeyPatternQuery;
99
import jdbc.client.structures.query.RedisQuery;
1010
import org.jetbrains.annotations.NotNull;
1111
import org.jetbrains.annotations.Nullable;
@@ -74,14 +74,14 @@ private synchronized Object execute(@NotNull HostAndPort nodeHostAndPort,
7474

7575

7676
@Override
77-
protected Object executeImpl(@NotNull RedisKeysPatternQuery query) throws SQLException {
77+
protected Object executeImpl(@NotNull RedisKeyPatternQuery query) throws SQLException {
7878
checkSupportInClusterMode(query);
7979
return super.executeImpl(query);
8080
}
8181

82-
private static void checkSupportInClusterMode(@NotNull RedisKeysPatternQuery query) throws SQLException {
83-
String keysPattern = query.getKeysPattern();
84-
if (keysPattern == null || !JedisClusterHashTag.isClusterCompliantMatchPattern(keysPattern))
82+
private static void checkSupportInClusterMode(@NotNull RedisKeyPatternQuery query) throws SQLException {
83+
String keyPattern = query.getKeyPattern();
84+
if (keyPattern == null || !JedisClusterHashTag.isClusterCompliantMatchPattern(keyPattern))
8585
throw new SQLException(String.format("Cluster mode only supports %s command"
8686
+ " with pattern containing hash-tag ( curly-brackets enclosed string )", query.getCommand()));
8787
}
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package jdbc.client.structures.query;
2+
3+
import org.jetbrains.annotations.NotNull;
4+
import org.jetbrains.annotations.Nullable;
5+
6+
public class RedisKeyPatternQuery extends RedisQuery {
7+
8+
private final String keyPattern;
9+
10+
public RedisKeyPatternQuery(@NotNull CompositeCommand compositeCommand,
11+
@NotNull String[] params,
12+
@Nullable String keyPattern,
13+
@Nullable ColumnHint columnHint,
14+
@Nullable NodeHint nodeHint,
15+
boolean isBlocking) {
16+
super(compositeCommand, params, columnHint, nodeHint, isBlocking);
17+
this.keyPattern = keyPattern;
18+
}
19+
20+
@Nullable
21+
public String getKeyPattern() {
22+
return keyPattern;
23+
}
24+
25+
@Nullable
26+
@Override
27+
public String getSampleKey() {
28+
return keyPattern;
29+
}
30+
}

driver/src/main/java/jdbc/client/structures/query/RedisKeysPatternQuery.java

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)