-
Notifications
You must be signed in to change notification settings - Fork 319
Update Config Inversion Linter to Handle V2 supported-configurations.json Format
#10061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052955
Total [baseline] (8.677 s) : 0, 8677281
Agent [candidate] (1.054 s) : 0, 1054481
Total [candidate] (8.687 s) : 0, 8686761
section iast
Agent [baseline] (1.194 s) : 0, 1194177
Total [baseline] (9.375 s) : 0, 9375277
Agent [candidate] (1.199 s) : 0, 1199052
Total [candidate] (9.342 s) : 0, 9342253
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.496 ms) : 0, 1496
BytebuddyAgent [baseline] (708.26 ms) : 0, 708260
BytebuddyAgent [candidate] (708.996 ms) : 0, 708996
GlobalTracer [baseline] (248.835 ms) : 0, 248835
GlobalTracer [candidate] (249.502 ms) : 0, 249502
AppSec [baseline] (32.006 ms) : 0, 32006
AppSec [candidate] (32.084 ms) : 0, 32084
Debugger [baseline] (6.347 ms) : 0, 6347
Debugger [candidate] (6.399 ms) : 0, 6399
Remote Config [baseline] (680.762 µs) : 0, 681
Remote Config [candidate] (672.78 µs) : 0, 673
Telemetry [baseline] (16.235 ms) : 0, 16235
Telemetry [candidate] (16.381 ms) : 0, 16381
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.038 ms) : 0, 4038
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (832.198 ms) : 0, 832198
BytebuddyAgent [candidate] (838.049 ms) : 0, 838049
GlobalTracer [baseline] (238.299 ms) : 0, 238299
GlobalTracer [candidate] (238.199 ms) : 0, 238199
IAST [baseline] (33.696 ms) : 0, 33696
IAST [candidate] (32.566 ms) : 0, 32566
AppSec [baseline] (28.02 ms) : 0, 28020
AppSec [candidate] (28.547 ms) : 0, 28547
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.046 ms) : 0, 6046
Remote Config [baseline] (619.574 µs) : 0, 620
Remote Config [candidate] (604.792 µs) : 0, 605
Telemetry [baseline] (8.024 ms) : 0, 8024
Telemetry [candidate] (7.908 ms) : 0, 7908
Flare Poller [baseline] (10.876 ms) : 0, 10876
Flare Poller [candidate] (10.797 ms) : 0, 10797
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051288
Total [baseline] (10.753 s) : 0, 10752994
Agent [candidate] (1.053 s) : 0, 1052589
Total [candidate] (10.958 s) : 0, 10957789
section appsec
Agent [baseline] (1.242 s) : 0, 1241613
Total [baseline] (10.991 s) : 0, 10991054
Agent [candidate] (1.236 s) : 0, 1235828
Total [candidate] (10.879 s) : 0, 10879040
section iast
Agent [baseline] (1.195 s) : 0, 1194935
Total [baseline] (11.208 s) : 0, 11208497
Agent [candidate] (1.198 s) : 0, 1198421
Total [candidate] (11.165 s) : 0, 11164666
section profiling
Agent [baseline] (1.2 s) : 0, 1200001
Total [baseline] (10.881 s) : 0, 10881091
Agent [candidate] (1.206 s) : 0, 1206107
Total [candidate] (10.984 s) : 0, 10983666
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (706.349 ms) : 0, 706349
BytebuddyAgent [candidate] (707.403 ms) : 0, 707403
GlobalTracer [baseline] (249.239 ms) : 0, 249239
GlobalTracer [candidate] (249.317 ms) : 0, 249317
AppSec [baseline] (31.939 ms) : 0, 31939
AppSec [candidate] (32.007 ms) : 0, 32007
Debugger [baseline] (6.393 ms) : 0, 6393
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (674.479 µs) : 0, 674
Remote Config [candidate] (676.499 µs) : 0, 676
Telemetry [baseline] (16.195 ms) : 0, 16195
Telemetry [candidate] (15.608 ms) : 0, 15608
Flare Poller [baseline] (4.152 ms) : 0, 4152
Flare Poller [candidate] (4.844 ms) : 0, 4844
section appsec
crashtracking [baseline] (1.505 ms) : 0, 1505
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (740.738 ms) : 0, 740738
BytebuddyAgent [candidate] (735.936 ms) : 0, 735936
GlobalTracer [baseline] (244.265 ms) : 0, 244265
GlobalTracer [candidate] (242.853 ms) : 0, 242853
IAST [baseline] (25.188 ms) : 0, 25188
IAST [candidate] (25.158 ms) : 0, 25158
AppSec [baseline] (175.384 ms) : 0, 175384
AppSec [candidate] (175.967 ms) : 0, 175967
Debugger [baseline] (6.332 ms) : 0, 6332
Debugger [candidate] (6.325 ms) : 0, 6325
Remote Config [baseline] (693.144 µs) : 0, 693
Remote Config [candidate] (691.483 µs) : 0, 691
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (8.181 ms) : 0, 8181
Flare Poller [baseline] (4.005 ms) : 0, 4005
Flare Poller [candidate] (4.048 ms) : 0, 4048
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (832.524 ms) : 0, 832524
BytebuddyAgent [candidate] (834.872 ms) : 0, 834872
GlobalTracer [baseline] (238.868 ms) : 0, 238868
GlobalTracer [candidate] (239.417 ms) : 0, 239417
IAST [baseline] (32.554 ms) : 0, 32554
IAST [candidate] (30.509 ms) : 0, 30509
AppSec [baseline] (29.087 ms) : 0, 29087
AppSec [candidate] (31.538 ms) : 0, 31538
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.086 ms) : 0, 6086
Remote Config [baseline] (622.695 µs) : 0, 623
Remote Config [candidate] (607.839 µs) : 0, 608
Telemetry [baseline] (8.049 ms) : 0, 8049
Telemetry [candidate] (8.04 ms) : 0, 8040
Flare Poller [baseline] (10.835 ms) : 0, 10835
Flare Poller [candidate] (10.877 ms) : 0, 10877
section profiling
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (735.573 ms) : 0, 735573
BytebuddyAgent [candidate] (739.288 ms) : 0, 739288
GlobalTracer [baseline] (222.661 ms) : 0, 222661
GlobalTracer [candidate] (223.549 ms) : 0, 223549
AppSec [baseline] (32.006 ms) : 0, 32006
AppSec [candidate] (32.393 ms) : 0, 32393
Debugger [baseline] (8.37 ms) : 0, 8370
Debugger [candidate] (8.344 ms) : 0, 8344
Remote Config [baseline] (687.163 µs) : 0, 687
Remote Config [candidate] (1.447 ms) : 0, 1447
Telemetry [baseline] (14.814 ms) : 0, 14814
Telemetry [candidate] (14.042 ms) : 0, 14042
Flare Poller [baseline] (4.181 ms) : 0, 4181
Flare Poller [candidate] (4.17 ms) : 0, 4170
ProfilingAgent [baseline] (111.026 ms) : 0, 111026
ProfilingAgent [candidate] (111.763 ms) : 0, 111763
Profiling [baseline] (111.663 ms) : 0, 111663
Profiling [candidate] (112.41 ms) : 0, 112410
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section baseline
no_agent (18.23 ms) : 18040, 18420
. : milestone, 18230,
appsec (19.676 ms) : 19472, 19880
. : milestone, 19676,
code_origins (17.851 ms) : 17675, 18027
. : milestone, 17851,
iast (17.627 ms) : 17452, 17802
. : milestone, 17627,
profiling (19.439 ms) : 19242, 19636
. : milestone, 19439,
tracing (17.327 ms) : 17155, 17500
. : milestone, 17327,
section candidate
no_agent (18.185 ms) : 18000, 18370
. : milestone, 18185,
appsec (19.853 ms) : 19653, 20052
. : milestone, 19853,
code_origins (17.774 ms) : 17599, 17948
. : milestone, 17774,
iast (17.795 ms) : 17616, 17975
. : milestone, 17795,
profiling (18.42 ms) : 18237, 18603
. : milestone, 18420,
tracing (17.592 ms) : 17420, 17764
. : milestone, 17592,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1212
. : milestone, 1201,
iast (3.29 ms) : 3244, 3336
. : milestone, 3290,
iast_FULL (5.801 ms) : 5742, 5859
. : milestone, 5801,
iast_GLOBAL (3.724 ms) : 3669, 3779
. : milestone, 3724,
profiling (2.035 ms) : 2018, 2052
. : milestone, 2035,
tracing (1.823 ms) : 1808, 1838
. : milestone, 1823,
section candidate
no_agent (1.246 ms) : 1234, 1258
. : milestone, 1246,
iast (3.226 ms) : 3184, 3267
. : milestone, 3226,
iast_FULL (5.887 ms) : 5827, 5947
. : milestone, 5887,
iast_GLOBAL (3.799 ms) : 3749, 3848
. : milestone, 3799,
profiling (2.01 ms) : 1993, 2027
. : milestone, 2010,
tracing (1.885 ms) : 1869, 1901
. : milestone, 1885,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1498
. : milestone, 1487,
appsec (2.495 ms) : 2442, 2548
. : milestone, 2495,
iast (2.235 ms) : 2169, 2301
. : milestone, 2235,
iast_GLOBAL (2.287 ms) : 2220, 2353
. : milestone, 2287,
profiling (2.101 ms) : 2047, 2155
. : milestone, 2101,
tracing (2.077 ms) : 2025, 2129
. : milestone, 2077,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.5 ms) : 2447, 2552
. : milestone, 2500,
iast (2.237 ms) : 2172, 2303
. : milestone, 2237,
iast_GLOBAL (2.287 ms) : 2220, 2353
. : milestone, 2287,
profiling (2.08 ms) : 2027, 2133
. : milestone, 2080,
tracing (2.067 ms) : 2016, 2119
. : milestone, 2067,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~82b3c8c7bf, baseline=1.57.0-SNAPSHOT~09eedf137d
dateFormat X
axisFormat %s
section baseline
no_agent (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
appsec (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
iast (18.051 s) : 18051000, 18051000
. : milestone, 18051000,
iast_GLOBAL (17.83 s) : 17830000, 17830000
. : milestone, 17830000,
profiling (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
tracing (14.656 s) : 14656000, 14656000
. : milestone, 14656000,
section candidate
no_agent (15.36 s) : 15360000, 15360000
. : milestone, 15360000,
appsec (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
iast (18.406 s) : 18406000, 18406000
. : milestone, 18406000,
iast_GLOBAL (18.165 s) : 18165000, 18165000
. : milestone, 18165000,
profiling (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
tracing (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
What Does This Do
This PR updates the Config Inversion Linter Gradle tasks to handle the V2 format for the local
supported-configurations.jsonfile. Previously, it used theSetof supported configurations fromGeneratedSupportedConfigurations.javato verify that Environment Strings and Configuration definitions were documented in thesupported-configurations.json. However, #10060 changes the generated file to store a Map instead of a Set. This PR handles both the V1 format and V2 format by accepting both aSetandMapfrom the generated file.This PR also adds caching for the data fetched from the generated class instead of executing that logic in all tasks that need the data.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]