⚗ use deterministic session ids when possible #4003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR changes the way we generate UUIDs so session ids are no longer random, but based on a seed that combines the 15-minute period of time the session was create, the app id and the anonymous user id.
This way, any session created in the same device within this 15 minutes time divisions would have the exact same id. As such, if any of the conditions that cause sessions to be terminated and created rapidly happens, all the microsessions would have a constant id, in practice consolidating them as a single session.
Changes
This PR changes how we generate UUIDs: When anonymous_id and app_id are available, we generate the UUID based on them. If they are not available, we still generate a random id.
Test instructions
expirevalue to 0 and then reloading the page: Don't delete the cookie or use the extension to kill the session, since this would delete the anonymous_id and change the generated session id)Checklist