Skip to content

Possible unsound public API at 0.0.4 #7

@charlesxsh

Description

@charlesxsh

At src/support/mod.rs

impl<T> SyncRawPtr<T>{
    ...
    pub fn offset(&mut self,value:isize){
        unsafe{
            self.ptr=self.ptr.offset(value);
        }
    }
....


impl<T> SyncRawMutPtr<T>{
    ...
    pub fn offset(&mut self,value:isize){
        unsafe{
            self.ptr=self.ptr.offset(value);
        }
    }

Both struct and their methods offset are publicly accessible, but lack of sufficient checks for parameter value, which might cause memory risks under complete safe API. In rust, we are not expecting memory issues by merely using safe API.

Suggestion:

  1. Make sure such issues not exist in the latest version
  2. If does, it is good to mark them with unsafe or having enough checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions