-
Notifications
You must be signed in to change notification settings - Fork 3
Check if downloading sample data is stable #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lewisjared When I run the download script on my laptop the NetCDF files are shown as changed including the hashes in registry.txt (my hashes look the same as what is shown here in CI). However, I couldn't find any difference when comparing the NetCDF files using |
|
I wonder if there are subtle difference depending on which data node the files are coming from... I'm assuming my closest data node will be different to you. I'll try deleting my existing data and see if that resolves things. |
|
I'm also on a mac which might play a role in this. I wonder if we need to make the CI the source of truth for the outputs. My local versions of netCDF |
|
/regenerate |
3 similar comments
|
/regenerate |
|
/regenerate |
|
/regenerate |
* main: chore: Update action permissions chore: Fix action runs_on chore: Fix action docs: Changelog chore: Remove checking the actual results for now feat: Add action to regenerate on command feat: Add action for regenerating the sample data
|
/regenerate |
|
/regenerate |
|
/regenerate |
1 similar comment
|
/regenerate |
|
PR comment handling Details: https://github.com/CMIP-REF/ref-sample-data/actions/runs/12879272828 |
|
/regenerate |
|
PR comment handling You can find the workflow here: |
|
@bouweandela Sorry for the spam, but I was testing the regeneration functionality on a forked branch. I'll close this and make a clean PR |
|
Closing in preference for #8 |
|
I appear to have slightly different versions of the software: Did I do the environment synchronization correctly? Maybe it is indeed because I'm Linux and you're on Mac. |
|
Yes. The python dependencies are the same. I'm not sure where the netCDF and hdf libraries are bundled in from. Your values match ther results from the CI which is a good sign. |
Description
Checklist
Please confirm that this pull request has done the following:
changelog/