Optional dynamic environment map manager #13077
Open
+42
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds option to prevent creation of DynamicEnvironmentMapManager in Cesium3DTileset. This lets cesium run without requiring ownership of a webgl context, resulting in the ability to use cesium 'headless' without a graphical output. I have used this modification to successfully integrate babylonjs as a rendering engine for tiles. https://community.cesium.com/t/accomplished-rendering-with-babylonjs-single-webgl-context/44464
Testing plan
https://github.com/techtruth/cesium_in_babylon/blob/mars/src/cesium_derived/CesiumTilesetDerived.js
Tested above in the demo: https://jamescroney.com/demo/cesiumbabylon
Added unit tests for checking if DynamicEnvironmentMapManager with and without the option enabled.
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change