refatorar duplicações

Author: Bulletdev

internal/handlers/product_handler_test.go

@@ -8,6 +8,7 @@ import (
 	"bullet-cloud-api/internal/users" // For user mock
 	"context"
 	"errors"
+	"io"
 	"net/http"
 	"net/http/httptest"
 	"strings"
@@ -278,17 +279,22 @@ func TestProductHandler_CreateProduct(t *testing.T) {
 					}, tc.mockCreateErr).Once()
 			}
 
-			req := httptest.NewRequest(http.MethodPost, "/api/products", strings.NewReader(tc.body))
-			req.Header.Set("Content-Type", "application/json")
+			// --- Request Execution & Assertion ---
+			var reqBody io.Reader
+			if tc.body != "" {
+				reqBody = strings.NewReader(tc.body)
+			}
+
+			// Determine token for the helper
+			currentToken := ""
 			if tc.expectedStatus != http.StatusUnauthorized || tc.expectedBody != `{"error":"authorization header required"}` {
-				req.Header.Set("Authorization", "Bearer "+testToken)
+				currentToken = testToken // Use the globally defined testToken for this test function
 			}
-			rr := httptest.NewRecorder()
 
-			router.ServeHTTP(rr, req)
+			// Use the helper function
+			executeRequestAndAssert(t, router, http.MethodPost, "/api/products", currentToken, reqBody, tc.expectedStatus, tc.expectedBody)
 
-			assert.Equal(t, tc.expectedStatus, rr.Code)
-			assert.Contains(t, rr.Body.String(), tc.expectedBody)
+			// Assert mock expectations (still needed here)
 			mockUserRepo.AssertExpectations(t)
 			mockProductRepo.AssertExpectations(t)
 		})

internal/handlers/test_helpers_test.go

@@ -3,11 +3,15 @@ package handlers_test
 import (
 	"bullet-cloud-api/internal/auth"
 	"bullet-cloud-api/internal/users"
+	"io"
+	"net/http"
+	"net/http/httptest"
 	"testing"
 	"time"
 
 	"github.com/google/uuid"
 	"github.com/gorilla/mux"
+	"github.com/stretchr/testify/assert"
 )
 
 // --- Common Test Setup --- //
@@ -37,3 +41,34 @@ func generateTestToken(userID uuid.UUID, secret string) string {
 	}
 	return token
 }
+
+// executeRequestAndAssert performs the common steps of:
+// 1. Creating an HTTP request.
+// 2. Setting JSON Content-Type and optional Authorization headers.
+// 3. Executing the request against the provided router.
+// 4. Asserting the response status code.
+// 5. Asserting that the response body contains the expected substring.
+func executeRequestAndAssert(t *testing.T, router *mux.Router, method, url, token string, body io.Reader, expectedStatus int, expectedBodyContains string) {
+	req, err := http.NewRequest(method, url, body)
+	assert.NoError(t, err, "Failed to create request")
+
+	req.Header.Set("Content-Type", "application/json")
+	if token != "" {
+		req.Header.Set("Authorization", "Bearer "+token)
+	}
+
+	rr := httptest.NewRecorder()
+	router.ServeHTTP(rr, req)
+
+	assert.Equal(t, expectedStatus, rr.Code, "Status code mismatch for %s %s", method, url)
+
+	if expectedBodyContains != "" {
+		assert.Contains(t, rr.Body.String(), expectedBodyContains, "Response body mismatch for %s %s", method, url)
+	} else if expectedStatus < 300 { // Only assert empty body for non-redirect/non-error success cases if expectedBodyContains is empty
+		// Special case for 204 No Content or similar where empty body is expected
+		if rr.Code == http.StatusNoContent {
+			assert.Empty(t, rr.Body.String(), "Body should be empty for 204 No Content on %s %s", method, url)
+		} // Other success cases might have bodies (like 200 OK returning an object)
+		// We rely on expectedBodyContains for those. If it's empty, we don't assert emptiness for 200/201.
+	}
+}