-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Version: 25.8.13.10194.altinitystable
Description
The Iceberg regression tests fail in show_databases_queries due to an assertion expecting identical SHOW DATABASES output with show_data_lake_catalogs_in_system_tables enabled and disabled.
When the setting is enabled, the Iceberg catalog database appears in the result; when disabled, it does not, causing the assertion to fail.
Query with setting enabled
SET show_data_lake_catalogs_in_system_tables = 1;
SHOW DATABASES;Result:
INFORMATION_SCHEMA
default
iceberg_database_name
information_schema
system
Query with setting disabled
SET show_data_lake_catalogs_in_system_tables = 0;
SHOW DATABASES;Result:
INFORMATION_SCHEMA
default
information_schema
system
Analysis
The failure occurs in the Iceberg show_databases_queries scenario, which explicitly sets show_data_lake_catalogs_in_system_tables to both 1 and 0 and asserts that the output of SHOW DATABASES is identical in both cases.
This behavior is related to the upstream issue #89189, which was addressed by PR #89914. That PR ensures that Iceberg / DataLakeCatalog databases are consistently shown in SHOW DATABASES, regardless of the value of show_data_lake_catalogs_in_system_tables.
In the 25.8.13 build, PR #88341 was backported, but its follow-up fix PR #89914 was not. As a result, toggling the setting still affects the output of SHOW DATABASES, causing the test assertion to fail.
Therefore, the failure is not test-related, but due to a missing upstream fix in this release.
Resolution
Backport PR #89914 to the 25.8.13 branch to fully address issue #89189 and ensure that SHOW DATABASES behavior is consistent regardless of the show_data_lake_catalogs_in_system_tables setting.
Verification
Verify the backport of PR #89914 on 25.8 after re-running the Iceberg regression tests:
- 25.8 Stable – backport applied and Iceberg tests re-run
- 25.8 Antalya – backport applied and Iceberg tests re-run
CI Run
https://github.com/Altinity/ClickHouse/actions/runs/20555519332/job/59039195104